Skip to content

Support CommandBarButton with icon and label#2117

Merged
joannaquu merged 1 commit intomicrosoft:mainfrom
joannaquu:joannaqu/ccb
Jan 16, 2025
Merged

Support CommandBarButton with icon and label#2117
joannaquu merged 1 commit intomicrosoft:mainfrom
joannaquu:joannaqu/ccb

Conversation

@joannaquu
Copy link
Copy Markdown
Contributor

@joannaquu joannaquu commented Jan 16, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Currently, our CommandBarButton only supports icon-only or label-only buttons. Add the ability to have an icon and label button.

Verification

Visual Verification
Before After
before after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner January 16, 2025 19:05
@joannaquu joannaquu merged commit 2b34d62 into microsoft:main Jan 16, 2025
@joannaquu joannaquu deleted the joannaqu/ccb branch January 16, 2025 23:29
@joannaquu joannaquu mentioned this pull request Apr 4, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants