Make sure componentRef types match base component type#4330
Merged
dzearing merged 2 commits intomicrosoft:masterfrom Mar 23, 2018
Merged
Conversation
mtennoe
approved these changes
Mar 22, 2018
Contributor
|
@Jahnp Can you manually approve/merge this? |
joschect
approved these changes
Mar 22, 2018
Member
|
@jordandrako, it looks good to me, but with a change this wide-ranging, @dzearing should really be the one to merge. |
dzearing
approved these changes
Mar 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
BaseComponent defines the
componentRefas receivingnullas a possible value.However a lot of the components defined the prop without taking the
nullvalue into account. But do not guarantee that this is actually the case in the component. This caused a hole in the type system as the function can be called withnullbut we don't protect against it.This PR fixes up all the componentRef type definitions by adding the possible
nullvalue.componentRef?: (component: ICommandBar | null) => void;
Focus areas to test
Effects types only, so should not have any effect on JS.