chore: deprecate preview packages already published as stable#32436
Merged
dmytrokirpa merged 16 commits intomicrosoft:masterfrom Sep 26, 2024
Merged
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
4b3e97d to
c95c9ae
Compare
Hotell
reviewed
Sep 3, 2024
Contributor
Hotell
left a comment
There was a problem hiding this comment.
looking really forward to finally land this !
couple of things that we need to address/redo though. ty
23f8c21 to
0d7d4ac
Compare
Hotell
reviewed
Sep 11, 2024
Contributor
Hotell
left a comment
There was a problem hiding this comment.
left additional batch of comments, after resolved we are good to go. ty
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
958a47b to
068e9ea
Compare
068e9ea to
fab5492
Compare
6d88f88 to
676bf1a
Compare
Hotell
approved these changes
Sep 24, 2024
Contributor
Hotell
left a comment
There was a problem hiding this comment.
added comments.
note: some of them need to be addressed within this PR
ty
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.spec.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.spec.ts
Outdated
Show resolved
Hide resolved
scripts/executors/src/deprecate-react-components-preview-packages.spec.ts
Outdated
Show resolved
Hide resolved
0292fe7 to
16f51ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
It was not possible to deprecate the preview packages once they had been published as stable.
New Behavior
Manual Trigger: Implemented a new pipeline that deprecates packages supplied through an environment variable on ADO, adhering to the npm deprecate command arguments (https://docs.npmjs.com/cli/v10/commands/npm-deprecate).
Automated Trigger During v9 Release: Introduced a script that runs during the v9 release. It reviews change files for a particular change type and message to identify the transition from preview to stable, and then carries out the
npm deprecatecommand accordingly.Related Issue(s)