chore: upgrade to typescript-eslint v8 by mainframev · Pull Request #32369 · microsoft/fluentui

mainframev · 2024-08-23T12:19:24Z

Previous Behavior

New Behavior

Upgraded @typescript-eslint to v8

Related Issue(s)

~~❌ Currently blocked by nx. When nx will upgrade to the latest eslint and will bump @typescript-eslint to v8 as well in @nx/eslint-plugin we can proceed forward with this.~~

Before	After
11m 5s	10m 23s / 𝚫 6.3% 🚀 faster

Partially implements [Feature]: migrate to latest eslint/@typescript-eslint #30334

fabricteam · 2024-08-23T12:32:36Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender	38	28	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	629	625	5000
Button	mount	296	302	5000
Field	mount	1114	1156	5000
FluentProvider	mount	708	703	5000
FluentProviderWithTheme	mount	85	80	10
FluentProviderWithTheme	virtual-rerender	38	28	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	74	78	10
MakeStyles	mount	859	864	50000
Persona	mount	1784	1744	5000
SpinButton	mount	1354	1405	5000
SwatchPicker	mount	1660	1646	5000

fabricteam · 2024-08-23T12:35:43Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
IconMinimalPerf.default	423	385	1.1:1
TextAreaMinimalPerf.default	304	277	1.1:1
ImageMinimalPerf.default	236	219	1.08:1
LabelMinimalPerf.default	235	219	1.07:1
ListMinimalPerf.default	332	310	1.07:1
AvatarMinimalPerf.default	115	108	1.06:1
ButtonMinimalPerf.default	94	89	1.06:1
ListNestedPerf.default	330	310	1.06:1
RadioGroupMinimalPerf.default	276	261	1.06:1
BoxMinimalPerf.default	196	186	1.05:1
ChatDuplicateMessagesPerf.default	161	154	1.05:1
FlexMinimalPerf.default	162	155	1.05:1
ItemLayoutMinimalPerf.default	741	707	1.05:1
ReactionMinimalPerf.default	216	206	1.05:1
CarouselMinimalPerf.default	267	257	1.04:1
ListWith60ListItems.default	388	373	1.04:1
ButtonSlotsPerf.default	315	306	1.03:1
HeaderMinimalPerf.default	215	208	1.03:1
HeaderSlotsPerf.default	477	464	1.03:1
ListCommonPerf.default	414	401	1.03:1
MenuMinimalPerf.default	519	502	1.03:1
MenuButtonMinimalPerf.default	975	943	1.03:1
PopupMinimalPerf.default	357	347	1.03:1
SkeletonMinimalPerf.default	200	194	1.03:1
SplitButtonMinimalPerf.default	2311	2245	1.03:1
AlertMinimalPerf.default	165	162	1.02:1
ButtonOverridesMissPerf.default	670	658	1.02:1
DropdownMinimalPerf.default	1477	1450	1.02:1
EmbedMinimalPerf.default	1927	1887	1.02:1
GridMinimalPerf.default	199	196	1.02:1
RefMinimalPerf.default	115	113	1.02:1
SegmentMinimalPerf.default	198	194	1.02:1
TextMinimalPerf.default	196	192	1.02:1
TreeWith60ListItems.default	93	91	1.02:1
CheckboxMinimalPerf.default	1149	1142	1.01:1
DialogMinimalPerf.default	453	448	1.01:1
DividerMinimalPerf.default	209	207	1.01:1
FormMinimalPerf.default	237	235	1.01:1
ProviderMinimalPerf.default	206	204	1.01:1
TableManyItemsPerf.default	1126	1117	1.01:1
AttachmentMinimalPerf.default	80	80	1:1
DatepickerMinimalPerf.default	3571	3588	1:1
PortalMinimalPerf.default	85	85	1:1
SliderMinimalPerf.default	763	761	1:1
TooltipMinimalPerf.default	1299	1294	1:1
TreeMinimalPerf.default	491	489	1:1
ChatWithPopoverPerf.default	199	202	0.99:1
InputMinimalPerf.default	550	555	0.99:1
LoaderMinimalPerf.default	187	189	0.99:1
ProviderMergeThemesPerf.default	659	666	0.99:1
CustomToolbarPrototype.default	1463	1474	0.99:1
ToolbarMinimalPerf.default	527	535	0.99:1
VideoMinimalPerf.default	443	453	0.98:1
DropdownManyItemsPerf.default	393	405	0.97:1
RosterPerf.default	1557	1606	0.97:1
StatusMinimalPerf.default	382	394	0.97:1
TableMinimalPerf.default	230	237	0.97:1
AnimationMinimalPerf.default	300	313	0.96:1
AttachmentSlotsPerf.default	634	670	0.95:1
CardMinimalPerf.default	305	322	0.95:1
ChatMinimalPerf.default	429	453	0.95:1
AccordionMinimalPerf.default	74	80	0.93:1
LayoutMinimalPerf.default	188	205	0.92:1

fabricteam · 2024-08-23T12:39:41Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-08-23T12:41:01Z

📊 Bundle size report

Package & Exports	Baseline (minified/GZIP)	PR	Change
`react-northstar` Accordion	`85.383 kB` `26.519 kB`	`85.38 kB` `26.519 kB`	`-3 B`
`react-northstar` Alert	`87.438 kB` `26.904 kB`	`87.435 kB` `26.905 kB`	`-3 B` `1 B`
`react-northstar` Attachment	`86.832 kB` `26.7 kB`	`86.829 kB` `26.7 kB`	`-3 B`
`react-northstar` Avatar	`80.267 kB` `24.633 kB`	`80.264 kB` `24.633 kB`	`-3 B`
`react-northstar` Box	`75.236 kB` `23.812 kB`	`75.233 kB` `23.813 kB`	`-3 B` `1 B`
`react-northstar` Breadcrumb	`79.911 kB` `24.717 kB`	`79.908 kB` `24.717 kB`	`-3 B`
`react-northstar` Button	`83.148 kB` `25.952 kB`	`83.145 kB` `25.952 kB`	`-3 B`
`react-northstar` Card	`82.696 kB` `25.036 kB`	`82.693 kB` `25.037 kB`	`-3 B` `1 B`
`react-northstar` Carousel	`105.173 kB` `31.872 kB`	`105.17 kB` `31.873 kB`	`-3 B` `1 B`
`react-northstar` Chat	`154.081 kB` `46.876 kB`	`154.072 kB` `46.878 kB`	`-9 B` `2 B`
`react-northstar` Checkbox	`79.795 kB` `25.08 kB`	`79.792 kB` `25.08 kB`	`-3 B`
`react-northstar` Datepicker	`186.642 kB` `56.99 kB`	`186.639 kB` `56.99 kB`	`-3 B`
`react-northstar` Dialog	`112.049 kB` `33.622 kB`	`112.046 kB` `33.622 kB`	`-3 B`
`react-northstar` Divider	`76.607 kB` `24.135 kB`	`76.604 kB` `24.135 kB`	`-3 B`
`react-northstar` Dropdown	`198.202 kB` `60.222 kB`	`198.196 kB` `60.223 kB`	`-6 B` `1 B`
`react-northstar` Embed	`81.468 kB` `25.424 kB`	`81.465 kB` `25.425 kB`	`-3 B` `1 B`
`react-northstar` Form	`92.518 kB` `28.888 kB`	`92.515 kB` `28.888 kB`	`-3 B`
`react-northstar` Grid	`70.572 kB` `22.282 kB`	`70.569 kB` `22.283 kB`	`-3 B` `1 B`
`react-northstar` Header	`74.744 kB` `23.465 kB`	`74.741 kB` `23.465 kB`	`-3 B`
`react-northstar` Image	`73.579 kB` `23.333 kB`	`73.576 kB` `23.333 kB`	`-3 B`
`react-northstar` Input	`88.337 kB` `27.78 kB`	`88.334 kB` `27.781 kB`	`-3 B` `1 B`
`react-northstar` ItemLayout	`78.219 kB` `24.458 kB`	`78.213 kB` `24.457 kB`	`-6 B` `-1 B`
`react-northstar` Label	`77.908 kB` `24.413 kB`	`77.905 kB` `24.414 kB`	`-3 B` `1 B`
`react-northstar` Layout	`75.381 kB` `23.803 kB`	`75.378 kB` `23.803 kB`	`-3 B`
`react-northstar` List	`88.481 kB` `27.556 kB`	`88.475 kB` `27.555 kB`	`-6 B` `-1 B`
`react-northstar` Loader	`78.604 kB` `24.733 kB`	`78.601 kB` `24.733 kB`	`-3 B`
`react-northstar` Menu	`128.593 kB` `40.737 kB`	`128.587 kB` `40.738 kB`	`-6 B` `1 B`
`react-northstar` MenuButton	`162.999 kB` `49.613 kB`	`162.993 kB` `49.614 kB`	`-6 B` `1 B`
`react-northstar` Pill	`83.71 kB` `26.069 kB`	`83.707 kB` `26.069 kB`	`-3 B`
`react-northstar` Popup	`135.307 kB` `42.257 kB`	`135.304 kB` `42.259 kB`	`-3 B` `2 B`
`react-northstar` Portal	`58.329 kB` `18.851 kB`	`58.326 kB` `18.851 kB`	`-3 B`
`react-northstar` RadioGroup	`83.273 kB` `26.053 kB`	`83.27 kB` `26.053 kB`	`-3 B`
`react-northstar` Reaction	`77.268 kB` `24.127 kB`	`77.265 kB` `24.128 kB`	`-3 B` `1 B`
`react-northstar` Segment	`76.197 kB` `23.896 kB`	`76.194 kB` `23.896 kB`	`-3 B`
`react-northstar` Skeleton	`77.753 kB` `24.205 kB`	`77.75 kB` `24.205 kB`	`-3 B`
`react-northstar` Slider	`84.261 kB` `26.755 kB`	`84.258 kB` `26.757 kB`	`-3 B` `2 B`
`react-northstar` SplitButton	`178.237 kB` `53.438 kB`	`178.231 kB` `53.438 kB`	`-6 B`
`react-northstar` Status	`76.26 kB` `24.054 kB`	`76.257 kB` `24.054 kB`	`-3 B`
`react-northstar` Table	`80.787 kB` `25.156 kB`	`80.784 kB` `25.157 kB`	`-3 B` `1 B`
`react-northstar` Text	`74.102 kB` `23.511 kB`	`74.099 kB` `23.511 kB`	`-3 B`
`react-northstar` TextArea	`74.236 kB` `23.496 kB`	`74.233 kB` `23.496 kB`	`-3 B`
`react-northstar` Toolbar	`175.048 kB` `52.846 kB`	`175.042 kB` `52.844 kB`	`-6 B` `-2 B`
`react-northstar` Tooltip	`109.964 kB` `35.236 kB`	`109.961 kB` `35.238 kB`	`-3 B` `2 B`
`react-northstar` Tree	`87.843 kB` `27.222 kB`	`87.84 kB` `27.223 kB`	`-3 B` `1 B`
`react-northstar` Video	`75.402 kB` `23.797 kB`	`75.399 kB` `23.796 kB`	`-3 B` `-1 B`

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `328 B`
`global-context` createContextSelector	`537 B` `339 B`
`keyboard-key` keyboard-key package	`3.746 kB` `1.928 kB`
`priority-overflow` createOverflowManager	`4.457 kB` `1.856 kB`
`react` ActivityItem	`71.236 kB` `23.357 kB`
`react` Announced	`38.493 kB` `13.297 kB`
`react` Autofill	`15.428 kB` `4.768 kB`
`react` Breadcrumb	`202.406 kB` `60.482 kB`
`react` Button	`195.858 kB` `56.697 kB`
`react` ButtonGrid	`180.792 kB` `54.683 kB`
`react` Calendar	`121.905 kB` `37.046 kB`
`react` Callout	`84.33 kB` `27.648 kB`
`react` Check	`53.204 kB` `17.848 kB`
`react` Checkbox	`59.985 kB` `19.903 kB`
`react` ChoiceGroup	`65.494 kB` `21.489 kB`
`react` ChoiceGroupOption	`58.767 kB` `19.362 kB`
`react` Coachmark	`93.151 kB` `29.428 kB`
`react` Color	`7.789 kB` `3.127 kB`
`react` ColorPicker	`135.359 kB` `42.257 kB`
`react` ComboBox	`252.295 kB` `72.392 kB`
`react` CommandBar	`203.447 kB` `60.224 kB`
`react` ContextualMenu	`155.273 kB` `48.228 kB`
`react` DatePicker	`184.333 kB` `56.194 kB`
`react` DateTimeUtilities	`5.244 kB` `1.849 kB`
`react` DetailsList	`230.107 kB` `65.952 kB`
`react` Dialog	`211.784 kB` `63.237 kB`
`react` Divider	`19.603 kB` `6.845 kB`
`react` DocumentCard	`217.399 kB` `64.512 kB`
`react` DragDrop	`8.343 kB` `2.724 kB`
`react` DraggableZone	`34.305 kB` `11.509 kB`
`react` Dropdown	`234.345 kB` `68.729 kB`
`react` ExtendedPicker	`96.924 kB` `27.92 kB`
`react` Fabric	`41.745 kB` `14.366 kB`
`react` Facepile	`210.998 kB` `63.254 kB`
`react` FloatingPicker	`242.44 kB` `69.088 kB`
`react` FocusTrapZone	`17.03 kB` `5.924 kB`
`react` FocusZone	`55.182 kB` `17.503 kB`
`react` Grid	`180.792 kB` `54.683 kB`
`react` GroupedList	`135.178 kB` `40.798 kB`
`react` GroupedListV2	`122.767 kB` `37.881 kB`
`react` HoverCard	`97.179 kB` `30.82 kB`
`react` Icon	`51.885 kB` `17.272 kB`
`react` Icons	`66.361 kB` `24.397 kB`
`react` Image	`46.904 kB` `15.707 kB`
`react` Keytip	`81.693 kB` `26.766 kB`
`react` KeytipData	`14.039 kB` `4.588 kB`
`react` KeytipLayer	`103.478 kB` `32.017 kB`
`react` Keytips	`106.25 kB` `33.023 kB`
`react` Label	`38.347 kB` `13.257 kB`
`react` Layer	`48.099 kB` `16.367 kB`
`react` Link	`39.682 kB` `13.67 kB`
`react` List	`39.4 kB` `12.481 kB`
`react` MarqueeSelection	`74.541 kB` `22.44 kB`
`react` MessageBar	`190.922 kB` `57.155 kB`
`react` Modal	`93.747 kB` `30.278 kB`
`react` Nav	`188.398 kB` `56.575 kB`
`react` OverflowSet	`33.393 kB` `11.329 kB`
`react` Overlay	`40.902 kB` `14.095 kB`
`react` Panel	`201.456 kB` `60.076 kB`
`react` Persona	`114.967 kB` `36.546 kB`
`react` PersonaCoin	`114.967 kB` `36.546 kB`
`react` PersonaPresence	`58.074 kB` `19.384 kB`
`react` Pickers	`294.462 kB` `82.501 kB`
`react` Pivot	`189.29 kB` `57.329 kB`
`react` Popup	`12.294 kB` `4.195 kB`
`react` Positioning	`22.807 kB` `7.701 kB`
`react` PositioningContainer	`73.85 kB` `23.765 kB`
`react` ProgressIndicator	`39.504 kB` `13.554 kB`
`react` Rating	`82.143 kB` `26.144 kB`
`react` Fluent UI React (entire library)	`1.015 MB` `282.182 kB`
`react` ResizeGroup	`13.338 kB` `4.377 kB`
`react` ResponsiveMode	`8.13 kB` `2.966 kB`
`react` ScrollablePane	`55.563 kB` `17.734 kB`
`react` SearchBox	`189.171 kB` `56.737 kB`
`react` SelectableOption	`724 B` `413 B`
`react` SelectedItemsList	`232.95 kB` `67.977 kB`
`react` Selection	`42.464 kB` `12.301 kB`
`react` Separator	`35.384 kB` `12.146 kB`
`react` Shimmer	`49.259 kB` `16.268 kB`
`react` ShimmeredDetailsList	`240.889 kB` `68.7 kB`
`react` Slider	`57.651 kB` `19.217 kB`
`react` SpinButton	`192.874 kB` `57.835 kB`
`react` Spinner	`41.777 kB` `14.478 kB`
`react` Stack	`41.734 kB` `14.268 kB`
`react` Sticky	`32.613 kB` `10.509 kB`
`react` Styling	`46.033 kB` `15.135 kB`
`react` SwatchColorPicker	`191.117 kB` `58.19 kB`
`react` TeachingBubble	`206.173 kB` `61.106 kB`
`react` Text	`36.908 kB` `12.822 kB`
`react` TextField	`80.816 kB` `25.332 kB`
`react` Theme	`43.501 kB` `14.183 kB`
`react` ThemeGenerator	`12.392 kB` `4.126 kB`
`react` TimePicker	`242.077 kB` `70.14 kB`
`react` Toggle	`46.225 kB` `15.986 kB`
`react` Tooltip	`87.456 kB` `28.268 kB`
`react` Utilities	`82.931 kB` `25.148 kB`
`react` Viewport	`23.888 kB` `7.656 kB`
`react` WeeklyDayPicker	`102.058 kB` `31.861 kB`
`react` WindowProvider	`1.059 kB` `541 B`
`react-accordion` Accordion (including children components)	`106.678 kB` `32.689 kB`
`react-avatar` Avatar	`49.303 kB` `15.815 kB`
`react-avatar` AvatarGroup	`20.106 kB` `7.968 kB`
`react-avatar` AvatarGroupItem	`63.447 kB` `20.034 kB`
`react-badge` Badge	`25.954 kB` `8.595 kB`
`react-badge` CounterBadge	`26.733 kB` `8.872 kB`
`react-badge` PresenceBadge	`25.719 kB` `9.457 kB`
`react-breadcrumb` @fluentui/react-breadcrumb - package	`114.221 kB` `31.654 kB`
`react-button` Button	`37.104 kB` `10.766 kB`
`react-button` CompoundButton	`43.518 kB` `12.068 kB`
`react-button` MenuButton	`41.919 kB` `12.108 kB`
`react-button` SplitButton	`49.936 kB` `13.681 kB`
`react-button` ToggleButton	`53.037 kB` `12.528 kB`
`react-calendar-compat` Calendar Compat	`150.095 kB` `40.026 kB`
`react-card` Card - All	`101.77 kB` `28.772 kB`
`react-card` Card	`94.544 kB` `26.951 kB`
`react-card` CardFooter	`14.355 kB` `5.79 kB`
`react-card` CardHeader	`16.888 kB` `6.669 kB`
`react-card` CardPreview	`14.42 kB` `5.922 kB`
`react-checkbox` Checkbox	`35.118 kB` `12.077 kB`
`react-combobox` Combobox (including child components)	`104.398 kB` `34.199 kB`
`react-combobox` Dropdown (including child components)	`105.011 kB` `34.125 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`69.14 kB` `20.137 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`220.546 kB` `63.86 kB`
`react-components` react-components: FluentProvider & webLightTheme	`44.447 kB` `14.59 kB`
`react-components` react-components: entire library	`1.159 MB` `290.27 kB`
`react-datepicker-compat` DatePicker Compat	`224.165 kB` `63.423 kB`
`react-dialog` Dialog (including children components)	`100.247 kB` `30.042 kB`
`react-divider` Divider	`21.328 kB` `7.953 kB`
`react-field` Field	`23.384 kB` `8.891 kB`
`react-image` Image	`15.36 kB` `6.236 kB`
`react-input` Input	`28.014 kB` `9.444 kB`
`react-jsx-runtime` Classic Pragma	`1.057 kB` `530 B`
`react-jsx-runtime` JSX Dev Runtime	`3.771 kB` `1.643 kB`
`react-jsx-runtime` JSX Runtime	`4.367 kB` `1.874 kB`
`react-label` Label	`14.671 kB` `5.99 kB`
`react-link` Link	`17.326 kB` `7.032 kB`
`react-list-preview` List	`89.148 kB` `26.597 kB`
`react-list-preview` ListItem	`112.707 kB` `33.428 kB`
`react-menu` Menu (including children components)	`152.611 kB` `46.087 kB`
`react-menu` Menu (including selectable components)	`155.292 kB` `46.57 kB`
`react-message-bar` MessageBar (all components)	`24.878 kB` `9.264 kB`
`react-motion` @fluentui/react-motion - createMotionComponent()	`4.303 kB` `1.899 kB`
`react-motion` @fluentui/react-motion - createPresenceComponent()	`5.038 kB` `2.229 kB`
`react-motion` @fluentui/react-motion - PresenceGroup	`1.714 kB` `819 B`
`react-northstar` Animation	`55.331 kB` `17.83 kB`
`react-northstar` Debug	`8.801 kB` `3.594 kB`
`react-northstar` Design	`36.589 kB` `12.067 kB`
`react-northstar` Flex	`47.716 kB` `15.443 kB`
`react-northstar` Provider	`93.129 kB` `29.627 kB`
`react-northstar` SvgIcon	`36.811 kB` `11.746 kB`
`react-overflow` hooks only	`12.808 kB` `4.819 kB`
`react-persona` Persona	`56.194 kB` `17.695 kB`
`react-popover` Popover	`128.854 kB` `40.286 kB`
`react-portal` Portal	`14.563 kB` `5.118 kB`
`react-portal-compat` PortalCompatProvider	`8.39 kB` `2.64 kB`
`react-positioning` usePositioning	`27.057 kB` `9.698 kB`
`react-progress` ProgressBar	`17.084 kB` `6.891 kB`
`react-provider` FluentProvider	`24.623 kB` `8.893 kB`
`react-radio` Radio	`32.672 kB` `10.343 kB`
`react-radio` RadioGroup	`15.762 kB` `6.423 kB`
`react-select` Select	`27.732 kB` `10.124 kB`
`react-slider` Slider	`37.169 kB` `12.538 kB`
`react-spinbutton` SpinButton	`36.06 kB` `11.815 kB`
`react-spinner` Spinner	`25.245 kB` `8.539 kB`
`react-swatch-picker` @fluentui/react-swatch-picker - package	`104.258 kB` `30.231 kB`
`react-switch` Switch	`35.319 kB` `11.314 kB`
`react-table` DataGrid	`161.002 kB` `45.684 kB`
`react-table` Table (Primitives only)	`42.643 kB` `13.82 kB`
`react-table` Table as DataGrid	`131.837 kB` `36.531 kB`
`react-table` Table (Selection only)	`70.504 kB` `19.962 kB`
`react-table` Table (Sort only)	`69.147 kB` `19.574 kB`
`react-tag-picker` @fluentui/react-tag-picker - package	`184.106 kB` `55.428 kB`
`react-tags` InteractionTag	`15.199 kB` `6.157 kB`
`react-tags` Tag	`29.016 kB` `9.524 kB`
`react-tags` TagGroup	`82.719 kB` `24.524 kB`
`react-text` Text - Default	`17.061 kB` `6.723 kB`
`react-text` Text - Wrappers	`20.242 kB` `7.048 kB`
`react-textarea` Textarea	`26.572 kB` `9.755 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`35.666 kB` `7.453 kB`
`react-theme` Teams: Light theme	`19.642 kB` `5.549 kB`
`react-timepicker-compat` TimePicker	`107.387 kB` `35.758 kB`
`react-toast` Toast (including Toaster)	`98.338 kB` `29.591 kB`
`react-tooltip` Tooltip	`55.517 kB` `19.515 kB`
`react-utilities` SSRProvider	`180 B` `160 B`

_{🤖 This report was generated against e659bb600eaf477d9d2a9ab598f923b9f90135b7}

fabricteam · 2024-08-23T12:43:40Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	633	642	5000
Breadcrumb	mount	1726	1710	1000
Checkbox	mount	1687	1730	5000
CheckboxBase	mount	1479	1503	5000
ChoiceGroup	mount	2964	2982	5000
ComboBox	mount	679	670	1000
CommandBar	mount	6572	6577	1000
ContextualMenu	mount	12418	12282	1000
DefaultButton	mount	794	806	5000
DetailsRow	mount	2226	2253	5000
DetailsRowFast	mount	2266	2237	5000
DetailsRowNoStyles	mount	2047	2091	5000
Dialog	mount	2675	2825	1000
DocumentCardTitle	mount	240	233	1000
Dropdown	mount	1998	2006	5000
FocusTrapZone	mount	1187	1188	5000
FocusZone	mount	1087	1091	5000
GroupedList	mount	42337	42902	2
GroupedList	virtual-rerender	20367	20434	2
GroupedList	virtual-rerender-with-unmount	51841	52358	2
GroupedListV2	mount	234	229	2
GroupedListV2	virtual-rerender	213	216	2
GroupedListV2	virtual-rerender-with-unmount	229	232	2
IconButton	mount	1156	1143	5000
Label	mount	346	345	5000
Layer	mount	2756	2799	5000
Link	mount	406	395	5000
MenuButton	mount	988	1013	5000
MessageBar	mount	21501	21521	5000
Nav	mount	2047	2044	1000
OverflowSet	mount	798	788	5000
Panel	mount	1905	1841	1000
Persona	mount	726	778	1000
Pivot	mount	895	905	1000
PrimaryButton	mount	916	914	5000
Rating	mount	4687	4655	5000
SearchBox	mount	923	933	5000
Shimmer	mount	1869	1887	5000
Slider	mount	1370	1342	5000
SpinButton	mount	3017	2993	5000
Spinner	mount	393	390	5000
SplitButton	mount	1911	1905	5000
Stack	mount	423	429	5000
StackWithIntrinsicChildren	mount	881	885	5000
StackWithTextChildren	mount	2748	2779	5000
SwatchColorPicker	mount	6486	6341	5000
TagPicker	mount	1450	1467	5000
Text	mount	377	387	5000
TextField	mount	968	900	5000
ThemeProvider	mount	848	840	5000
ThemeProvider	virtual-rerender	577	586	5000
ThemeProvider	virtual-rerender-with-unmount	1334	1298	5000
Toggle	mount	587	628	5000
buttonNative	mount	193	196	5000

package.json

packages/eslint-plugin/src/rules/ban-context-export/index.test.js

packages/eslint-plugin/src/rules/ban-instanceof-html-element/index.test.js

packages/eslint-plugin/src/rules/no-tslint-comments.js

packages/eslint-plugin/package.json

Hotell · 2024-09-26T08:28:21Z

@mainframev once this lands #32923 we are good to go

change/@fluentui-eslint-plugin-9708d729-ebb2-44cd-8fe1-30cf46fc403d.json

tools/eslint-rules/rules/consistent-callback-type.spec.ts

…avior

fabricteam · 2024-10-17T11:03:02Z

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

change/@fluentui-eslint-plugin-9708d729-ebb2-44cd-8fe1-30cf46fc403d.json

packages/eslint-plugin/src/rules/ban-context-export/index.test.js

packages/fluentui/docs/src/components/ComponentDoc/ComponentSourceManager/getExampleModule.ts

tools/eslint-rules/rules/no-restricted-globals.ts

…c403d.json Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

Co-authored-by: Martin Hochel <hochelmartin@gmail.com>

…ex.test.js

…structuredClone

Hotell

🚀 great work

Hotell · 2024-10-22T10:36:02Z

would be great to get bench data as well ( is it slower/faster thatn ts-eslint v7 )

mainframev force-pushed the chore/upgrade-typescript-eslint-v8 branch from 8594e22 to 6960670 Compare August 23, 2024 12:26

fabricteam reviewed Aug 23, 2024

View reviewed changes

package.json Show resolved Hide resolved