Skip to content

chore: update repo targetDefaults for test target to not run build and update specific v8 target dependants that needs build before test #32280

Merged
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:nx/target-definitions-perf
Aug 14, 2024
Merged

chore: update repo targetDefaults for test target to not run build and update specific v8 target dependants that needs build before test #32280
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:nx/target-definitions-perf

Conversation

@Hotell
Copy link
Collaborator

@Hotell Hotell commented Aug 12, 2024 •
edited
Loading

Previous Behavior

nx run <project-name>:test executes build on all dependencies before running test for all projects

New Behavior

nx run <project-name>:test executes build on all dependencies only if necessary ( some v8 projects )

this improves pipeline orchestration as test targets can be executed before/in parallel with other tasks like build

Perf

nx run react-migration-v8-v9:test time
before 259s
after 92s / 65% FASTER

Related Issue(s)

@github-actions github-actions bot added this to the August Project Cycle Q3 2024 milestone Aug 12, 2024
@Hotell Hotell mentioned this pull request Aug 12, 2024
Closed
39 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 12, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 34 38 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 668 641 5000
Button mount 318 311 5000
Field mount 1157 1132 5000
FluentProvider mount 698 709 5000
FluentProviderWithTheme mount 78 83 10
FluentProviderWithTheme virtual-rerender 34 38 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 77 74 10
MakeStyles mount 880 844 50000
Persona mount 1778 1715 5000
SpinButton mount 1434 1408 5000
SwatchPicker mount 1674 1617 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 12, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

fabricteam
fabricteam reviewed Aug 12, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 12, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AttachmentMinimalPerf.default 95 77 1.23:1 analysis
PortalMinimalPerf.default 86 80 1.08:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 221 196 1.13:1
RefMinimalPerf.default 113 102 1.11:1
TreeWith60ListItems.default 92 84 1.1:1
BoxMinimalPerf.default 215 197 1.09:1
LayoutMinimalPerf.default 211 193 1.09:1
AvatarMinimalPerf.default 114 107 1.07:1
FlexMinimalPerf.default 162 152 1.07:1
TableMinimalPerf.default 244 229 1.07:1
ListMinimalPerf.default 331 311 1.06:1
LoaderMinimalPerf.default 184 174 1.06:1
TextMinimalPerf.default 201 190 1.06:1
ImageMinimalPerf.default 231 221 1.05:1
ListCommonPerf.default 399 380 1.05:1
SegmentMinimalPerf.default 201 192 1.05:1
CheckboxMinimalPerf.default 1150 1108 1.04:1
DialogMinimalPerf.default 460 441 1.04:1
DividerMinimalPerf.default 206 199 1.04:1
LabelMinimalPerf.default 223 214 1.04:1
AnimationMinimalPerf.default 313 304 1.03:1
PopupMinimalPerf.default 360 351 1.03:1
SliderMinimalPerf.default 754 734 1.03:1
TooltipMinimalPerf.default 1303 1271 1.03:1
AlertMinimalPerf.default 168 164 1.02:1
DropdownMinimalPerf.default 1421 1394 1.02:1
ListNestedPerf.default 328 323 1.02:1
MenuButtonMinimalPerf.default 961 943 1.02:1
ReactionMinimalPerf.default 220 215 1.02:1
TableManyItemsPerf.default 1132 1115 1.02:1
ButtonMinimalPerf.default 86 85 1.01:1
CardMinimalPerf.default 314 312 1.01:1
ItemLayoutMinimalPerf.default 699 689 1.01:1
SkeletonMinimalPerf.default 200 198 1.01:1
SplitButtonMinimalPerf.default 2278 2264 1.01:1
ToolbarMinimalPerf.default 548 544 1.01:1
AttachmentSlotsPerf.default 637 638 1:1
ChatMinimalPerf.default 430 430 1:1
DatepickerMinimalPerf.default 3565 3558 1:1
FormMinimalPerf.default 220 219 1:1
GridMinimalPerf.default 189 189 1:1
RosterPerf.default 1545 1546 1:1
ProviderMergeThemesPerf.default 657 660 1:1
RadioGroupMinimalPerf.default 259 259 1:1
AccordionMinimalPerf.default 80 81 0.99:1
ButtonSlotsPerf.default 316 319 0.99:1
EmbedMinimalPerf.default 1864 1889 0.99:1
HeaderSlotsPerf.default 461 464 0.99:1
ListWith60ListItems.default 357 359 0.99:1
TextAreaMinimalPerf.default 292 294 0.99:1
CustomToolbarPrototype.default 1493 1509 0.99:1
ChatDuplicateMessagesPerf.default 150 153 0.98:1
DropdownManyItemsPerf.default 389 396 0.98:1
InputMinimalPerf.default 533 542 0.98:1
MenuMinimalPerf.default 512 523 0.98:1
ProviderMinimalPerf.default 223 227 0.98:1
StatusMinimalPerf.default 403 413 0.98:1
IconMinimalPerf.default 373 382 0.98:1
ChatWithPopoverPerf.default 199 205 0.97:1
TreeMinimalPerf.default 484 501 0.97:1
ButtonOverridesMissPerf.default 650 677 0.96:1
CarouselMinimalPerf.default 251 262 0.96:1
VideoMinimalPerf.default 428 451 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 12, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam
fabricteam reviewed Aug 12, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 12, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 626 645 5000
Breadcrumb mount 1697 1700 1000
Checkbox mount 1709 1751 5000
CheckboxBase mount 1509 1524 5000
ChoiceGroup mount 3037 3016 5000
ComboBox mount 692 694 1000
CommandBar mount 6645 6682 1000
ContextualMenu mount 13268 13114 1000
DefaultButton mount 798 820 5000
DetailsRow mount 2245 2235 5000
DetailsRowFast mount 2256 2253 5000
DetailsRowNoStyles mount 2107 2074 5000
Dialog mount 2872 2894 1000
DocumentCardTitle mount 218 228 1000
Dropdown mount 2003 2028 5000
FocusTrapZone mount 1146 1141 5000
FocusZone mount 1095 1105 5000
GroupedList mount 42739 42511 2
GroupedList virtual-rerender 20609 20661 2
GroupedList virtual-rerender-with-unmount 52360 52392 2
GroupedListV2 mount 231 242 2
GroupedListV2 virtual-rerender 220 216 2
GroupedListV2 virtual-rerender-with-unmount 219 232 2
IconButton mount 1171 1134 5000
Label mount 338 347 5000
Layer mount 2802 2729 5000
Link mount 406 389 5000
MenuButton mount 974 1004 5000
MessageBar mount 21719 21784 5000
Nav mount 2106 2039 1000
OverflowSet mount 804 778 5000
Panel mount 1940 1823 1000
Persona mount 767 782 1000
Pivot mount 929 921 1000
PrimaryButton mount 948 939 5000
Rating mount 4745 4748 5000
SearchBox mount 920 969 5000
Shimmer mount 1931 1920 5000
Slider mount 1406 1382 5000
SpinButton mount 2984 2921 5000
Spinner mount 386 403 5000
SplitButton mount 1875 1920 5000
Stack mount 415 448 5000
StackWithIntrinsicChildren mount 879 892 5000
StackWithTextChildren mount 2793 2802 5000
SwatchColorPicker mount 6445 6528 5000
TagPicker mount 1466 1462 5000
Text mount 382 373 5000
TextField mount 943 963 5000
ThemeProvider mount 867 848 5000
ThemeProvider virtual-rerender 590 585 5000
ThemeProvider virtual-rerender-with-unmount 1302 1310 5000
Toggle mount 623 624 5000
buttonNative mount 193 197 5000

@Hotell Hotell force-pushed the nx/target-definitions-perf branch from 50388fe to 9cdc81a Compare August 12, 2024 15:42
@Hotell Hotell changed the title chore: define test target dependants in order to speed up test target execution chore: update repo targetDefaults for test target to not run build and update specific v8 target dependants that needs build before test Aug 13, 2024
Hotell
Hotell commented Aug 13, 2024
View reviewed changes
@Hotell Hotell marked this pull request as ready for review August 13, 2024 10:09
@Hotell Hotell requested a review from a team as a code owner August 13, 2024 10:09
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 13, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@Hotell Hotell force-pushed the nx/target-definitions-perf branch from 69e2e76 to 88bee46 Compare August 14, 2024 07:53
@Hotell Hotell enabled auto-merge (squash) August 14, 2024 07:53
@Hotell Hotell merged commit 10ea7c5 into microsoft:master Aug 14, 2024
@Hotell Hotell deleted the nx/target-definitions-perf branch August 14, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@dmytrokirpa dmytrokirpa dmytrokirpa approved these changes

Assignees

No one assigned

Labels

NX: core

Projects

None yet

Milestone

August Project Cycle Q3 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@Hotell @fabricteam @dmytrokirpa