chore: upgrade typescript-eslint to v7 by mainframev · Pull Request #32272 · microsoft/fluentui

mainframev · 2024-08-09T16:28:27Z

Previous Behavior

New Behavior

Upgraded @typescript-eslint to v7.

New version introduce breaking changes only with supported node versions, minimal ts and eslint versions. We already using eslint 8.56.0, updated ts peer dep in eslint config to minimal supported ts version. The @typescript-eslint@7 is keeping up with eslint updates, so since this version flat config is supported. There is also announced new typescript-eslint package that we can use later with flat configuration and drop explicit dependencies on parser, eslint-plugin and utils.

Removed deprecated: getSourceCode and getFilename

Next Steps

Upgrade @typescript-eslint to v8.
Update to ESLint v9 while retaining our current configuration files. Note that starting with ESLint v9, flat configurations will become the default, and the old format will be deprecated.
Set ESLINT_USE_FLAT_CONFIG to false to continue using the old configuration format for now.
Migrate to flat configs separately as this process is more complex and falls outside the scope of [Feature]: migrate to latest eslint/@typescript-eslint #30334. This migration should be addressed after all other updates have been completed.

Related Issue(s)

Partially implements [Feature]: migrate to latest eslint/@typescript-eslint #30334

fabricteam · 2024-08-09T16:33:15Z

📊 Bundle size report

✅ No changes found

fabricteam · 2024-08-09T16:44:00Z

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

fabricteam · 2024-08-09T16:48:15Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
FluentProviderWithTheme	virtual-rerender	39	33	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	687	645	5000
Button	mount	298	303	5000
Field	mount	1127	1158	5000
FluentProvider	mount	704	717	5000
FluentProviderWithTheme	mount	82	92	10
FluentProviderWithTheme	virtual-rerender	39	33	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	81	65	10
MakeStyles	mount	874	873	50000
Persona	mount	1754	1773	5000
SpinButton	mount	1427	1453	5000
SwatchPicker	mount	1646	1666	5000

fabricteam · 2024-08-09T16:50:15Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
ButtonMinimalPerf.default	91	90	1.01:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	89	81	1.1:1
IconMinimalPerf.default	395	362	1.09:1
ListNestedPerf.default	333	310	1.07:1
AvatarMinimalPerf.default	111	105	1.06:1
RadioGroupMinimalPerf.default	271	256	1.06:1
TextMinimalPerf.default	199	187	1.06:1
AccordionMinimalPerf.default	88	84	1.05:1
AttachmentMinimalPerf.default	84	80	1.05:1
TooltipMinimalPerf.default	1326	1266	1.05:1
AnimationMinimalPerf.default	310	298	1.04:1
CarouselMinimalPerf.default	268	258	1.04:1
DropdownManyItemsPerf.default	404	387	1.04:1
LabelMinimalPerf.default	229	220	1.04:1
PortalMinimalPerf.default	86	83	1.04:1
SliderMinimalPerf.default	759	727	1.04:1
CustomToolbarPrototype.default	1536	1484	1.04:1
ToolbarMinimalPerf.default	563	540	1.04:1
BoxMinimalPerf.default	204	198	1.03:1
ButtonOverridesMissPerf.default	666	649	1.03:1
ChatWithPopoverPerf.default	187	181	1.03:1
DatepickerMinimalPerf.default	3654	3550	1.03:1
FormMinimalPerf.default	220	213	1.03:1
GridMinimalPerf.default	197	191	1.03:1
HeaderSlotsPerf.default	481	466	1.03:1
DropdownMinimalPerf.default	1467	1436	1.02:1
EmbedMinimalPerf.default	1910	1864	1.02:1
FlexMinimalPerf.default	153	150	1.02:1
MenuMinimalPerf.default	511	500	1.02:1
SkeletonMinimalPerf.default	197	193	1.02:1
TreeMinimalPerf.default	500	489	1.02:1
ChatMinimalPerf.default	446	442	1.01:1
DialogMinimalPerf.default	440	435	1.01:1
DividerMinimalPerf.default	207	204	1.01:1
RosterPerf.default	1611	1593	1.01:1
PopupMinimalPerf.default	352	347	1.01:1
RefMinimalPerf.default	106	105	1.01:1
StatusMinimalPerf.default	391	386	1.01:1
TextAreaMinimalPerf.default	306	303	1.01:1
VideoMinimalPerf.default	435	430	1.01:1
AttachmentSlotsPerf.default	658	655	1:1
CardMinimalPerf.default	306	305	1:1
ListMinimalPerf.default	305	305	1:1
LoaderMinimalPerf.default	197	197	1:1
MenuButtonMinimalPerf.default	958	958	1:1
ProviderMinimalPerf.default	203	203	1:1
SplitButtonMinimalPerf.default	2243	2244	1:1
TableManyItemsPerf.default	1091	1092	1:1
CheckboxMinimalPerf.default	1145	1153	0.99:1
ImageMinimalPerf.default	226	228	0.99:1
InputMinimalPerf.default	546	551	0.99:1
ListCommonPerf.default	400	404	0.99:1
ReactionMinimalPerf.default	208	211	0.99:1
AlertMinimalPerf.default	161	164	0.98:1
HeaderMinimalPerf.default	207	212	0.98:1
ItemLayoutMinimalPerf.default	715	727	0.98:1
LayoutMinimalPerf.default	202	207	0.98:1
ListWith60ListItems.default	373	381	0.98:1
ProviderMergeThemesPerf.default	634	646	0.98:1
SegmentMinimalPerf.default	199	203	0.98:1
TableMinimalPerf.default	225	230	0.98:1
ButtonSlotsPerf.default	314	327	0.96:1
ChatDuplicateMessagesPerf.default	154	161	0.96:1

fabricteam · 2024-08-09T16:55:52Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2024-08-09T16:58:26Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	643	639	5000
Breadcrumb	mount	1704	1693	1000
Checkbox	mount	1715	1706	5000
CheckboxBase	mount	1513	1476	5000
ChoiceGroup	mount	2990	2980	5000
ComboBox	mount	687	692	1000
CommandBar	mount	6558	6596	1000
ContextualMenu	mount	12071	11986	1000
DefaultButton	mount	813	785	5000
DetailsRow	mount	2239	2220	5000
DetailsRowFast	mount	2220	2237	5000
DetailsRowNoStyles	mount	2056	2030	5000
Dialog	mount	2855	2694	1000
DocumentCardTitle	mount	225	232	1000
Dropdown	mount	1990	2048	5000
FocusTrapZone	mount	1152	1153	5000
FocusZone	mount	1097	1078	5000
GroupedList	mount	42218	42541	2
GroupedList	virtual-rerender	20360	20603	2
GroupedList	virtual-rerender-with-unmount	51952	56662	2
GroupedListV2	mount	233	236	2
GroupedListV2	virtual-rerender	213	215	2
GroupedListV2	virtual-rerender-with-unmount	245	234	2
IconButton	mount	1120	1166	5000
Label	mount	342	334	5000
Layer	mount	2759	2746	5000
Link	mount	410	407	5000
MenuButton	mount	980	980	5000
MessageBar	mount	21374	21340	5000
Nav	mount	2049	2072	1000
OverflowSet	mount	799	784	5000
Panel	mount	1841	1824	1000
Persona	mount	787	767	1000
Pivot	mount	890	946	1000
PrimaryButton	mount	956	934	5000
Rating	mount	4781	4693	5000
SearchBox	mount	927	937	5000
Shimmer	mount	1897	1908	5000
Slider	mount	1342	1379	5000
SpinButton	mount	2978	3090	5000
Spinner	mount	398	395	5000
SplitButton	mount	1900	1894	5000
Stack	mount	428	442	5000
StackWithIntrinsicChildren	mount	886	903	5000
StackWithTextChildren	mount	2773	2794	5000
SwatchColorPicker	mount	6449	6523	5000
TagPicker	mount	1433	1460	5000
Text	mount	391	385	5000
TextField	mount	951	961	5000
ThemeProvider	mount	860	864	5000
ThemeProvider	virtual-rerender	574	584	5000
ThemeProvider	virtual-rerender-with-unmount	1329	1318	5000
Toggle	mount	615	619	5000
buttonNative	mount	190	196	5000

change/@fluentui-eslint-plugin-441efdef-6029-4a98-8c60-2019ceecfd84.json

packages/eslint-plugin/src/rules/no-context-default-value/index.js

packages/eslint-plugin/src/rules/ban-context-export/index.js

packages/eslint-plugin/src/rules/no-tslint-comments.js

Hotell

few actionables, after resolved we are ready to go ! ty

package.json

change/@fluentui-eslint-plugin-441efdef-6029-4a98-8c60-2019ceecfd84.json

package.json

Hotell · 2024-08-13T13:44:19Z

also I finally created the epic we discusssed offline (which covers few things you mentioned in the PR description ) #32289

change/@fluentui-eslint-plugin-14d72a24-8d9d-4739-ae20-c5bfccdbd508.json

packages/eslint-plugin/package.json

yarn.lock

Hotell

LGTM, awesome stuff !

mainframev changed the title ~~Chore/upgrade typescript eslint~~ chore: upgrade typescript-eslint to v7 Aug 9, 2024

mainframev force-pushed the chore/upgrade-typescript-eslint branch from 9922319 to e5a9f36 Compare August 9, 2024 16:43

mainframev added the Area: Build System label Aug 9, 2024

fabricteam reviewed Aug 9, 2024

View reviewed changes

change/@fluentui-eslint-plugin-441efdef-6029-4a98-8c60-2019ceecfd84.json Show resolved Hide resolved

mainframev commented Aug 9, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-context-default-value/index.js Show resolved Hide resolved

mainframev commented Aug 9, 2024

View reviewed changes

packages/eslint-plugin/src/rules/ban-context-export/index.js Show resolved Hide resolved

mainframev commented Aug 9, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-tslint-comments.js Show resolved Hide resolved

mainframev marked this pull request as ready for review August 11, 2024 13:19

mainframev requested a review from a team as a code owner August 11, 2024 13:19

Hotell self-requested a review August 12, 2024 08:08

Hotell reviewed Aug 13, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

change/@fluentui-eslint-plugin-441efdef-6029-4a98-8c60-2019ceecfd84.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

Hotell mentioned this pull request Aug 13, 2024

[Feature]: migrate to latest eslint/@typescript-eslint #30334

Closed

6 tasks

mainframev added 6 commits August 14, 2024 01:01

chore: upgrade @typescript-eslint to v7

d9f8d8c

chore(eslint-plugin): minimal ts version 4.7.5 to typescript-eslint

8cca880

chore(eslint-plugin): replace deprecated getFilename with filename

f609b4d

chore(eslint-plugin): replace deprecated getSourceCode with sourceCode

2f1137d

chore(eslint-plugin): fix type error

44b6876

chore: update change files

ce3ce38

mainframev force-pushed the chore/upgrade-typescript-eslint branch from eec23c1 to da1c048 Compare August 13, 2024 23:32

mainframev self-assigned this Aug 13, 2024

mainframev force-pushed the chore/upgrade-typescript-eslint branch from da1c048 to 508960f Compare August 13, 2024 23:37

fixup! chore: upgrade @typescript-eslint to v7

65f9490

mainframev force-pushed the chore/upgrade-typescript-eslint branch from 508960f to 65f9490 Compare August 13, 2024 23:41

fabricteam reviewed Aug 13, 2024

View reviewed changes

change/@fluentui-eslint-plugin-14d72a24-8d9d-4739-ae20-c5bfccdbd508.json Show resolved Hide resolved

Hotell reviewed Aug 14, 2024

View reviewed changes

packages/eslint-plugin/package.json Outdated Show resolved Hide resolved

Hotell reviewed Aug 14, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

fixup! chore: upgrade @typescript-eslint to v7

85c169b

Hotell approved these changes Aug 14, 2024

View reviewed changes

mainframev merged commit b84a02e into microsoft:master Aug 14, 2024

mainframev mentioned this pull request Aug 14, 2024

chore: bump eslint-plugin-deprecation and griffel/eslint #32306

Merged

Conversation

mainframev commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Previous Behavior

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

Uh oh!

fabricteam commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

Uh oh!

fabricteam commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hotell commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mainframev commented Aug 9, 2024 •

edited

Loading

fabricteam commented Aug 9, 2024 •

edited

Loading

fabricteam commented Aug 9, 2024 •

edited

Loading

fabricteam commented Aug 9, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Aug 9, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Aug 9, 2024 •

edited

Loading

fabricteam commented Aug 9, 2024 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Hotell commented Aug 13, 2024 •

edited

Loading