Skip to content

feat(script-executors): implement default target pre-selection to start CLI#32235

Merged
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:nx/improve-start-cmd-dx-2
Aug 8, 2024
Merged

feat(script-executors): implement default target pre-selection to start CLI#32235
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:nx/improve-start-cmd-dx-2

Conversation

@Hotell
Copy link
Collaborator

@Hotell Hotell commented Aug 6, 2024 •
edited
Loading

Previous Behavior

no targets is selected - user needs to do one additional step manually which might feel slower in comparison with original "start" UX

New Behavior

Based on package context the UI will pre-select most common (default) target so user don't have to type/choose just confirm the default.

new-start-experience-with-nx-v2-target-defaults.mov

Related Issue(s)

@github-actions github-actions bot added this to the August Project Cycle Q3 2024 milestone Aug 6, 2024
@Hotell Hotell changed the title Nx/improve start cmd dx 2 feat(script-executors): add pre-select target into start CLI to make running defaults faster Aug 6, 2024
@Hotell Hotell mentioned this pull request Aug 6, 2024
Merged
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 6, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 30 37 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 642 626 5000
Button mount 296 312 5000
Field mount 1164 1111 5000
FluentProvider mount 716 714 5000
FluentProviderWithTheme mount 83 86 10
FluentProviderWithTheme virtual-rerender 30 37 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 75 77 10
MakeStyles mount 890 856 50000
Persona mount 1760 1723 5000
SpinButton mount 1394 1444 5000
SwatchPicker mount 1640 1653 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 6, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LayoutMinimalPerf.default 207 189 1.1:1
CardMinimalPerf.default 314 290 1.08:1
LoaderMinimalPerf.default 197 186 1.06:1
RadioGroupMinimalPerf.default 276 261 1.06:1
RefMinimalPerf.default 115 108 1.06:1
VideoMinimalPerf.default 445 421 1.06:1
CheckboxMinimalPerf.default 1175 1118 1.05:1
DropdownManyItemsPerf.default 396 376 1.05:1
ReactionMinimalPerf.default 217 207 1.05:1
AvatarMinimalPerf.default 112 108 1.04:1
ChatWithPopoverPerf.default 199 191 1.04:1
ListNestedPerf.default 338 325 1.04:1
BoxMinimalPerf.default 197 191 1.03:1
ButtonMinimalPerf.default 90 87 1.03:1
ButtonOverridesMissPerf.default 655 636 1.03:1
ToolbarMinimalPerf.default 548 534 1.03:1
TreeWith60ListItems.default 96 93 1.03:1
AnimationMinimalPerf.default 308 303 1.02:1
ChatDuplicateMessagesPerf.default 152 149 1.02:1
ChatMinimalPerf.default 446 436 1.02:1
ItemLayoutMinimalPerf.default 698 681 1.02:1
PortalMinimalPerf.default 85 83 1.02:1
ProviderMinimalPerf.default 205 200 1.02:1
TextAreaMinimalPerf.default 295 288 1.02:1
CustomToolbarPrototype.default 1483 1454 1.02:1
AttachmentMinimalPerf.default 80 79 1.01:1
DatepickerMinimalPerf.default 3561 3513 1.01:1
GridMinimalPerf.default 190 189 1.01:1
ListWith60ListItems.default 374 370 1.01:1
MenuMinimalPerf.default 513 507 1.01:1
RosterPerf.default 1566 1550 1.01:1
TextMinimalPerf.default 191 189 1.01:1
ButtonSlotsPerf.default 317 317 1:1
CarouselMinimalPerf.default 260 259 1:1
EmbedMinimalPerf.default 1884 1891 1:1
ListCommonPerf.default 394 395 1:1
SliderMinimalPerf.default 755 754 1:1
IconMinimalPerf.default 381 382 1:1
TableMinimalPerf.default 225 226 1:1
TreeMinimalPerf.default 481 481 1:1
AttachmentSlotsPerf.default 631 635 0.99:1
DropdownMinimalPerf.default 1430 1439 0.99:1
HeaderMinimalPerf.default 209 212 0.99:1
ImageMinimalPerf.default 223 226 0.99:1
InputMinimalPerf.default 526 534 0.99:1
ListMinimalPerf.default 304 307 0.99:1
TooltipMinimalPerf.default 1255 1273 0.99:1
DialogMinimalPerf.default 435 445 0.98:1
DividerMinimalPerf.default 193 196 0.98:1
MenuButtonMinimalPerf.default 946 967 0.98:1
PopupMinimalPerf.default 349 356 0.98:1
StatusMinimalPerf.default 394 401 0.98:1
TableManyItemsPerf.default 1123 1148 0.98:1
FlexMinimalPerf.default 151 156 0.97:1
FormMinimalPerf.default 217 224 0.97:1
HeaderSlotsPerf.default 454 466 0.97:1
LabelMinimalPerf.default 215 221 0.97:1
ProviderMergeThemesPerf.default 628 649 0.97:1
SplitButtonMinimalPerf.default 2201 2263 0.97:1
SegmentMinimalPerf.default 192 201 0.96:1
AlertMinimalPerf.default 149 157 0.95:1
SkeletonMinimalPerf.default 194 206 0.94:1
AccordionMinimalPerf.default 77 87 0.89:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 6, 2024

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 6, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 6, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 6, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 6, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 645 617 5000
Breadcrumb mount 1655 1711 1000
Checkbox mount 1677 1673 5000
CheckboxBase mount 1461 1517 5000
ChoiceGroup mount 2972 2970 5000
ComboBox mount 672 656 1000
CommandBar mount 6382 6465 1000
ContextualMenu mount 11424 11554 1000
DefaultButton mount 799 788 5000
DetailsRow mount 2228 2184 5000
DetailsRowFast mount 2203 2249 5000
DetailsRowNoStyles mount 2004 2034 5000
Dialog mount 2706 2850 1000
DocumentCardTitle mount 230 238 1000
Dropdown mount 1982 2023 5000
FocusTrapZone mount 1122 1110 5000
FocusZone mount 1086 1098 5000
GroupedList mount 41608 41907 2
GroupedList virtual-rerender 20024 19939 2
GroupedList virtual-rerender-with-unmount 51028 51117 2
GroupedListV2 mount 223 234 2
GroupedListV2 virtual-rerender 222 222 2
GroupedListV2 virtual-rerender-with-unmount 224 236 2
IconButton mount 1132 1128 5000
Label mount 337 339 5000
Layer mount 2760 2745 5000
Link mount 406 398 5000
MenuButton mount 968 966 5000
MessageBar mount 21137 21170 5000
Nav mount 1998 2043 1000
OverflowSet mount 761 782 5000
Panel mount 1799 1817 1000
Persona mount 740 741 1000
Pivot mount 901 901 1000
PrimaryButton mount 909 918 5000
Rating mount 4634 4689 5000
SearchBox mount 928 912 5000
Shimmer mount 1880 1850 5000
Slider mount 1302 1337 5000
SpinButton mount 2977 2976 5000
Spinner mount 396 394 5000
SplitButton mount 1841 1825 5000
Stack mount 436 438 5000
StackWithIntrinsicChildren mount 882 866 5000
StackWithTextChildren mount 2738 2775 5000
SwatchColorPicker mount 6366 6352 5000
TagPicker mount 1430 1463 5000
Text mount 397 388 5000
TextField mount 953 934 5000
ThemeProvider mount 873 858 5000
ThemeProvider virtual-rerender 588 584 5000
ThemeProvider virtual-rerender-with-unmount 1284 1304 5000
Toggle mount 627 600 5000
buttonNative mount 202 192 5000

fabricteam
fabricteam reviewed Aug 6, 2024
View reviewed changes
@Hotell Hotell force-pushed the nx/improve-start-cmd-dx-2 branch from e3011a3 to 7e4b632 Compare August 8, 2024 08:06
@Hotell Hotell changed the title feat(script-executors): add pre-select target into start CLI to make running defaults faster feat(script-executors): implement default target pre-selection to start CLI Aug 8, 2024
Hotell
Hotell commented Aug 8, 2024
View reviewed changes
Hotell
Hotell commented Aug 8, 2024
View reviewed changes
@Hotell Hotell marked this pull request as ready for review August 8, 2024 08:12
@Hotell Hotell requested a review from a team as a code owner August 8, 2024 08:12
dmytrokirpa
dmytrokirpa reviewed Aug 8, 2024
View reviewed changes
dmytrokirpa
dmytrokirpa reviewed Aug 8, 2024
View reviewed changes
@Hotell Hotell merged commit bab2d94 into microsoft:master Aug 8, 2024
@Hotell Hotell deleted the nx/improve-start-cmd-dx-2 branch August 8, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@dmytrokirpa dmytrokirpa dmytrokirpa approved these changes

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees

No one assigned

Labels

Area: DevExp NX: core

Projects

None yet

Milestone

August Project Cycle Q3 2024

Development

Successfully merging this pull request may close these issues.

4 participants

@Hotell @fabricteam @dmytrokirpa @tudorpopams