Skip to content

ci(web-components): PR builds no longer fail#32202

Merged
JustSlone merged 3 commits intomicrosoft:masterfrom
TristanWatanabe:tristan/fix-web-components-build
Aug 1, 2024
Merged

ci(web-components): PR builds no longer fail#32202
JustSlone merged 3 commits intomicrosoft:masterfrom
TristanWatanabe:tristan/fix-web-components-build

Conversation

@TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Aug 1, 2024

Previous Behavior

  • type-check was running before build causing error below and blocking any web-components related PRs from getting merged:
image

New Behavior

  • build runs before type-check which mitigates error

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@TristanWatanabe TristanWatanabe marked this pull request as ready for review August 1, 2024 21:00
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner August 1, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants