Skip to content

ci: separate build and bundle for v8 release in order to mitigate accidental clean task runs that would remove /dist assets#32195

Merged
spmonahan merged 3 commits intomicrosoft:masterfrom
Hotell:ci/fix-v8-release-pipeline
Aug 1, 2024
Merged

ci: separate build and bundle for v8 release in order to mitigate accidental clean task runs that would remove /dist assets#32195
spmonahan merged 3 commits intomicrosoft:masterfrom
Hotell:ci/fix-v8-release-pipeline

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Aug 1, 2024 •
edited
Loading

Previous Behavior

New Behavior

  • adds ability to set --production flag via env variable
  • splits bundle and build step for v8 as it was before migration
  • adds logs to verify react build assets on release
  • PERF: test/lint will use cached assets from build steps

Related Issue(s)

Hotell added 3 commits August 1, 2024 19:35
@Hotell
feat(scripts-tasks): add ability to setup production flag via env var…
96be1ed 
…iable in order to make caching work for commands that don't supprot --production flag
@Hotell
ci: separate build and bundle for v8 release in order to mitigate acc…
95c022e 
…idental clean calls that would remove /dist assets
@Hotell
fixup! ci: separate build and bundle for v8 release in order to mitig…
8fae022 
…ate accidental clean calls that would remove /dist assets
@github-actions github-actions bot added this to the August Project Cycle Q3 2024 milestone Aug 1, 2024
@Hotell Hotell changed the title Ci/fix v8 release pipeline ci: separate build and bundle for v8 release in order to mitigate accidental clean calls that would remove /dist assets Aug 1, 2024
Hotell
Hotell commented Aug 1, 2024
View reviewed changes
@Hotell Hotell marked this pull request as ready for review August 1, 2024 17:40
@Hotell Hotell requested a review from a team as a code owner August 1, 2024 17:40
@Hotell Hotell added Fluent UI react (v8) Issues about @fluentui/react (v8) CI labels Aug 1, 2024
@Hotell Hotell changed the title ci: separate build and bundle for v8 release in order to mitigate accidental clean calls that would remove /dist assets ci: separate build and bundle for v8 release in order to mitigate accidental clean task runs that would remove /dist assets Aug 1, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 37 38 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 661 629 5000
Button mount 313 301 5000
Field mount 1181 1143 5000
FluentProvider mount 726 741 5000
FluentProviderWithTheme mount 88 90 10
FluentProviderWithTheme virtual-rerender 37 38 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 81 73 10
MakeStyles mount 865 868 50000
Persona mount 1735 1715 5000
SpinButton mount 1455 1402 5000
SwatchPicker mount 1651 1650 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 92 85 1.08:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatDuplicateMessagesPerf.default 172 150 1.15:1
ListNestedPerf.default 339 307 1.1:1
ReactionMinimalPerf.default 228 208 1.1:1
PortalMinimalPerf.default 87 80 1.09:1
TreeWith60ListItems.default 94 86 1.09:1
HeaderMinimalPerf.default 207 191 1.08:1
AvatarMinimalPerf.default 123 115 1.07:1
LayoutMinimalPerf.default 202 189 1.07:1
AccordionMinimalPerf.default 85 80 1.06:1
BoxMinimalPerf.default 203 192 1.06:1
CarouselMinimalPerf.default 260 246 1.06:1
ProviderMinimalPerf.default 237 223 1.06:1
SkeletonMinimalPerf.default 200 189 1.06:1
CardMinimalPerf.default 324 309 1.05:1
FlexMinimalPerf.default 163 155 1.05:1
PopupMinimalPerf.default 352 334 1.05:1
AnimationMinimalPerf.default 311 298 1.04:1
TextMinimalPerf.default 204 197 1.04:1
EmbedMinimalPerf.default 1884 1837 1.03:1
FormMinimalPerf.default 227 221 1.03:1
GridMinimalPerf.default 193 187 1.03:1
HeaderSlotsPerf.default 478 465 1.03:1
RadioGroupMinimalPerf.default 271 263 1.03:1
ChatMinimalPerf.default 441 434 1.02:1
ChatWithPopoverPerf.default 205 200 1.02:1
InputMinimalPerf.default 549 536 1.02:1
SegmentMinimalPerf.default 193 190 1.02:1
SliderMinimalPerf.default 751 739 1.02:1
IconMinimalPerf.default 391 383 1.02:1
CheckboxMinimalPerf.default 1142 1136 1.01:1
DatepickerMinimalPerf.default 3570 3518 1.01:1
DropdownManyItemsPerf.default 396 393 1.01:1
ItemLayoutMinimalPerf.default 717 707 1.01:1
MenuButtonMinimalPerf.default 955 945 1.01:1
RosterPerf.default 1615 1595 1.01:1
TableMinimalPerf.default 241 238 1.01:1
AttachmentSlotsPerf.default 632 634 1:1
ButtonOverridesMissPerf.default 651 652 1:1
MenuMinimalPerf.default 506 508 1:1
TextAreaMinimalPerf.default 287 288 1:1
CustomToolbarPrototype.default 1508 1513 1:1
DialogMinimalPerf.default 430 436 0.99:1
DividerMinimalPerf.default 202 205 0.99:1
DropdownMinimalPerf.default 1379 1388 0.99:1
LoaderMinimalPerf.default 186 187 0.99:1
SplitButtonMinimalPerf.default 2231 2264 0.99:1
TableManyItemsPerf.default 1084 1091 0.99:1
TreeMinimalPerf.default 473 478 0.99:1
LabelMinimalPerf.default 224 228 0.98:1
ListMinimalPerf.default 300 306 0.98:1
ProviderMergeThemesPerf.default 633 643 0.98:1
ToolbarMinimalPerf.default 541 551 0.98:1
VideoMinimalPerf.default 425 435 0.98:1
ButtonSlotsPerf.default 314 324 0.97:1
ListWith60ListItems.default 353 363 0.97:1
StatusMinimalPerf.default 384 397 0.97:1
RefMinimalPerf.default 109 114 0.96:1
TooltipMinimalPerf.default 1228 1274 0.96:1
AttachmentMinimalPerf.default 79 84 0.94:1
ListCommonPerf.default 371 395 0.94:1
ImageMinimalPerf.default 218 235 0.93:1
AlertMinimalPerf.default 150 167 0.9:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 1, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 632 614 5000
Breadcrumb mount 1732 1706 1000
Checkbox mount 1722 1724 5000
CheckboxBase mount 1498 1503 5000
ChoiceGroup mount 2997 3019 5000
ComboBox mount 690 672 1000
CommandBar mount 6613 6618 1000
ContextualMenu mount 12526 12544 1000
DefaultButton mount 763 780 5000
DetailsRow mount 2241 2272 5000
DetailsRowFast mount 2290 2236 5000
DetailsRowNoStyles mount 2035 2067 5000
Dialog mount 2688 2732 1000
DocumentCardTitle mount 228 223 1000
Dropdown mount 2038 2047 5000
FocusTrapZone mount 1147 1180 5000
FocusZone mount 1119 1117 5000
GroupedList mount 42454 42557 2
GroupedList virtual-rerender 20462 20433 2
GroupedList virtual-rerender-with-unmount 52059 52044 2
GroupedListV2 mount 227 228 2
GroupedListV2 virtual-rerender 222 214 2
GroupedListV2 virtual-rerender-with-unmount 234 237 2
IconButton mount 1119 1161 5000
Label mount 345 347 5000
Layer mount 2801 2771 5000
Link mount 399 401 5000
MenuButton mount 985 1026 5000
MessageBar mount 21502 21490 5000
Nav mount 2062 2066 1000
OverflowSet mount 804 789 5000
Panel mount 1816 1786 1000
Persona mount 764 775 1000
Pivot mount 941 915 1000
PrimaryButton mount 950 934 5000
Rating mount 4733 4738 5000
SearchBox mount 921 941 5000
Shimmer mount 1925 1948 5000
Slider mount 1379 1378 5000
SpinButton mount 3000 3028 5000
Spinner mount 395 407 5000
SplitButton mount 1875 1965 5000
Stack mount 419 438 5000
StackWithIntrinsicChildren mount 874 881 5000
StackWithTextChildren mount 2773 2791 5000
SwatchColorPicker mount 6496 6497 5000
TagPicker mount 1438 1491 5000
Text mount 395 389 5000
TextField mount 946 990 5000
ThemeProvider mount 860 862 5000
ThemeProvider virtual-rerender 584 589 5000
ThemeProvider virtual-rerender-with-unmount 1274 1305 5000
Toggle mount 606 634 5000
buttonNative mount 203 193 5000

fabricteam
fabricteam reviewed Aug 1, 2024
View reviewed changes
@spmonahan spmonahan enabled auto-merge (squash) August 1, 2024 18:32
@spmonahan spmonahan merged commit 85f12c4 into microsoft:master Aug 1, 2024
@Hotell Hotell deleted the ci/fix-v8-release-pipeline branch August 2, 2024 09:23
@Hotell Hotell mentioned this pull request Aug 2, 2024
Merged
@Hotell Hotell mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@spmonahan spmonahan spmonahan approved these changes

Assignees

No one assigned

Labels

Area: Build System CI Fluent UI react (v8) Issues about @fluentui/react (v8)

Projects

None yet

Milestone

August Project Cycle Q3 2024

Development

Successfully merging this pull request may close these issues.

[Bug]: fluentui-react.* files removed from "dist" folder

4 participants

@Hotell @fabricteam @TristanWatanabe @spmonahan