Skip to content

feat(scripts-package-manager): dont run git hooks on CI, notify user to run install if needed#32169

Merged
Hotell merged 4 commits intomicrosoft:masterfrom
Hotell:nx/improve-hooks
Aug 8, 2024
Merged

feat(scripts-package-manager): dont run git hooks on CI, notify user to run install if needed#32169
Hotell merged 4 commits intomicrosoft:masterfrom
Hotell:nx/improve-hooks

Conversation

@Hotell
Copy link
Collaborator

@Hotell Hotell commented Jul 31, 2024 •
edited
Loading

Previous Behavior

New Behavior

  • git hook checks are not executed on CI
  • postinstall will point user to up to date docs page
  • new git hook that will notify user to run yarn install if there has been changes in yarn.lock file

Related Issue(s)

@github-actions github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 31, 2024
@Hotell Hotell changed the title Nx/improve hooks feat(scripts-package-manager): dont run git hooks on CI, notify user to run install if needed Jul 31, 2024
Hotell
Hotell commented Jul 31, 2024
View reviewed changes
Hotell
Hotell commented Jul 31, 2024
View reviewed changes
Hotell
Hotell commented Jul 31, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 31, 2024

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 31, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 678 624 5000
Button mount 306 296 5000
Field mount 1153 1140 5000
FluentProvider mount 718 713 5000
FluentProviderWithTheme mount 88 91 10
FluentProviderWithTheme virtual-rerender 37 40 10
FluentProviderWithTheme virtual-rerender-with-unmount 79 85 10
MakeStyles mount 872 848 50000
Persona mount 1806 1753 5000
SpinButton mount 1377 1477 5000
SwatchPicker mount 1653 1670 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 31, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 31, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 31, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 31, 2024

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LoaderMinimalPerf.default 196 176 1.11:1
BoxMinimalPerf.default 211 191 1.1:1
TextMinimalPerf.default 202 184 1.1:1
AttachmentMinimalPerf.default 88 81 1.09:1
ButtonSlotsPerf.default 324 301 1.08:1
LayoutMinimalPerf.default 212 197 1.08:1
FormMinimalPerf.default 233 218 1.07:1
ProviderMinimalPerf.default 209 195 1.07:1
HeaderMinimalPerf.default 217 204 1.06:1
AvatarMinimalPerf.default 113 108 1.05:1
ChatWithPopoverPerf.default 211 201 1.05:1
ImageMinimalPerf.default 228 217 1.05:1
RefMinimalPerf.default 113 108 1.05:1
SliderMinimalPerf.default 797 758 1.05:1
IconMinimalPerf.default 409 389 1.05:1
TextAreaMinimalPerf.default 290 277 1.05:1
ChatDuplicateMessagesPerf.default 154 148 1.04:1
FlexMinimalPerf.default 166 159 1.04:1
LabelMinimalPerf.default 229 221 1.04:1
ListWith60ListItems.default 378 363 1.04:1
SegmentMinimalPerf.default 194 187 1.04:1
TableMinimalPerf.default 248 239 1.04:1
TooltipMinimalPerf.default 1292 1243 1.04:1
HeaderSlotsPerf.default 472 463 1.02:1
ListCommonPerf.default 407 399 1.02:1
ReactionMinimalPerf.default 224 220 1.02:1
StatusMinimalPerf.default 395 388 1.02:1
AttachmentSlotsPerf.default 658 649 1.01:1
ButtonMinimalPerf.default 89 88 1.01:1
MenuButtonMinimalPerf.default 942 936 1.01:1
PortalMinimalPerf.default 83 82 1.01:1
ProviderMergeThemesPerf.default 659 653 1.01:1
RadioGroupMinimalPerf.default 273 271 1.01:1
ToolbarMinimalPerf.default 550 544 1.01:1
TreeMinimalPerf.default 493 486 1.01:1
CardMinimalPerf.default 311 311 1:1
CheckboxMinimalPerf.default 1121 1121 1:1
DialogMinimalPerf.default 441 443 1:1
DividerMinimalPerf.default 209 210 1:1
DropdownMinimalPerf.default 1418 1421 1:1
ListNestedPerf.default 319 319 1:1
RosterPerf.default 1553 1550 1:1
CustomToolbarPrototype.default 1449 1453 1:1
ButtonOverridesMissPerf.default 662 666 0.99:1
ChatMinimalPerf.default 453 457 0.99:1
EmbedMinimalPerf.default 1877 1889 0.99:1
GridMinimalPerf.default 191 192 0.99:1
MenuMinimalPerf.default 503 509 0.99:1
TreeWith60ListItems.default 91 92 0.99:1
AlertMinimalPerf.default 158 162 0.98:1
DropdownManyItemsPerf.default 387 393 0.98:1
ListMinimalPerf.default 307 312 0.98:1
SplitButtonMinimalPerf.default 2240 2277 0.98:1
TableManyItemsPerf.default 1099 1125 0.98:1
AccordionMinimalPerf.default 87 90 0.97:1
CarouselMinimalPerf.default 260 268 0.97:1
DatepickerMinimalPerf.default 3735 3863 0.97:1
VideoMinimalPerf.default 428 441 0.97:1
PopupMinimalPerf.default 348 362 0.96:1
SkeletonMinimalPerf.default 196 205 0.96:1
InputMinimalPerf.default 530 556 0.95:1
ItemLayoutMinimalPerf.default 683 720 0.95:1
AnimationMinimalPerf.default 293 311 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 31, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 634 614 5000
Breadcrumb mount 1690 1684 1000
Checkbox mount 1739 1711 5000
CheckboxBase mount 1476 1505 5000
ChoiceGroup mount 2960 2958 5000
ComboBox mount 686 661 1000
CommandBar mount 6554 6565 1000
ContextualMenu mount 12006 11907 1000
DefaultButton mount 797 805 5000
DetailsRow mount 2194 2246 5000
DetailsRowFast mount 2278 2207 5000
DetailsRowNoStyles mount 2038 2029 5000
Dialog mount 2683 2896 1000
DocumentCardTitle mount 229 237 1000
Dropdown mount 2005 2000 5000
FocusTrapZone mount 1152 1167 5000
FocusZone mount 1119 1084 5000
GroupedList mount 42964 42897 2
GroupedList virtual-rerender 20741 20434 2
GroupedList virtual-rerender-with-unmount 52111 52236 2
GroupedListV2 mount 224 227 2
GroupedListV2 virtual-rerender 217 219 2
GroupedListV2 virtual-rerender-with-unmount 228 233 2
IconButton mount 1113 1131 5000
Label mount 357 346 5000
Layer mount 2724 2801 5000
Link mount 396 404 5000
MenuButton mount 990 967 5000
MessageBar mount 21512 21489 5000
Nav mount 2031 2037 1000
OverflowSet mount 794 793 5000
Panel mount 1847 1827 1000
Persona mount 761 779 1000
Pivot mount 876 906 1000
PrimaryButton mount 926 927 5000
Rating mount 4804 4710 5000
SearchBox mount 944 934 5000
Shimmer mount 1850 1937 5000
Slider mount 1360 1372 5000
SpinButton mount 2954 2971 5000
Spinner mount 396 390 5000
SplitButton mount 1831 1904 5000
Stack mount 413 438 5000
StackWithIntrinsicChildren mount 897 875 5000
StackWithTextChildren mount 2794 2790 5000
SwatchColorPicker mount 6427 6407 5000
TagPicker mount 1485 1467 5000
Text mount 389 388 5000
TextField mount 940 932 5000
ThemeProvider mount 874 864 5000
ThemeProvider virtual-rerender 581 587 5000
ThemeProvider virtual-rerender-with-unmount 1305 1309 5000
Toggle mount 638 630 5000
buttonNative mount 188 200 5000

fabricteam
fabricteam reviewed Jul 31, 2024
View reviewed changes
@Hotell Hotell mentioned this pull request Jul 31, 2024
Closed
39 tasks
@Hotell Hotell marked this pull request as ready for review August 1, 2024 08:48
@Hotell Hotell requested a review from a team as a code owner August 1, 2024 08:48
@Hotell Hotell force-pushed the nx/improve-hooks branch from 9fdbce9 to 76ac237 Compare August 7, 2024 16:57
@Hotell Hotell merged commit aa87fbb into microsoft:master Aug 8, 2024
@Hotell Hotell deleted the nx/improve-hooks branch August 8, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees

No one assigned

Labels

Area: Build System CI

Projects

None yet

Milestone

August Project Cycle Q3 2024

Development

Successfully merging this pull request may close these issues.

3 participants

@Hotell @fabricteam @tudorpopams