Skip to content

chore(vr-tests): Convert stories to CSF#31941

Merged
dmytrokirpa merged 28 commits intomicrosoft:masterfrom
dmytrokirpa:vr-tests-to-csf
Jul 17, 2024
Merged

chore(vr-tests): Convert stories to CSF#31941
dmytrokirpa merged 28 commits intomicrosoft:masterfrom
dmytrokirpa:vr-tests-to-csf

Conversation

@dmytrokirpa
Copy link
Contributor

Previous Behavior

Visual regression tests stories for V8 utilized the storiesOf format, now deprecated in Storybook version 7 and beyond.

New Behavior

Visual regression tests stories for V8 have adopted the CSF syntax, ensuring compatibility with Storybook version 7 and later.

Related Issue(s)

@dmytrokirpa dmytrokirpa self-assigned this Jul 8, 2024
@dmytrokirpa dmytrokirpa requested a review from Hotell July 8, 2024 15:29
@dmytrokirpa dmytrokirpa marked this pull request as ready for review July 8, 2024 15:29
@dmytrokirpa dmytrokirpa requested a review from a team as a code owner July 8, 2024 15:29
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 8, 2024

📊 Bundle size report

✅ No changes found

@dmytrokirpa dmytrokirpa mentioned this pull request Jul 8, 2024
12 tasks
@@ -1,50 +1,8 @@
// @ts-check
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of these diffs are actually valid, wondering if that's expected or something additional is missing as part of this refactoring ?

example of Pie Chart:

image

@Hotell Hotell added Fluent UI react (v8) Issues about @fluentui/react (v8) Storybook labels Jul 9, 2024
Copy link
Collaborator

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmytrokirpa dmytrokirpa merged commit cbbca16 into microsoft:master Jul 17, 2024
@dmytrokirpa dmytrokirpa deleted the vr-tests-to-csf branch July 17, 2024 12:51
@dmytrokirpa dmytrokirpa mentioned this pull request Jul 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fluent UI react (v8) Issues about @fluentui/react (v8) Storybook

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants