Skip to content

chore: migrate to nx 19.1.2#31827

Merged
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:nx/migrate/19_1
Jun 28, 2024
Merged

chore: migrate to nx 19.1.2#31827
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:nx/migrate/19_1

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 26, 2024 •
edited
Loading

Previous Behavior

New Behavior

  • see PR title
  • fixes exposed bug within getDependencies() api

Related Issue(s)

@Hotell Hotell changed the title Nx/migrate/19 1 chore: migrate to nx 19.1.2 Jun 26, 2024
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 26, 2024
fabricteam
fabricteam reviewed Jun 26, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 633 634 5000
Button mount 302 293 5000
Field mount 1123 1125 5000
FluentProvider mount 707 715 5000
FluentProviderWithTheme mount 83 77 10
FluentProviderWithTheme virtual-rerender 34 29 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 75 10
MakeStyles mount 883 898 50000
Persona mount 1735 1740 5000
SpinButton mount 1368 1416 5000
SwatchPicker mount 1640 1644 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
TreeWith60ListItems.default 93 92 1.01:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 120 107 1.12:1
ButtonMinimalPerf.default 101 91 1.11:1
TextAreaMinimalPerf.default 307 276 1.11:1
BoxMinimalPerf.default 214 196 1.09:1
ProviderMinimalPerf.default 211 196 1.08:1
FlexMinimalPerf.default 170 159 1.07:1
ItemLayoutMinimalPerf.default 739 693 1.07:1
LoaderMinimalPerf.default 205 192 1.07:1
AnimationMinimalPerf.default 309 295 1.05:1
ChatDuplicateMessagesPerf.default 163 155 1.05:1
ChatMinimalPerf.default 448 427 1.05:1
RadioGroupMinimalPerf.default 272 258 1.05:1
SliderMinimalPerf.default 762 729 1.05:1
StatusMinimalPerf.default 405 384 1.05:1
ChatWithPopoverPerf.default 203 196 1.04:1
LayoutMinimalPerf.default 206 198 1.04:1
SkeletonMinimalPerf.default 204 197 1.04:1
DropdownManyItemsPerf.default 393 381 1.03:1
LabelMinimalPerf.default 220 213 1.03:1
IconMinimalPerf.default 376 366 1.03:1
ButtonSlotsPerf.default 322 316 1.02:1
DialogMinimalPerf.default 443 435 1.02:1
DropdownMinimalPerf.default 1458 1427 1.02:1
ListNestedPerf.default 328 323 1.02:1
ReactionMinimalPerf.default 207 202 1.02:1
AccordionMinimalPerf.default 85 84 1.01:1
AttachmentSlotsPerf.default 641 635 1.01:1
DividerMinimalPerf.default 196 194 1.01:1
GridMinimalPerf.default 194 192 1.01:1
ListMinimalPerf.default 316 314 1.01:1
CustomToolbarPrototype.default 1487 1474 1.01:1
ToolbarMinimalPerf.default 547 544 1.01:1
CarouselMinimalPerf.default 260 259 1:1
FormMinimalPerf.default 224 225 1:1
ImageMinimalPerf.default 231 230 1:1
InputMinimalPerf.default 549 547 1:1
MenuButtonMinimalPerf.default 970 972 1:1
PortalMinimalPerf.default 88 88 1:1
TableManyItemsPerf.default 1119 1119 1:1
TableMinimalPerf.default 237 238 1:1
TreeMinimalPerf.default 475 473 1:1
CardMinimalPerf.default 313 316 0.99:1
EmbedMinimalPerf.default 1880 1899 0.99:1
ListCommonPerf.default 397 399 0.99:1
RosterPerf.default 1575 1586 0.99:1
PopupMinimalPerf.default 349 351 0.99:1
TooltipMinimalPerf.default 1263 1274 0.99:1
AttachmentMinimalPerf.default 80 82 0.98:1
ButtonOverridesMissPerf.default 649 663 0.98:1
CheckboxMinimalPerf.default 1117 1143 0.98:1
DatepickerMinimalPerf.default 3550 3607 0.98:1
HeaderMinimalPerf.default 205 210 0.98:1
ListWith60ListItems.default 357 366 0.98:1
MenuMinimalPerf.default 495 504 0.98:1
SegmentMinimalPerf.default 189 193 0.98:1
SplitButtonMinimalPerf.default 2232 2289 0.98:1
VideoMinimalPerf.default 431 438 0.98:1
AvatarMinimalPerf.default 110 113 0.97:1
HeaderSlotsPerf.default 454 468 0.97:1
ProviderMergeThemesPerf.default 632 649 0.97:1
TextMinimalPerf.default 193 200 0.97:1
AlertMinimalPerf.default 147 160 0.92:1

fabricteam
fabricteam reviewed Jun 26, 2024
View reviewed changes
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 26, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 636 625 5000
Breadcrumb mount 1655 1686 1000
Checkbox mount 1725 1740 5000
CheckboxBase mount 1501 1493 5000
ChoiceGroup mount 2984 2974 5000
ComboBox mount 687 671 1000
CommandBar mount 6761 6536 1000
ContextualMenu mount 14144 12603 1000
DefaultButton mount 798 820 5000
DetailsRow mount 2170 2240 5000
DetailsRowFast mount 2198 2184 5000
DetailsRowNoStyles mount 2032 2043 5000
Dialog mount 2722 2804 1000
DocumentCardTitle mount 231 233 1000
Dropdown mount 2031 1987 5000
FocusTrapZone mount 1145 1173 5000
FocusZone mount 1066 1103 5000
GroupedList mount 42560 43086 2
GroupedList virtual-rerender 18333 20419 2
GroupedList virtual-rerender-with-unmount 51367 52454 2
GroupedListV2 mount 232 223 2
GroupedListV2 virtual-rerender 213 212 2
GroupedListV2 virtual-rerender-with-unmount 238 233 2
IconButton mount 1124 1121 5000
Label mount 335 357 5000
Layer mount 2725 2780 5000
Link mount 397 394 5000
MenuButton mount 999 982 5000
MessageBar mount 21398 21411 5000
Nav mount 2037 2034 1000
OverflowSet mount 798 784 5000
Panel mount 2099 1819 1000
Persona mount 744 742 1000
Pivot mount 907 881 1000
PrimaryButton mount 933 920 5000
Rating mount 4751 4665 5000
SearchBox mount 932 920 5000
Shimmer mount 1904 1933 5000
Slider mount 1359 1341 5000
SpinButton mount 2968 3001 5000
Spinner mount 404 386 5000
SplitButton mount 1878 1913 5000
Stack mount 427 428 5000
StackWithIntrinsicChildren mount 892 882 5000
StackWithTextChildren mount 2774 2828 5000
SwatchColorPicker mount 6442 6401 5000
TagPicker mount 1559 1520 5000
Text mount 399 394 5000
TextField mount 956 953 5000
ThemeProvider mount 862 860 5000
ThemeProvider virtual-rerender 596 576 5000
ThemeProvider virtual-rerender-with-unmount 1298 1313 5000
Toggle mount 629 621 5000
buttonNative mount 183 191 5000

fabricteam
fabricteam reviewed Jun 26, 2024
View reviewed changes
@Hotell Hotell mentioned this pull request Jun 26, 2024
Merged
@Hotell Hotell force-pushed the nx/migrate/19_1 branch from 1876305 to f9d0ebf Compare June 26, 2024 12:37
Hotell
Hotell commented Jun 26, 2024
View reviewed changes
@Hotell Hotell marked this pull request as ready for review June 26, 2024 13:31
@Hotell Hotell requested a review from a team as a code owner June 26, 2024 13:31
@tudorpopams tudorpopams requested a review from mainframev June 27, 2024 12:08
@Hotell Hotell merged commit 4c22606 into microsoft:master Jun 28, 2024
@Hotell Hotell deleted the nx/migrate/19_1 branch June 28, 2024 10:26
@robertpenner
Copy link
Collaborator

robertpenner commented Jun 28, 2024 •
edited
Loading

@Hotell This nx migration breaks my local v9 builds, e.g. yarn start:

@robertpenner ➜ /workspaces/fluentui (4c22606e22) $ yarn start
yarn run v1.23.34
$ node ./scripts/executors/src/start.js
node:internal/modules/cjs/loader:1148
  throw err;
  ^

Error: Cannot find module './nx-json'
Require stack:
- /workspaces/fluentui/node_modules/nx/src/config/configuration.js
- /workspaces/fluentui/node_modules/nx/src/devkit-exports.js
- /workspaces/fluentui/node_modules/@nx/devkit/index.js
- /workspaces/fluentui/scripts/monorepo/src/getAllPackageInfo.js
- /workspaces/fluentui/scripts/monorepo/src/findRepoDeps.js
- /workspaces/fluentui/scripts/monorepo/src/index.js
- /workspaces/fluentui/scripts/executors/src/start.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
    at Module._load (node:internal/modules/cjs/loader:986:27)
    at Module.require (node:internal/modules/cjs/loader:1233:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/workspaces/fluentui/node_modules/nx/src/config/configuration.js:4:19)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1208:32)
    at Module._load (node:internal/modules/cjs/loader:1024:12)
    at Module.require (node:internal/modules/cjs/loader:1233:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/workspaces/fluentui/node_modules/nx/src/config/configuration.js',
    '/workspaces/fluentui/node_modules/nx/src/devkit-exports.js',
    '/workspaces/fluentui/node_modules/@nx/devkit/index.js',
    '/workspaces/fluentui/scripts/monorepo/src/getAllPackageInfo.js',
    '/workspaces/fluentui/scripts/monorepo/src/findRepoDeps.js',
    '/workspaces/fluentui/scripts/monorepo/src/index.js',
    '/workspaces/fluentui/scripts/executors/src/start.js'
  ]
}

I ran yarn but is there something else I should do to make nx work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@mainframev mainframev mainframev approved these changes

Assignees

No one assigned

Labels

NX: core

Projects

None yet

Milestone

April Project Cycle Q1 2024

Development

Successfully merging this pull request may close these issues.

5 participants

@Hotell @fabricteam @robertpenner @TristanWatanabe @mainframev