Accessibility tests added to AreaChart, LineChart, VerticalBarChart#30059
Merged
AtishayMsft merged 8 commits intomicrosoft:masterfrom Dec 18, 2023
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Collaborator
📊 Bundle size report🤖 This report was generated against a0015d1d41f456bf3ff8a8702a79e54791c5b028 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d00215d:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a0015d1d41f456bf3ff8a8702a79e54791c5b028 (build) |
AtishayMsft
reviewed
Dec 14, 2023
Shubhabrata08
commented
Dec 14, 2023
packages/react-charting/src/components/LineChart/LineChart.base.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 30059 in repo microsoft/fluentui |
AtishayMsft
reviewed
Dec 18, 2023
change/@fluentui-react-charting-209f77d4-492f-4ffe-948f-1bd8220ff566.json
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
AtishayMsft
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
No accessibility tests were added for AreaChart, LineChart, VerticalBarChart under react-charting
New Behavior
Accessibilty test has been added with the help of jest-axe.
Related Issue(s)