Skip to content

fix(react-infolabel-preview): InfoButton's ref should be of type HTMLButtonElement#29558

Merged
sopranopillow merged 1 commit intomicrosoft:masterfrom
sopranopillow:infolabel/fix-breaking-change
Oct 17, 2023
Merged

fix(react-infolabel-preview): InfoButton's ref should be of type HTMLButtonElement#29558
sopranopillow merged 1 commit intomicrosoft:masterfrom
sopranopillow:infolabel/fix-breaking-change

Conversation

@sopranopillow
Copy link
Contributor

Previous Behavior

InfoButton's ref was casted to HTMLButtonElement due to making the ref change would involve a breaking change.

New Behavior

InfoButton's ref is now of type HTMLButtonElement.

Related Issue(s)

@sopranopillow sopranopillow requested a review from a team as a code owner October 17, 2023 19:31
@sopranopillow sopranopillow self-assigned this Oct 17, 2023
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against df59bd9f67d500ae1b41cfd7e80909b461d8066e

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd9f70f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 17, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: df59bd9f67d500ae1b41cfd7e80909b461d8066e (build)

@sopranopillow sopranopillow merged commit bd786a6 into microsoft:master Oct 17, 2023
@sopranopillow sopranopillow deleted the infolabel/fix-breaking-change branch October 17, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix useInfoButton breaking change issue with ref

3 participants