fix(react-infolabel-preview): InfoButton's ref should be of type HTMLButtonElement#29558
Merged
sopranopillow merged 1 commit intomicrosoft:masterfrom Oct 17, 2023
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against df59bd9f67d500ae1b41cfd7e80909b461d8066e |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cd9f70f:
|
smhigley
approved these changes
Oct 17, 2023
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: df59bd9f67d500ae1b41cfd7e80909b461d8066e (build) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
InfoButton's ref was casted to HTMLButtonElement due to making the ref change would involve a breaking change.
New Behavior
InfoButton's ref is now of type HTMLButtonElement.
Related Issue(s)