feat(react-infolabel-preview): Copy over files from react-infobutton to react-infolabel-preview#29545
Merged
sopranopillow merged 4 commits intomicrosoft:masterfrom Oct 17, 2023
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against 4dc9e5be60b6ce6f3f6c72c6da39bf19a504f524 |
sopranopillow
commented
Oct 16, 2023
Contributor
Author
sopranopillow
left a comment
There was a problem hiding this comment.
These are the only changes added to this PR from the files copied over. Most of them are to correct errors and the other to use correct imports.
packages/react-components/react-infolabel-preview/src/components/InfoButton/InfoButton.test.tsx
Show resolved
Hide resolved
packages/react-components/react-infolabel-preview/src/components/InfoLabel/InfoLabel.cy.tsx
Show resolved
Hide resolved
...ages/react-components/react-infolabel-preview/stories/InfoLabel/InfoLabelDefault.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-infolabel-preview/stories/InfoLabel/InfoLabelDescription.md
Show resolved
Hide resolved
...ages/react-components/react-infolabel-preview/stories/InfoLabel/InfoLabelInField.stories.tsx
Show resolved
Hide resolved
...ges/react-components/react-infolabel-preview/stories/InfoLabel/InfoLabelRequired.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-infolabel-preview/stories/InfoLabel/InfoLabelSize.stories.tsx
Show resolved
Hide resolved
packages/react-components/react-infolabel-preview/stories/InfoLabel/index.stories.tsx
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f78ce5:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4dc9e5be60b6ce6f3f6c72c6da39bf19a504f524 (build) |
smhigley
approved these changes
Oct 17, 2023
...ages/react-components/react-infolabel-preview/stories/InfoLabel/InfoLabelDefault.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-infolabel-preview/stories/InfoLabel/InfoLabelBestPractices.md
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Copy over files from react-infobutton to react-infolabel. Nothing was changed except what's been pointer below.
Related Issue(s)