docs: made Breadcrumb stories simpler and more clear#29302
Merged
ValentinaKozlova merged 18 commits intomicrosoft:masterfrom Oct 5, 2023
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit da004d3:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 7d84045d929d54c01f2fca7439356817212c2905 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 7d84045d929d54c01f2fca7439356817212c2905 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
behowell
reviewed
Sep 26, 2023
...s/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbDefault.stories.tsx
Show resolved
Hide resolved
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbSize.stories.tsx
Show resolved
Hide resolved
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbSize.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-breadcrumb-preview/stories/Breadcrumb/index.stories.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-breadcrumb-preview/stories/Breadcrumb/index.stories.tsx
Outdated
Show resolved
Hide resolved
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbBestPractices.md
Outdated
Show resolved
Hide resolved
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbBestPractices.md
Outdated
Show resolved
Hide resolved
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbBestPractices.md
Outdated
Show resolved
Hide resolved
...act-breadcrumb-preview/stories/BreadcrumbButton/BreadcrumbButtonAppearanceSubtle.stories.tsx
Outdated
Show resolved
Hide resolved
...react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbFocusMode.stories.tsx
Show resolved
Hide resolved
…adcrumb/index.stories.tsx Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
…adcrumb/BreadcrumbBestPractices.md Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
…adcrumb/BreadcrumbBestPractices.md Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
ling1726
reviewed
Sep 29, 2023
...act-breadcrumb-preview/stories/BreadcrumbButton/BreadcrumbButtonAppearanceSubtle.stories.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Sep 29, 2023
...onents/react-breadcrumb-preview/stories/BreadcrumbDivider/BreadcrumbSlashDivider.stories.tsx
Show resolved
Hide resolved
ling1726
reviewed
Sep 29, 2023
...s/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbDefault.stories.tsx
Outdated
Show resolved
Hide resolved
behowell
reviewed
Sep 29, 2023
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbBestPractices.md
Outdated
Show resolved
Hide resolved
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbSize.stories.tsx
Show resolved
Hide resolved
.../react-components/react-breadcrumb-preview/stories/BreadcrumbItem/BreadcrumbItem.stories.tsx
Outdated
Show resolved
Hide resolved
...ct-breadcrumb-preview/stories/BreadcrumbButton/BreadcrumbButtonWithHrefAttribute.stories.tsx
Outdated
Show resolved
Hide resolved
...ct-breadcrumb-preview/stories/BreadcrumbButton/BreadcrumbButtonWithHrefAttribute.stories.tsx
Outdated
Show resolved
Hide resolved
behowell
reviewed
Sep 29, 2023
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbSize.stories.tsx
Outdated
Show resolved
Hide resolved
behowell
reviewed
Sep 29, 2023
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbSize.stories.tsx
Outdated
Show resolved
Hide resolved
behowell
reviewed
Sep 29, 2023
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbSize.stories.tsx
Outdated
Show resolved
Hide resolved
…adcrumbButton/BreadcrumbButtonWithHrefAttribute.stories.tsx Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
…adcrumb/BreadcrumbSize.stories.tsx Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
…adcrumb/BreadcrumbSize.stories.tsx Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
…adcrumbButton/BreadcrumbButtonWithHrefAttribute.stories.tsx Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
…adcrumb/BreadcrumbBestPractices.md Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
behowell
approved these changes
Oct 4, 2023
...ct-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbWithOverflow.stories.tsx
Outdated
Show resolved
Hide resolved
...ages/react-components/react-breadcrumb-preview/stories/Breadcrumb/BreadcrumbBestPractices.md
Outdated
Show resolved
Hide resolved
…adcrumb/BreadcrumbWithOverflow.stories.tsx Co-authored-by: Ben Howell <48106640+behowell@users.noreply.github.com>
…t of the component
marcosmoura
approved these changes
Oct 5, 2023
This was referenced Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Fixes #29239