mergeStyles: initial shadow DOM support#28894
Closed
spmonahan wants to merge 15 commits intomicrosoft:shadow-domfrom
Closed
mergeStyles: initial shadow DOM support#28894spmonahan wants to merge 15 commits intomicrosoft:shadow-domfrom
spmonahan wants to merge 15 commits intomicrosoft:shadow-domfrom
Conversation
spmonahan
commented
Aug 17, 2023
| labelPosition, | ||
| className, | ||
| }, | ||
| shadowDom, |
Contributor
Author
There was a problem hiding this comment.
Unfortunately it looks like we'll have to plumb this value through all components. Would love ideas to avoid this!
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 371cd18:
|
…icrosoft#28896) * fix * chg * usecallback
…ton to show it's a button (microsoft#28893) * fix: Cursor should be pointer when hovering the button to show it's a button. * change file
Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
* chore: fix lint warnings for @fluentui/react-components * chore: fix lint warnings
Resolves all lints warnings for @fluentui/react package.
NOTE: this is stil a work in progress. - Refactors Stylesheet.ts to support shadow DOM - Adds React context and hooks for opting in to shadow DOM - Adds an API for projecting styles to child windows.
- Refactors stylesheet shadow DOM implementation a bit. - Adds a new docs page.
- Fixes various Typescript errors - Adds APIs to better encapsulate shadow DOM features
dcdec27 to
371cd18
Compare
Contributor
Author
|
Closing because of a naming conflict with another branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look at #28906 instead
NOTE: this feature is being merged into a non-master branch as it's not yet ready for stable release but we want to be able to stick with a more or less typical PR workflow.
Previous Behavior
mergeStylesdid not work with shadow DOM or constructable stylesheets.New Behavior
mergeStylesnow, optionally, support shadow DOM and constructable stylesheets.This is missing many tests but I want to get it up for feedback.
Related Issue(s)