Add mountnode datepicker compat#28747
Merged
GeoffCoxMSFT merged 9 commits intomicrosoft:masterfrom Aug 9, 2023
Merged
Conversation
Collaborator
📊 Bundle size report
🤖 This report was generated against 76f48d39e3361f68ae7e9c42b6e98395b75ec5d3 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ea8210:
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 76f48d39e3361f68ae7e9c42b6e98395b75ec5d3 (build) |
khmakoto
reviewed
Aug 7, 2023
change/@fluentui-react-datepicker-compat-d51eda0f-25b4-4190-b43a-79e3714272da.json
Outdated
Show resolved
Hide resolved
packages/react-components/react-datepicker-compat/src/components/DatePicker/DatePicker.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-datepicker-compat/src/components/DatePicker/DatePicker.types.ts
Outdated
Show resolved
Hide resolved
…ts/DatePicker/DatePicker.types.ts Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
…ts/DatePicker/DatePicker.types.ts Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
…3a-79e3714272da.json Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
khmakoto
approved these changes
Aug 7, 2023
packages/react-components/react-datepicker-compat/src/components/DatePicker/DatePicker.types.ts
Show resolved
Hide resolved
…ts/DatePicker/DatePicker.types.ts Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows callers to change the mountNode of the portal used to display the dropdown part for DatePicker compat.
Changes
Issues
Fixes #28625