fix(react-menu): revert menuitem focus ring back to border#28698
Merged
YuanboXue-Amber merged 2 commits intomicrosoft:masterfrom Aug 1, 2023
Merged
fix(react-menu): revert menuitem focus ring back to border#28698YuanboXue-Amber merged 2 commits intomicrosoft:masterfrom
YuanboXue-Amber merged 2 commits intomicrosoft:masterfrom
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 606 | 628 | 5000 | |
| Button | mount | 308 | 291 | 5000 | |
| Field | mount | 1076 | 1093 | 5000 | |
| FluentProvider | mount | 639 | 661 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 92 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 80 | 83 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 81 | 85 | 10 | |
| InfoButton | mount | 11 | 17 | 5000 | |
| MakeStyles | mount | 853 | 852 | 50000 | |
| Persona | mount | 1667 | 1666 | 5000 | |
| SpinButton | mount | 1405 | 1338 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 77bc5d3:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ac8385d586881c06a91811791190b393eefd837c (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert #28685
Why outlined focus ring is not used in this specific case:
When Menu is default open, on page load it focuses on the first item, browser will render a default
:focus-visiblering with cssoutlinestyles. If we don't want this, we need to do two things:':focus-visible': { outlineStyle: 'none' }[&data-fui-focus-visible]: styleto[&data-fui-focus-visible]:focus: style, to be more specific and win over the style we added in step 1.But this brings new issue - we have consumers overriding focus ring style by using just
:focus-visible. If we update our own focus ring selector to be more specific, it breaks their overrides.Since we don't want focus ring on default load (which will break all vr test), and we don't want to make focus ring selector more specific, we can only revert back to border focus ring.