feat: Implement toast lifecycle and onStatusChange handler#28175
Merged
ling1726 merged 13 commits intomicrosoft:masterfrom Jun 14, 2023
Merged
feat: Implement toast lifecycle and onStatusChange handler#28175ling1726 merged 13 commits intomicrosoft:masterfrom
ling1726 merged 13 commits intomicrosoft:masterfrom
Conversation
Implements the following lifecycle statuses: - added - visible - closed - removed - updated The `onStatusChange` callback can be used when creating a toast to listen to the lifecycle changes.
Collaborator
📊 Bundle size report🤖 This report was generated against 122c0d6057ad16e9e005e68214b083a77686d1df |
layershifter
reviewed
Jun 8, 2023
layershifter
reviewed
Jun 8, 2023
packages/react-components/react-toast/stories/Toast/DismissToast.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 8, 2023
packages/react-components/react-toast/stories/Toast/DismissToast.stories.tsx
Outdated
Show resolved
Hide resolved
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 122c0d6057ad16e9e005e68214b083a77686d1df (build) |
layershifter
reviewed
Jun 8, 2023
packages/react-components/react-toast/stories/Toast/ToastLifecycle.stories.tsx
Outdated
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e90f1b2:
|
layershifter
reviewed
Jun 8, 2023
packages/react-components/react-toast/stories/Toast/ToastLifecycle.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 8, 2023
packages/react-components/react-toast/stories/Toast/ToastLifecycle.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Jun 8, 2023
packages/react-components/react-toast/stories/Toast/ToastLifecycle.stories.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Jun 8, 2023
layershifter
reviewed
Jun 9, 2023
packages/react-components/react-toast/src/components/ToastContainer/ToastContainer.test.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the following lifecycle statuses:
The
onStatusChangecallback can be used when creating a toast to listen to the lifecycle changes.Fixes #27828