feat: Implement Toaster according to composition API#28039
Merged
ling1726 merged 8 commits intomicrosoft:masterfrom May 31, 2023
Merged
feat: Implement Toaster according to composition API#28039ling1726 merged 8 commits intomicrosoft:masterfrom
ling1726 merged 8 commits intomicrosoft:masterfrom
Conversation
Implements the Toaster using the composition hook pattern. The Toaster component has one single root slot but it is mapped to potentially 4 different DOM elements (one for each toast position). The toaster does not support ref forwarding for this reason.
ling1726
commented
May 30, 2023
packages/react-components/react-toast/src/components/Toaster/Toaster.test.tsx
Show resolved
Hide resolved
ling1726
commented
May 30, 2023
Collaborator
📊 Bundle size report🤖 This report was generated against d7806642ac5e98ce57d87860e6a0e5f2d5225a4a |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d7806642ac5e98ce57d87860e6a0e5f2d5225a4a (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 40d991d:
|
bsunderhus
approved these changes
May 30, 2023
bsunderhus
approved these changes
May 30, 2023
packages/react-components/react-toast/src/components/Toaster/renderToaster.tsx
Show resolved
Hide resolved
packages/react-components/react-toast/src/components/Toaster/useToaster.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-toast/src/components/Toaster/Toaster.types.ts
Show resolved
Hide resolved
packages/react-components/react-toast/src/components/Toaster/useToaster.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-toast/src/components/Toaster/useToasterStyles.styles.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-toast/src/components/Toaster/renderToaster.tsx
Show resolved
Hide resolved
packages/react-components/react-toast/src/components/Toaster/useToaster.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Toaster using the composition hook pattern. The Toaster component has one single root slot but it is mapped to potentially 4 different DOM elements (one for each toast position). The toaster does not support ref forwarding for this reason.
Fixes #27774