Skip to content

feat(public-docsite-v9): Add recipes to concepts section#27747

Closed
sopranopillow wants to merge 1 commit intomicrosoft:masterfrom
sopranopillow:recipes/publish
Closed

feat(public-docsite-v9): Add recipes to concepts section#27747
sopranopillow wants to merge 1 commit intomicrosoft:masterfrom
sopranopillow:recipes/publish

Conversation

@sopranopillow
Copy link
Contributor

This PR adds the recipes subsection to Concepts.

Related Issue(s)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 32bda75:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented May 2, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2e4a9ee0c93e252ac19771d934b5f9e233faddd7 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 2e4a9ee0c93e252ac19771d934b5f9e233faddd7

'../../../packages/react-components/react-migration-v0-v9/stories/**/@(index.stories.@(ts|tsx)|*.stories.mdx)',
'../../../packages/react-components/react-migration-v8-v9/stories/**/@(index.stories.@(ts|tsx)|*.stories.mdx)',
'../../../packages/react-components/react-datepicker-compat/stories/**/@(index.stories.@(ts|tsx)|*.stories.mdx)',
'../../recipes-react-components/src/recipes/**/*.stories.mdx',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this feels wrong from domain boundary POV. an app should never use things from another app. In future we will have in place lint rules that would not allow this.

Don't wanna block the progress here thus can you please create issue to fix this going forward ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, what would be the way to go with this? should this be a package instead to avoid this issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, AFAIR the intent of recipes was to be as standalone app correct ? but if we wanna make it part of v9 docs it is no longer true.

We still can have it as an app to be published standalone though, if there is such a need etc.

NOTE: make sure to make the library private as we don't wanna expose it to npm registry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'll talk with everyone else, but as I understand we wanted it to be pretty visible in the docs since we will use them as placeholder recipes for components that we might work on later. I'll change it to draft for now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing will change in terms of "visibility"

it will only change import.

'../../../packages/react-components/src/recipes/**/*.stories.mdx',

then the app will can still exist but with dependency on library

recipes-app --> recipes-lib

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so there's no problem having the package never released and private? I think that was a concern that made us go with the app instead of package. This package wouldn't follow semver as well since we'll allow breaking changes and such. If those things aren't problems, then I'll create a PR to move it to a package in the coming days.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I dont see any problem with that. if it's gonna be private even better. ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recipes: Add recipes to public-docsite-v9

4 participants