fix(react-virtualizer): remove disallowed v9 react-fabric/v8 from dependencies to mitigate dep-tree creep#27334
Merged
Hotell merged 4 commits intomicrosoft:masterfrom Mar 27, 2023
Conversation
…ndency to mitigate dep-tree creep
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 639f342:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4fad4cbbcbdb48847857c388135a3abda472add7 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 817 | 891 | 5000 | |
| Button | mount | 510 | 509 | 5000 | |
| Field | mount | 1479 | 1468 | 5000 | |
| FluentProvider | mount | 1102 | 1118 | 5000 | |
| FluentProviderWithTheme | mount | 303 | 299 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 244 | 249 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 294 | 274 | 10 | |
| InfoButton | mount | 192 | 190 | 5000 | |
| MakeStyles | mount | 1303 | 1294 | 50000 | |
| Persona | mount | 2276 | 1976 | 5000 | |
| SpinButton | mount | 1929 | 1821 | 5000 |
…om dependency to mitigate dep-tree creep
Hotell
commented
Mar 27, 2023
packages/react-components/react-virtualizer/stories/Virtualizer/DefaultUnbounded.stories.tsx
Show resolved
Hide resolved
Mitch-At-Work
approved these changes
Mar 27, 2023
packages/react-components/react-virtualizer/stories/Virtualizer/DefaultUnbounded.stories.tsx
Show resolved
Hide resolved
Contributor
Author
|
1 hour threshold reached for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
react-virtualizerintroduced a forbidden project dependency on react(v8), which caused pipeline creep ( on any v8 change all v9 project would be affected).Simplified Example:
@fluentui/react@fluentui/ssr-test-v9-->@fluentui/react-components-->@fluentui/react-virtualizer-->@fluentui/reactThis caused Out of memory/timeout issues for both PR pipelines and release pipelines
Example of failing PR/pipeline that triggers everything because of this: #27323
New Behavior
react v8 is no longer a v9 package direct or indirect dependency.
Notes:
lage build --to @fluentui/react.Related Issue(s)