Skip to content

fix: Adding the correct icons to away+out-of-office PresenceBadges and adding the correct icons to use in large PresenceBadges#27253

Merged
khmakoto merged 5 commits intomicrosoft:masterfrom
khmakoto:presenceIconsFix
Mar 20, 2023
Merged

fix: Adding the correct icons to away+out-of-office PresenceBadges and adding the correct icons to use in large PresenceBadges#27253
khmakoto merged 5 commits intomicrosoft:masterfrom
khmakoto:presenceIconsFix

Conversation

@khmakoto
Copy link
Member

@khmakoto khmakoto commented Mar 18, 2023

Previous Behavior

PresenceBadges that were away + out-of-office used the incorrect set of icons, only using the out-of-office icons instead of the away ones.

Large PresenceBadges also used a wrong set of 16px sized icons, instead of the 20px sized ones called by the design spec.

New Behavior

PresenceBadges that are away + out-of-office now use the correct set of away icons instead of the out-of-office ones.

Large PresenceBadges now use the correct 20px sized icons instead of the wrong 16px sized ones.

Related Issue(s)

Humberto Makoto Morimoto Burgos added 2 commits March 17, 2023 19:20
@khmakoto khmakoto requested review from a team and behowell as code owners March 18, 2023 02:27
@khmakoto khmakoto self-assigned this Mar 18, 2023
@github-actions github-actions bot added this to the March Project Cycle Q1 2023 milestone Mar 18, 2023
@size-auditor
Copy link

size-auditor bot commented Mar 18, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 62faffdfb607c7cf30f2c4f554cdc40c20808c13 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 18, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d9af858:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2023 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-alert
Alert		 90.924 kB
22.307 kB		 96.599 kB
23.124 kB		 5.675 kB
817 B
react-avatar
Avatar		 54.563 kB
14.767 kB		 60.238 kB
15.568 kB		 5.675 kB
801 B
react-avatar
AvatarGroupItem		 70.839 kB
19.263 kB		 76.514 kB
20.076 kB		 5.675 kB
813 B
react-badge
PresenceBadge		 28.685 kB
7.897 kB		 34.35 kB
8.677 kB		 5.665 kB
780 B
react-persona
Persona		 61.624 kB
16.709 kB		 67.299 kB
17.518 kB		 5.675 kB
809 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
AvatarGroup		 18.064 kB
6.664 kB
react-badge
Badge		 25.746 kB
7.568 kB
react-badge
CounterBadge		 26.725 kB
7.874 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 67.365 kB
18.199 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 206.835 kB
57.287 kB
react-components
react-components: FluentProvider & webLightTheme		 38.202 kB
12.13 kB
react-portal-compat
PortalCompatProvider		 6.466 kB
2.179 kB
react-table
DataGrid		 149.807 kB
40.556 kB
react-table
Table (Primitives only)		 47.018 kB
12.666 kB
react-table
Table as DataGrid		 137.938 kB
35.279 kB
react-table
Table (Selection only)		 85.765 kB
21.276 kB
react-table
Table (Sort only)		 85.086 kB
21.09 kB
🤖 This report was generated against 62faffdfb607c7cf30f2c4f554cdc40c20808c13

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 900 897 5000
Button mount 573 559 5000
Field mount 1601 1612 5000
FluentProvider mount 1106 1108 5000
FluentProviderWithTheme mount 289 307 10
FluentProviderWithTheme virtual-rerender 236 244 10
FluentProviderWithTheme virtual-rerender-with-unmount 287 291 10
InfoButton mount 202 218 5000
MakeStyles mount 1296 1309 50000
Persona mount 2193 2205 5000
SpinButton mount 1947 1789 5000

@khmakoto khmakoto merged commit 9bba9ca into microsoft:master Mar 20, 2023
@khmakoto khmakoto deleted the presenceIconsFix branch March 20, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabricteam fabricteam fabricteam left review comments

@sopranopillow sopranopillow sopranopillow approved these changes

@behowell behowell Awaiting requested review from behowell

+1 more reviewer

@tomi-msft tomi-msft tomi-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@khmakoto khmakoto

Labels

Area: Icons Component: PresenceBadge

Projects

None yet

Milestone

March Project Cycle Q1 2023

Development

Successfully merging this pull request may close these issues.

[Bug]: PresenceBadge having wrong glyph for Away + OOO

5 participants

@khmakoto @fabricteam @sopranopillow @tomi-msft @msft-fluent-ui-bot