Skip to content

feat(react-tree): TreeItem static style for level#26999

Merged
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:react-tree/feat--TreeItem-inline-style-override
Feb 28, 2023
Merged

feat(react-tree): TreeItem static style for level#26999
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:react-tree/feat--TreeItem-inline-style-override

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Feb 27, 2023 •
edited
Loading

New Behavior

  1. Opts in on using static style for the first 10 levels of the tree.
  2. Allows inline style override from the user side to ensure all use cases.
  3. Adds stories to properly document this behavour

@bsunderhus bsunderhus self-assigned this Feb 27, 2023
@size-auditor
Copy link

size-auditor bot commented Feb 27, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: dd0f5b76fc8905c067cc58556ec1f9626dcfc640 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 27, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against dd0f5b76fc8905c067cc58556ec1f9626dcfc640

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 27, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eba9df5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@bsunderhus bsunderhus marked this pull request as ready for review February 27, 2023 21:32
@bsunderhus bsunderhus requested a review from a team as a code owner February 27, 2023 21:32
@bsunderhus bsunderhus force-pushed the react-tree/feat--TreeItem-inline-style-override branch 2 times, most recently from bbc913b to 9392541 Compare February 28, 2023 00:16
@bsunderhus bsunderhus changed the title feat(react-tree): TreeItem inline style override feat(react-tree): TreeItem static style for level Feb 28, 2023
@bsunderhus bsunderhus force-pushed the react-tree/feat--TreeItem-inline-style-override branch from 44fbc72 to bbf622e Compare February 28, 2023 13:10
@bsunderhus bsunderhus force-pushed the react-tree/feat--TreeItem-inline-style-override branch 2 times, most recently from 9d7f1f4 to 8e8245a Compare February 28, 2023 14:57
@bsunderhus bsunderhus force-pushed the react-tree/feat--TreeItem-inline-style-override branch from 8e8245a to eba9df5 Compare February 28, 2023 16:29
@bsunderhus bsunderhus merged commit d6caf03 into microsoft:master Feb 28, 2023
@bsunderhus bsunderhus deleted the react-tree/feat--TreeItem-inline-style-override branch February 28, 2023 17:35
@bsunderhus bsunderhus mentioned this pull request Mar 13, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bsunderhus bsunderhus

Labels

Component: Tree Fluent UI react-components (v9)

Projects

None yet

Milestone

February Project Cycle Q1 2023

Development

Successfully merging this pull request may close these issues.

4 participants

@bsunderhus @fabricteam @layershifter @ling1726