Skip to content

feat(react-tree): Implements proper navigation#26978

Merged
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:react-tree/feat--implements-proper-navigation
Mar 2, 2023
Merged

feat(react-tree): Implements proper navigation#26978
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:react-tree/feat--implements-proper-navigation

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Feb 27, 2023 •
edited
Loading

New Behavior

  1. Stops using tabster internally as it doesn't support all current navigation scenarios
  2. Introduces internal navigation mechanisms with an extendable external API
  3. Implements proper Up/Down/Left/Right/Home/End and typeahead navigation

@bsunderhus bsunderhus self-assigned this Feb 27, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Feb 27, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 5177d2a76ad0c003f03a883022ff5cee62c3e7e3

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 27, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb4787c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 27, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5177d2a76ad0c003f03a883022ff5cee62c3e7e3 (build)

@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-proper-navigation branch 6 times, most recently from 47c091c to a2ef557 Compare February 27, 2023 18:17
@bsunderhus bsunderhus marked this pull request as ready for review February 27, 2023 18:19
@bsunderhus bsunderhus requested a review from a team as a code owner February 27, 2023 18:19
@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-proper-navigation branch 3 times, most recently from e05b51a to 5fe1540 Compare February 27, 2023 20:02
@bsunderhus bsunderhus enabled auto-merge (squash) February 28, 2023 00:16
@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-proper-navigation branch 2 times, most recently from bf5f2eb to a60ca81 Compare February 28, 2023 17:45
@ling1726
Copy link
Contributor

ling1726 commented Mar 1, 2023

It's possible to tab through all treeitems actions, is this a known issue?

tree tabbing

@bsunderhus
Copy link
Contributor Author

bsunderhus commented Mar 1, 2023 •
edited
Loading

It's possible to tab through all treeitems actions, is this a known issue?

Why do you think this is an issue? as far as I understood this is expected behaviour

@ling1726
Copy link
Contributor

ling1726 commented Mar 1, 2023

It's possible to tab through all treeitems actions, is this a known issue?

Why do you think this is an issue? as far as I understood this is expected behaviour

No, the whole reason for arrow based navigation is that the entire widget is one single tabstop, similar to Menu and Toolbar like components

@bsunderhus bsunderhus requested a review from ling1726 March 1, 2023 18:20
@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-proper-navigation branch from ab9d43a to 1cb0bf6 Compare March 1, 2023 19:03
@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-proper-navigation branch from 1cb0bf6 to 1c1d09f Compare March 2, 2023 12:09
@bsunderhus bsunderhus force-pushed the react-tree/feat--implements-proper-navigation branch from 1c1d09f to cb4787c Compare March 2, 2023 12:57
@bsunderhus bsunderhus merged commit 5fff97d into microsoft:master Mar 2, 2023
@bsunderhus bsunderhus mentioned this pull request Mar 13, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bsunderhus bsunderhus

Labels

None yet

Projects

None yet

Milestone

March Project Cycle Q1 2023

Development

Successfully merging this pull request may close these issues.

3 participants

@bsunderhus @fabricteam @ling1726