Add visual regression test for TilesList#26969
Merged
spmonahan merged 2 commits intomicrosoft:masterfrom Mar 6, 2023
Merged
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against efb2274e37c0237f3a10a4630b2696a9880f6398 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3f2b4db:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: efb2274e37c0237f3a10a4630b2696a9880f6398 (build) |
fabricteam
reviewed
Feb 25, 2023
spmonahan
reviewed
Feb 27, 2023
This was referenced Feb 27, 2023
spmonahan
approved these changes
Mar 2, 2023
33b70d2 to
3f2b4db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new visual regression test for
TilesListto ensure that changes toListdon't break its render behavior, which requires an upfront measurement of the content width before rendering can occur.