feat(tools): implement migrate-scripts-to-pkg generator#26129
Closed
Hotell wants to merge 2 commits intomicrosoft:masterfrom
Closed
feat(tools): implement migrate-scripts-to-pkg generator#26129Hotell wants to merge 2 commits intomicrosoft:masterfrom
Hotell wants to merge 2 commits intomicrosoft:masterfrom
Conversation
4b35d68 to
b561ad0
Compare
Collaborator
📊 Bundle size report🤖 This report was generated against 26f0364b3837056ee8e0df42a7932c298c68290e |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 26f0364b3837056ee8e0df42a7932c298c68290e (build) |
b561ad0 to
9851d42
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f86a621:
|
9851d42 to
9280c2e
Compare
f4e0a46 to
3c73e78
Compare
3bf8f8f to
3c73e78
Compare
3c73e78 to
f86a621
Compare
Contributor
Author
|
this wont be merged, as it adds lot of code that we don't have to/need to maintain, as this was only 1 time migration. It will remain in pull request for future education purposes 🙌. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
Implements nx generator that will migrate
@fluentui/scriptsto separate packages and update devDeps in whole monorepoRelated Issue(s)
/scripts) #24349TODO:
eslint: turn off import-extranous deps-> set workspace rootimport/no-self-importfor index.d.ts