fix(scripts): v9 release should not include v8 docsite in scope#24809
Closed
ling1726 wants to merge 2 commits intomicrosoft:masterfrom
Closed
fix(scripts): v9 release should not include v8 docsite in scope#24809ling1726 wants to merge 2 commits intomicrosoft:masterfrom
ling1726 wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1309 | 1328 | 5000 | |
| Button | mount | 954 | 956 | 5000 | |
| FluentProvider | mount | 1568 | 1566 | 5000 | |
| FluentProviderWithTheme | mount | 645 | 625 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 598 | 598 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 640 | 636 | 10 | |
| MakeStyles | mount | 1914 | 1900 | 50000 | |
| SpinButton | mount | 2616 | 2523 | 5000 |
Hotell
reviewed
Sep 15, 2022
|
|
||
| const isConverged = isConvergedPackage({ packagePathOrJson: packageJson }); | ||
| if (process.env.RELEASE_VNEXT && isConverged) { | ||
| if (releaseScope === 'v9' && isConverged) { |
Contributor
There was a problem hiding this comment.
can we unify this one way or another for both if statements? (release scope check first , isConverged 2nd )
releaseScope === 'v9' && isConverged or isConverged && releaseScope === 'v9'
| '@fluentui/api-docs', | ||
| ]; | ||
|
|
||
| const releaseScope = process.env.RELEASE_VNEXT ? 'v9' : 'v8'; |
Contributor
There was a problem hiding this comment.
can we add more docs to this ? there is something for beachbalPackagesScopes but Im not sure its up to date
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e791e1c:
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 138 | 127 | 1.09:1 |
| RadioGroupMinimalPerf.default | 384 | 352 | 1.09:1 |
| TreeWith60ListItems.default | 140 | 129 | 1.09:1 |
| AttachmentMinimalPerf.default | 125 | 118 | 1.06:1 |
| ChatWithPopoverPerf.default | 316 | 301 | 1.05:1 |
| LoaderMinimalPerf.default | 557 | 529 | 1.05:1 |
| ProviderMinimalPerf.default | 353 | 336 | 1.05:1 |
| TextAreaMinimalPerf.default | 398 | 379 | 1.05:1 |
| CarouselMinimalPerf.default | 383 | 370 | 1.04:1 |
| DropdownManyItemsPerf.default | 561 | 539 | 1.04:1 |
| FlexMinimalPerf.default | 243 | 234 | 1.04:1 |
| PortalMinimalPerf.default | 145 | 140 | 1.04:1 |
| SkeletonMinimalPerf.default | 289 | 279 | 1.04:1 |
| ChatMinimalPerf.default | 619 | 603 | 1.03:1 |
| ImageMinimalPerf.default | 321 | 313 | 1.03:1 |
| ListCommonPerf.default | 516 | 500 | 1.03:1 |
| ToolbarMinimalPerf.default | 780 | 760 | 1.03:1 |
| AnimationMinimalPerf.default | 450 | 442 | 1.02:1 |
| BoxMinimalPerf.default | 284 | 279 | 1.02:1 |
| HeaderMinimalPerf.default | 293 | 288 | 1.02:1 |
| ListMinimalPerf.default | 423 | 414 | 1.02:1 |
| RefMinimalPerf.default | 180 | 176 | 1.02:1 |
| IconMinimalPerf.default | 546 | 533 | 1.02:1 |
| TableMinimalPerf.default | 331 | 324 | 1.02:1 |
| AvatarMinimalPerf.default | 160 | 159 | 1.01:1 |
| DropdownMinimalPerf.default | 2256 | 2242 | 1.01:1 |
| HeaderSlotsPerf.default | 628 | 621 | 1.01:1 |
| LayoutMinimalPerf.default | 290 | 287 | 1.01:1 |
| MenuMinimalPerf.default | 700 | 695 | 1.01:1 |
| ReactionMinimalPerf.default | 306 | 304 | 1.01:1 |
| SegmentMinimalPerf.default | 282 | 279 | 1.01:1 |
| StatusMinimalPerf.default | 558 | 552 | 1.01:1 |
| TableManyItemsPerf.default | 1560 | 1545 | 1.01:1 |
| TextMinimalPerf.default | 278 | 274 | 1.01:1 |
| TooltipMinimalPerf.default | 1943 | 1918 | 1.01:1 |
| VideoMinimalPerf.default | 603 | 595 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1092 | 1096 | 1:1 |
| CardMinimalPerf.default | 446 | 444 | 1:1 |
| CheckboxMinimalPerf.default | 1728 | 1730 | 1:1 |
| DialogMinimalPerf.default | 646 | 646 | 1:1 |
| InputMinimalPerf.default | 940 | 942 | 1:1 |
| ItemLayoutMinimalPerf.default | 966 | 962 | 1:1 |
| MenuButtonMinimalPerf.default | 1406 | 1411 | 1:1 |
| SliderMinimalPerf.default | 1327 | 1322 | 1:1 |
| SplitButtonMinimalPerf.default | 3649 | 3635 | 1:1 |
| TreeMinimalPerf.default | 675 | 673 | 1:1 |
| AlertMinimalPerf.default | 213 | 216 | 0.99:1 |
| ButtonSlotsPerf.default | 459 | 464 | 0.99:1 |
| DividerMinimalPerf.default | 288 | 291 | 0.99:1 |
| EmbedMinimalPerf.default | 3018 | 3037 | 0.99:1 |
| ListNestedPerf.default | 454 | 457 | 0.99:1 |
| RosterPerf.default | 1776 | 1794 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1052 | 1064 | 0.99:1 |
| CustomToolbarPrototype.default | 2237 | 2251 | 0.99:1 |
| AccordionMinimalPerf.default | 117 | 120 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 243 | 247 | 0.98:1 |
| DatepickerMinimalPerf.default | 4732 | 4824 | 0.98:1 |
| GridMinimalPerf.default | 270 | 275 | 0.98:1 |
| LabelMinimalPerf.default | 309 | 315 | 0.98:1 |
| PopupMinimalPerf.default | 526 | 536 | 0.98:1 |
| ListWith60ListItems.default | 516 | 530 | 0.97:1 |
| AttachmentSlotsPerf.default | 905 | 943 | 0.96:1 |
| FormMinimalPerf.default | 311 | 324 | 0.96:1 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a33448fe4a0f4117686c378f80b893d1406d95a8 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| ThemeProvider | virtual-rerender-with-unmount | 1715 | 1732 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 778 | 763 | 5000 | |
| Breadcrumb | mount | 2484 | 2415 | 1000 | |
| Checkbox | mount | 2151 | 2207 | 5000 | |
| CheckboxBase | mount | 1848 | 1960 | 5000 | |
| ChoiceGroup | mount | 3943 | 3952 | 5000 | |
| ComboBox | mount | 822 | 835 | 1000 | |
| CommandBar | mount | 9078 | 8705 | 1000 | |
| ContextualMenu | mount | 9757 | 10165 | 1000 | |
| DefaultButton | mount | 845 | 884 | 5000 | |
| DetailsRow | mount | 3159 | 3237 | 5000 | |
| DetailsRowFast | mount | 2875 | 3099 | 5000 | |
| DetailsRowNoStyles | mount | 3056 | 2884 | 5000 | |
| Dialog | mount | 2648 | 2575 | 1000 | |
| DocumentCardTitle | mount | 135 | 151 | 1000 | |
| Dropdown | mount | 2788 | 2773 | 5000 | |
| FocusTrapZone | mount | 1485 | 1655 | 5000 | |
| FocusZone | mount | 1571 | 1527 | 5000 | |
| IconButton | mount | 1486 | 1493 | 5000 | |
| Label | mount | 297 | 300 | 5000 | |
| Layer | mount | 3833 | 3820 | 5000 | |
| Link | mount | 386 | 392 | 5000 | |
| MenuButton | mount | 1240 | 1224 | 5000 | |
| MessageBar | mount | 1655 | 1896 | 5000 | |
| Nav | mount | 2646 | 2869 | 1000 | |
| OverflowSet | mount | 960 | 946 | 5000 | |
| Panel | mount | 2148 | 2139 | 1000 | |
| Persona | mount | 857 | 840 | 1000 | |
| Pivot | mount | 1227 | 1150 | 1000 | |
| PrimaryButton | mount | 999 | 1112 | 5000 | |
| Rating | mount | 6469 | 6581 | 5000 | |
| SearchBox | mount | 1025 | 1098 | 5000 | |
| Shimmer | mount | 2341 | 2397 | 5000 | |
| Slider | mount | 1653 | 1618 | 5000 | |
| SpinButton | mount | 4172 | 4204 | 5000 | |
| Spinner | mount | 327 | 366 | 5000 | |
| SplitButton | mount | 2667 | 2646 | 5000 | |
| Stack | mount | 436 | 441 | 5000 | |
| StackWithIntrinsicChildren | mount | 1924 | 1738 | 5000 | |
| StackWithTextChildren | mount | 4219 | 4372 | 5000 | |
| SwatchColorPicker | mount | 9740 | 9938 | 5000 | |
| TagPicker | mount | 2239 | 2233 | 5000 | |
| TeachingBubble | mount | 86172 | 84928 | 5000 | |
| Text | mount | 363 | 367 | 5000 | |
| TextField | mount | 1182 | 1118 | 5000 | |
| ThemeProvider | mount | 1059 | 1092 | 5000 | |
| ThemeProvider | virtual-rerender | 582 | 663 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1715 | 1732 | 5000 | Possible regression |
| Toggle | mount | 674 | 694 | 5000 | |
| buttonNative | mount | 112 | 114 | 5000 |
Hotell
approved these changes
Sep 15, 2022
Hotell
reviewed
Sep 15, 2022
| } | ||
|
|
||
| if (!isConverged) { | ||
| if (!isConverged && releaseScope === 'v8') { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!isConverged && releaseScope === 'v8') { | |
| if (releaseScope === 'v8' && !isConverged) { |
Contributor
|
can we merge this ? @ling1726 |
Contributor
|
I added this fix in this bigger PR #25095, feel free to both merge or close. ty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current scoping means that v8 docsites will always be in scope for v9 release