Skip to content

test(react-charting): update obsolete snapshots#24808

Merged
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/fix/react-charting-issues
Sep 15, 2022
Merged

test(react-charting): update obsolete snapshots#24808
Hotell merged 1 commit intomicrosoft:masterfrom
Hotell:hotell/fix/react-charting-issues

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Sep 15, 2022

Current Behavior

react-charting test is broken and blocks release of v9

image

New Behavior

  • updated snapshots so master can be used to release v9
  • Im not sure what's going on, this was introduced in following PR where pipelines passed Add tests for hover states #24390

Related Issue(s)

@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Sep 15, 2022
@Hotell Hotell marked this pull request as ready for review September 15, 2022 08:41
@Hotell Hotell requested a review from a team as a code owner September 15, 2022 08:41
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against f5398157ebbea5c748d8d7336f18b378a8bdec16

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2153d92:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 15, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f5398157ebbea5c748d8d7336f18b378a8bdec16 (build)

@Hotell Hotell merged commit a33448f into microsoft:master Sep 15, 2022
@Hotell Hotell deleted the hotell/fix/react-charting-issues branch September 15, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants