Skip to content

chore: Adding PersonaAvatar, PersonaPresenceBadge, and PersonaIcon components#24704

Closed
sopranopillow wants to merge 2 commits intomicrosoft:masterfrom
sopranopillow:persona/sub-components/scaffold
Closed

chore: Adding PersonaAvatar, PersonaPresenceBadge, and PersonaIcon components#24704
sopranopillow wants to merge 2 commits intomicrosoft:masterfrom
sopranopillow:persona/sub-components/scaffold

Conversation

@sopranopillow
Copy link
Contributor

@sopranopillow sopranopillow commented Sep 8, 2022

This PR adds PersonaAvatar, PersonaPresenceBadge, and PersonaIcon components. This PR only has the generated files by yarn create-component.

Related Issue(s)

Related #24640

@sopranopillow sopranopillow self-assigned this Sep 8, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb46db8:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 8, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: aa1b9dd77b36fe633d64430db0292af546bbe35c (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 8, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1289 1276 5000
Button mount 931 934 5000
FluentProvider mount 1483 1523 5000
FluentProviderWithTheme mount 572 575 10
FluentProviderWithTheme virtual-rerender 536 548 10
FluentProviderWithTheme virtual-rerender-with-unmount 573 585 10
MakeStyles mount 1927 1924 50000
SpinButton mount 2346 2327 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 8, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 554 B
348 B
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 78.914 kB
24.06 kB
react-alert
Alert		 83.228 kB
20.889 kB
react-avatar
Avatar		 48.381 kB
13.696 kB
react-avatar
AvatarGroup		 14.95 kB
5.989 kB
react-avatar
AvatarGroupItem		 68.349 kB
19.039 kB
react-badge
Badge		 22.6 kB
7.205 kB
react-badge
CounterBadge		 23.503 kB
7.497 kB
react-badge
PresenceBadge		 24.05 kB
7.067 kB
react-button
Button		 35.836 kB
9.59 kB
react-button
CompoundButton		 42.862 kB
10.808 kB
react-button
MenuButton		 38.454 kB
10.461 kB
react-button
SplitButton		 45.87 kB
11.811 kB
react-button
ToggleButton		 51.017 kB
11.007 kB
react-card
Card - All		 67.002 kB
19.261 kB
react-card
Card		 62.684 kB
18.177 kB
react-card
CardFooter		 8.561 kB
3.601 kB
react-card
CardHeader		 9.604 kB
3.94 kB
react-card
CardPreview		 8.662 kB
3.656 kB
react-combobox
Combobox (including child components)		 73.863 kB
24.018 kB
react-combobox
Dropdown (including child components)		 73.45 kB
23.927 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 187.656 kB
51.96 kB
react-components
react-components: FluentProvider & webLightTheme		 33.359 kB
11.004 kB
react-dialog
Dialog (including children components)		 80.983 kB
24.187 kB
react-divider
Divider		 16.459 kB
5.902 kB
react-image
Image		 10.78 kB
4.264 kB
react-input
Input		 23.598 kB
7.661 kB
react-label
Label		 9.338 kB
3.86 kB
react-link
Link		 12.254 kB
4.956 kB
react-menu
Menu (including children components)		 115.735 kB
35.419 kB
react-menu
Menu (including selectable components)		 118.934 kB
35.916 kB
react-overflow
hooks only		 10.685 kB
4.104 kB
react-popover
Popover		 102.938 kB
31.542 kB
react-portal
Portal		 10.576 kB
3.875 kB
react-portal-compat
PortalCompatProvider		 5.851 kB
1.964 kB
react-positioning
usePositioning		 19.7 kB
7.404 kB
react-provider
FluentProvider		 15.755 kB
5.883 kB
react-radio
Radio		 35.56 kB
11.929 kB
react-radio
RadioGroup		 14.248 kB
5.7 kB
react-select
Select		 20.846 kB
7.346 kB
react-slider
Slider		 31.526 kB
10.046 kB
react-spinbutton
SpinButton		 43.943 kB
12.382 kB
react-spinner
Spinner		 19.977 kB
6.438 kB
react-switch
Switch		 32.097 kB
10.27 kB
react-text
Text - Default		 11.782 kB
4.605 kB
react-text
Text - Wrappers		 15.092 kB
5.044 kB
react-textarea
Textarea		 23.774 kB
7.881 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 29.548 kB
6.434 kB
react-theme
Teams: Light theme		 17.452 kB
5.054 kB
react-tooltip
Tooltip		 41.502 kB
14.623 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against aa1b9dd77b36fe633d64430db0292af546bbe35c

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 8, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 145 133 1.09:1
AttachmentMinimalPerf.default 128 121 1.06:1
IconMinimalPerf.default 576 545 1.06:1
AccordionMinimalPerf.default 127 121 1.05:1
DividerMinimalPerf.default 321 309 1.04:1
HeaderMinimalPerf.default 317 309 1.03:1
ImageMinimalPerf.default 340 331 1.03:1
SkeletonMinimalPerf.default 302 294 1.03:1
FlexMinimalPerf.default 245 241 1.02:1
HeaderSlotsPerf.default 685 670 1.02:1
ListMinimalPerf.default 463 456 1.02:1
ReactionMinimalPerf.default 327 322 1.02:1
StatusMinimalPerf.default 605 595 1.02:1
TextMinimalPerf.default 308 301 1.02:1
ButtonOverridesMissPerf.default 1022 1007 1.01:1
ButtonSlotsPerf.default 421 415 1.01:1
ChatMinimalPerf.default 630 623 1.01:1
CheckboxMinimalPerf.default 1527 1516 1.01:1
DatepickerMinimalPerf.default 4650 4590 1.01:1
DialogMinimalPerf.default 690 681 1.01:1
DropdownManyItemsPerf.default 545 538 1.01:1
DropdownMinimalPerf.default 2173 2150 1.01:1
ItemLayoutMinimalPerf.default 971 960 1.01:1
LayoutMinimalPerf.default 316 312 1.01:1
ListNestedPerf.default 456 451 1.01:1
LoaderMinimalPerf.default 520 515 1.01:1
MenuMinimalPerf.default 739 730 1.01:1
RosterPerf.default 1717 1697 1.01:1
PopupMinimalPerf.default 555 550 1.01:1
PortalMinimalPerf.default 140 139 1.01:1
TableManyItemsPerf.default 1571 1561 1.01:1
TextAreaMinimalPerf.default 411 408 1.01:1
CustomToolbarPrototype.default 2162 2151 1.01:1
AnimationMinimalPerf.default 468 467 1:1
CarouselMinimalPerf.default 357 356 1:1
EmbedMinimalPerf.default 2633 2632 1:1
GridMinimalPerf.default 291 292 1:1
InputMinimalPerf.default 850 848 1:1
ProviderMergeThemesPerf.default 978 982 1:1
SegmentMinimalPerf.default 298 299 1:1
SplitButtonMinimalPerf.default 3266 3276 1:1
TooltipMinimalPerf.default 1901 1897 1:1
TreeMinimalPerf.default 693 692 1:1
AttachmentSlotsPerf.default 855 862 0.99:1
CardMinimalPerf.default 458 461 0.99:1
FormMinimalPerf.default 332 336 0.99:1
LabelMinimalPerf.default 339 342 0.99:1
RadioGroupMinimalPerf.default 383 385 0.99:1
SliderMinimalPerf.default 1226 1235 0.99:1
TableMinimalPerf.default 350 354 0.99:1
ToolbarMinimalPerf.default 786 793 0.99:1
VideoMinimalPerf.default 607 615 0.99:1
AvatarMinimalPerf.default 160 164 0.98:1
BoxMinimalPerf.default 295 300 0.98:1
ChatWithPopoverPerf.default 294 299 0.98:1
ProviderMinimalPerf.default 311 317 0.98:1
RefMinimalPerf.default 181 185 0.98:1
AlertMinimalPerf.default 214 220 0.97:1
ListCommonPerf.default 510 527 0.97:1
MenuButtonMinimalPerf.default 1303 1349 0.97:1
ChatDuplicateMessagesPerf.default 220 232 0.95:1
ListWith60ListItems.default 466 489 0.95:1
TreeWith60ListItems.default 124 131 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 8, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 751 775 5000
Breadcrumb mount 2324 2348 1000
Checkbox mount 2214 2206 5000
CheckboxBase mount 1950 1954 5000
ChoiceGroup mount 3873 3797 5000
ComboBox mount 770 759 1000
CommandBar mount 8881 8819 1000
ContextualMenu mount 9661 9741 1000
DefaultButton mount 934 943 5000
DetailsRow mount 3023 2974 5000
DetailsRowFast mount 3013 3027 5000
DetailsRowNoStyles mount 2867 2819 5000
Dialog mount 2542 2519 1000
DocumentCardTitle mount 147 166 1000
Dropdown mount 2769 2766 5000
FocusTrapZone mount 1557 1524 5000
FocusZone mount 1497 1507 5000
IconButton mount 1363 1397 5000
Label mount 317 326 5000
Layer mount 3719 3673 5000
Link mount 420 418 5000
MenuButton mount 1196 1190 5000
MessageBar mount 1839 1866 5000
Nav mount 2646 2680 1000
OverflowSet mount 963 991 5000
Panel mount 2075 2058 1000
Persona mount 795 833 1000
Pivot mount 1109 1114 1000
PrimaryButton mount 1074 1059 5000
Rating mount 6623 6579 5000
SearchBox mount 1092 1081 5000
Shimmer mount 2483 2457 5000
Slider mount 1699 1682 5000
SpinButton mount 3861 3845 5000
Spinner mount 400 402 5000
SplitButton mount 2454 2392 5000
Stack mount 458 466 5000
StackWithIntrinsicChildren mount 1831 1843 5000
StackWithTextChildren mount 4545 4529 5000
SwatchColorPicker mount 9103 9074 5000
TagPicker mount 1916 1908 5000
TeachingBubble mount 74462 73961 5000
Text mount 400 387 5000
TextField mount 1118 1156 5000
ThemeProvider mount 1011 1038 5000
ThemeProvider virtual-rerender 720 721 5000
ThemeProvider virtual-rerender-with-unmount 1572 1595 5000
Toggle mount 717 715 5000
buttonNative mount 108 100 5000

@sopranopillow sopranopillow marked this pull request as ready for review September 8, 2022 18:35
@sopranopillow sopranopillow requested review from a team as code owners September 8, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sopranopillow sopranopillow

Labels

Component: Persona

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sopranopillow @fabricteam