fix(react-18-tests-v8): remove type-check command to fix CI issue by TristanWatanabe · Pull Request #24637 · microsoft/fluentui

TristanWatanabe · 2022-09-01T19:07:49Z

Changes

Removes type-check command which is causing a race condition issue in the CI pipeline causing it to fail. type-check command for the react-18-tests-v8 app is being ran BEFORE @fluentui/react finishes building which causes the intermittent error below.

Error:

ERR! [@fluentui/react-18-tests-v8 type-check] ERROR DETECTED
ERR! started
ERR! hash: bfb8f2139aa5cf3cc93acad19377a674d8c10378, cache hit? false
ERR! Running /opt/hostedtoolcache/node/14.18.1/x64/bin/npm run type-check
ERR! npm WARN lifecycle The node binary used for scripts is /tmp/yarn--1662060828967-0.16018444283984823/node but npm is using /opt/hostedtoolcache/node/14.18.1/x64/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.
ERR! 
ERR! > @fluentui/react-18-tests-v8@1.0.0 type-check /mnt/vss/_work/1/s/apps/react-18-tests-v8
ERR! > tsc -b
ERR! 
ERR! src/components/ContextualMenu/ContextualMenuExample.tsx(7,8): error TS2307: Cannot find module '@fluentui/react/lib/ContextualMenu' or its corresponding type declarations.
ERR! src/components/ContextualMenu/ContextualMenuExample.tsx(8,43): error TS2307: Cannot find module '@fluentui/react/lib/Button' or its corresponding type declarations.
ERR! src/components/ContextualMenu/ContextualMenuExample.tsx(9,36): error TS2307: Cannot find module '@fluentui/react/lib/FocusZone' or its corresponding type declarations.
ERR! src/components/ContextualMenu/ContextualMenuExample.tsx(10,32): error TS2307: Cannot find module '@fluentui/react/lib/Styling' or its corresponding type declarations.
ERR! src/components/ContextualMenu/ContextualMenuExample.tsx(11,21): error TS2307: Cannot find module '@fluentui/react/lib/Utilities' or its corresponding type declarations.
ERR! src/App.tsx(2,70): error TS2307: Cannot find module '@fluentui/react' or its corresponding type declarations.
ERR! src/components/ContextualMenu/ContextualMenu.e2e.tsx(3,72): error TS2307: Cannot find module '@fluentui/react' or its corresponding type declarations.
ERR! src/components/ContextualMenu/ContextualMenu.test.tsx(4,72): error TS2307: Cannot find module '@fluentui/react' or its corresponding type declarations.
ERR! src/components/ContextualMenu/ContextualMenu.e2e.tsx(3,72): error TS2307: Cannot find module '@fluentui/react' or its corresponding type declarations.
ERR! npm ERR! code ELIFECYCLE
ERR! npm ERR! errno 1
ERR! npm ERR! @fluentui/react-18-tests-v8@1.0.0 type-check: `tsc -b`
ERR! npm ERR! Exit status 1
ERR! npm ERR! 
ERR! npm ERR! Failed at the @fluentui/react-18-tests-v8@1.0.0 type-check script.
ERR! npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Example Error: https://uifabric.visualstudio.com/fabricpublic/_build/results?buildId=265008&view=logs&j=258ec178-2d8b-5611-7b9b-60c5c95dae55&t=8250ef03-1890-59ab-a6a8-5d0b4c2baa1b

This reverts commit 73933a9.

fabricteam · 2022-09-01T19:15:30Z

📊 Bundle size report

_{🤖 This report was generated against 7d20856c9abf142b221622ae743e4c9d3c7c9293}

codesandbox-ci · 2022-09-01T19:26:54Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9855c25:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-09-01T19:29:31Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7d20856c9abf142b221622ae743e4c9d3c7c9293 (build)

fabricteam · 2022-09-01T20:07:39Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1292	1298	5000
Button	mount	927	917	5000
FluentProvider	mount	1486	1468	5000
FluentProviderWithTheme	mount	579	585	10
FluentProviderWithTheme	virtual-rerender	540	552	10
FluentProviderWithTheme	virtual-rerender-with-unmount	568	571	10
MakeStyles	mount	1958	1951	50000
SpinButton	mount	2321	2346	5000

fabricteam · 2022-09-01T20:16:09Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ChatMinimalPerf.default	609	528	1.15:1
DropdownManyItemsPerf.default	560	487	1.15:1
ReactionMinimalPerf.default	310	273	1.14:1
MenuMinimalPerf.default	681	605	1.13:1
FormMinimalPerf.default	301	268	1.12:1
GridMinimalPerf.default	272	243	1.12:1
TreeWith60ListItems.default	145	131	1.11:1
AttachmentSlotsPerf.default	901	822	1.1:1
ButtonMinimalPerf.default	124	113	1.1:1
ButtonSlotsPerf.default	437	397	1.1:1
SliderMinimalPerf.default	1369	1259	1.09:1
ImageMinimalPerf.default	307	285	1.08:1
LayoutMinimalPerf.default	276	256	1.08:1
ProviderMinimalPerf.default	318	294	1.08:1
SkeletonMinimalPerf.default	253	237	1.07:1
TableManyItemsPerf.default	1483	1384	1.07:1
HeaderSlotsPerf.default	628	592	1.06:1
ItemLayoutMinimalPerf.default	934	879	1.06:1
ListCommonPerf.default	479	452	1.06:1
TableMinimalPerf.default	328	310	1.06:1
ToolbarMinimalPerf.default	695	664	1.05:1
PopupMinimalPerf.default	517	499	1.04:1
BoxMinimalPerf.default	252	244	1.03:1
RosterPerf.default	1747	1702	1.03:1
DialogMinimalPerf.default	620	606	1.02:1
LabelMinimalPerf.default	287	282	1.02:1
MenuButtonMinimalPerf.default	1287	1266	1.02:1
DatepickerMinimalPerf.default	4484	4440	1.01:1
HeaderMinimalPerf.default	297	293	1.01:1
ListWith60ListItems.default	457	454	1.01:1
CardMinimalPerf.default	383	383	1:1
DividerMinimalPerf.default	261	260	1:1
InputMinimalPerf.default	1044	1039	1:1
RadioGroupMinimalPerf.default	366	365	1:1
TreeMinimalPerf.default	650	649	1:1
AnimationMinimalPerf.default	433	439	0.99:1
DropdownMinimalPerf.default	2355	2385	0.99:1
FlexMinimalPerf.default	205	207	0.99:1
ProviderMergeThemesPerf.default	965	974	0.99:1
ButtonOverridesMissPerf.default	1107	1129	0.98:1
SplitButtonMinimalPerf.default	3325	3394	0.98:1
AlertMinimalPerf.default	223	229	0.97:1
LoaderMinimalPerf.default	506	523	0.97:1
RefMinimalPerf.default	176	181	0.97:1
VideoMinimalPerf.default	521	538	0.97:1
CarouselMinimalPerf.default	353	367	0.96:1
CheckboxMinimalPerf.default	2063	2139	0.96:1
EmbedMinimalPerf.default	3234	3381	0.96:1
ListMinimalPerf.default	407	422	0.96:1
AttachmentMinimalPerf.default	102	107	0.95:1
ChatDuplicateMessagesPerf.default	218	229	0.95:1
PortalMinimalPerf.default	120	126	0.95:1
IconMinimalPerf.default	474	501	0.95:1
TextMinimalPerf.default	259	276	0.94:1
AccordionMinimalPerf.default	108	116	0.93:1
CustomToolbarPrototype.default	2213	2375	0.93:1
TextAreaMinimalPerf.default	360	393	0.92:1
TooltipMinimalPerf.default	1721	1869	0.92:1
SegmentMinimalPerf.default	254	283	0.9:1
AvatarMinimalPerf.default	137	156	0.88:1
ListNestedPerf.default	403	456	0.88:1
StatusMinimalPerf.default	509	581	0.88:1
ChatWithPopoverPerf.default	275	315	0.87:1

fabricteam · 2022-09-01T20:30:09Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1039	1026	5000
Breadcrumb	mount	2996	2995	1000
Checkbox	mount	2873	2863	5000
CheckboxBase	mount	2531	2508	5000
ChoiceGroup	mount	5307	5299	5000
ComboBox	mount	1135	1182	1000
CommandBar	mount	11402	11145	1000
ContextualMenu	mount	12861	12914	1000
DefaultButton	mount	1246	1290	5000
DetailsRow	mount	4245	4291	5000
DetailsRowFast	mount	4263	4300	5000
DetailsRowNoStyles	mount	4067	4026	5000
Dialog	mount	3310	3399	1000
DocumentCardTitle	mount	205	229	1000
Dropdown	mount	3715	3755	5000
FocusTrapZone	mount	2077	2012	5000
FocusZone	mount	2045	1971	5000
IconButton	mount	1982	2007	5000
Label	mount	389	400	5000
Layer	mount	4780	4805	5000
Link	mount	554	559	5000
MenuButton	mount	1842	1736	5000
MessageBar	mount	2426	2544	5000
Nav	mount	3762	3823	1000
OverflowSet	mount	1216	1221	5000
Panel	mount	2748	2628	1000
Persona	mount	1102	1141	1000
Pivot	mount	1639	1645	1000
PrimaryButton	mount	1472	1450	5000
Rating	mount	8747	8716	5000
SearchBox	mount	1557	1450	5000
Shimmer	mount	3299	3291	5000
Slider	mount	2135	2140	5000
SpinButton	mount	5501	5420	5000
Spinner	mount	477	456	5000
SplitButton	mount	3448	3523	5000
Stack	mount	560	578	5000
StackWithIntrinsicChildren	mount	2800	2690	5000
StackWithTextChildren	mount	6319	5927	5000
SwatchColorPicker	mount	12898	12797	5000
TagPicker	mount	2966	2890	5000
TeachingBubble	mount	102638	103877	5000
Text	mount	487	490	5000
TextField	mount	1514	1584	5000
ThemeProvider	mount	1356	1357	5000
ThemeProvider	virtual-rerender	806	845	5000
ThemeProvider	virtual-rerender-with-unmount	2161	2205	5000
Toggle	mount	864	878	5000
buttonNative	mount	144	152	5000

TristanWatanabe added 5 commits September 1, 2022 11:02

fix: simplify import

73933a9

fix: add build script

5d817fb

Revert "fix: simplify import"

3db1e68

This reverts commit 73933a9.

nit: order scripts alphabetically

7d343c3

chore: update to latest version of react-hooks

a726d53

TristanWatanabe added the Area: Build System label Sep 1, 2022

TristanWatanabe self-assigned this Sep 1, 2022

github-actions bot added this to the July Project Cycle Q3 2022 milestone Sep 1, 2022

TristanWatanabe marked this pull request as ready for review September 1, 2022 19:08

TristanWatanabe requested a review from micahgodbolt September 1, 2022 19:08

TristanWatanabe marked this pull request as draft September 1, 2022 19:17

test

6795e89

TristanWatanabe force-pushed the fix-import-issue branch from ba790e2 to 6795e89 Compare September 1, 2022 19:33

TristanWatanabe changed the title ~~fix(react-18-tests-v8): Add missing build script to prevent race condition issue~~ fix(react-18-tests-v8): Fix race condition issue Sep 1, 2022

fix: remove type-check command

9855c25

TristanWatanabe force-pushed the fix-import-issue branch from 35211e6 to 9855c25 Compare September 1, 2022 20:17

TristanWatanabe changed the title ~~fix(react-18-tests-v8): Fix race condition issue~~ fix(react-18-tests-v8): remove type-check command to fix CI issue Sep 1, 2022

TristanWatanabe marked this pull request as ready for review September 1, 2022 20:23

micahgodbolt approved these changes Sep 1, 2022

View reviewed changes

TristanWatanabe merged commit 0ff310e into microsoft:master Sep 1, 2022

TristanWatanabe deleted the fix-import-issue branch September 1, 2022 20:38

TristanWatanabe mentioned this pull request Sep 19, 2022

react-18-tests-v8: Add type-checking again #24856

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(react-18-tests-v8): remove type-check command to fix CI issue#24637

fix(react-18-tests-v8): remove type-check command to fix CI issue#24637
TristanWatanabe merged 7 commits intomicrosoft:masterfrom
TristanWatanabe:fix-import-issue

TristanWatanabe commented Sep 1, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 1, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented Sep 1, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Sep 1, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 1, 2022

Uh oh!

fabricteam commented Sep 1, 2022

Uh oh!

fabricteam commented Sep 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

TristanWatanabe commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

fabricteam commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

codesandbox-ci bot commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Sep 1, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Sep 1, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Sep 1, 2022

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TristanWatanabe commented Sep 1, 2022 •

edited

Loading

fabricteam commented Sep 1, 2022 •

edited

Loading

codesandbox-ci bot commented Sep 1, 2022 •

edited

Loading

size-auditor bot commented Sep 1, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)