fix: Making PopoverSurface focusable, moving Overflow aria-label to PopoverSurface, and moving content styles to PopoverSurface#24417
Merged
sopranopillow merged 6 commits intomicrosoft:masterfrom Aug 19, 2022
Conversation
…opoverSurface, and moving content styles to PopoverSurface.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0a06317:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1554 | 1572 | 5000 | |
| Button | mount | 1206 | 1178 | 5000 | |
| FluentProvider | mount | 1992 | 1979 | 5000 | |
| FluentProviderWithTheme | mount | 812 | 775 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 722 | 730 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 767 | 817 | 10 | |
| MakeStyles | mount | 2365 | 2327 | 50000 | |
| SpinButton | mount | 3060 | 3046 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6853d071ca06579092a9cc3660fe9943479492d6 (build) |
smhigley
approved these changes
Aug 18, 2022
Contributor
smhigley
left a comment
There was a problem hiding this comment.
Just checked, and both NVDA and JAWS are working perfectly with the fix 😊
...es/react-components/react-avatar/src/components/AvatarGroupPopover/useAvatarGroupPopover.tsx
Show resolved
Hide resolved
spmonahan
approved these changes
Aug 19, 2022
...act-components/react-avatar/src/components/AvatarGroupPopover/useAvatarGroupPopoverStyles.ts
Outdated
Show resolved
Hide resolved
…oupPopover/useAvatarGroupPopoverStyles.ts Co-authored-by: Sean Monahan <seanmonahan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently Content has most of the styles needed for the Popover Surface, this brings problems with screen readers:
<ul>therefore there are some listbox problems in Windows where the screen reader mode is changed to forms mode.New Behavior
Makes PopoverSurface focusable, moves Overflow aria-label to PopoverSurface, and moves content styles to PopoverSurface. This fixes the accessibility issues mentioned above.
Related Issue(s)
#23773