feat: Implement unstable navigation modes#24383
Merged
ling1726 merged 7 commits intomicrosoft:masterfrom Aug 18, 2022
Merged
Conversation
Introduces and unstable hook `useNavigationMode`to implement the proposed table navigation modes. This hook is temporary and its existence will be a final release blocker.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 518ff9e:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1261 | 1262 | 5000 | |
| Button | mount | 954 | 941 | 5000 | |
| FluentProvider | mount | 1451 | 1585 | 5000 | |
| FluentProviderWithTheme | mount | 629 | 633 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 580 | 520 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 627 | 624 | 10 | |
| MakeStyles | mount | 1933 | 1912 | 50000 | |
| SpinButton | mount | 2468 | 2485 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: df602db552cade02f2a0922e7ba829975232c7dc (build) |
ling1726
commented
Aug 17, 2022
| {rows.map(({ item, selected, toggleSelect }) => ( | ||
| <TableRow key={item.file.label} onClick={toggleSelect} aria-selected={selected}> | ||
| <TableSelectionCell checked={selected} /> | ||
| <TableBody ref={ref}> |
Contributor
Author
There was a problem hiding this comment.
the mover is on the body because of a bug in tabster regarding inputs, I'll report this there
bsunderhus
reviewed
Aug 17, 2022
| export type NavigationMode = 'row' | 'cell' | 'composite'; | ||
|
|
||
| /** | ||
| * THIS HOOK WILL NOT EXIST IN STABLE RELEASE |
bsunderhus
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces and unstable hook
useNavigationModeto implement theproposed table navigation modes.
This hook is temporary and its existence will be a final release
blocker.
Fixes #24381
Fixes #24227
Fixes #24228
Affects #24382