Skip to content

RFC: File Organization Convention for v9 Packages#24332

Merged
TristanWatanabe merged 5 commits intomicrosoft:masterfrom
TristanWatanabe:rfc-v9-package-folder-structure
Aug 22, 2022
Merged

RFC: File Organization Convention for v9 Packages#24332
TristanWatanabe merged 5 commits intomicrosoft:masterfrom
TristanWatanabe:rfc-v9-package-folder-structure

Conversation

@TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Aug 10, 2022

RFC for defining a convention on how files should be organized in v9 packages.

PREVIEW

Part of #24129

@TristanWatanabe TristanWatanabe added the Type: RFC Request for Feedback label Aug 10, 2022
@TristanWatanabe TristanWatanabe self-assigned this Aug 10, 2022
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Aug 10, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 10, 2022

📊 Bundle size report

🤖 This report was generated against 1d0a72865a151962362aa3e5054ac9bf8178f09c

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e34e692:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 10, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 27a3480f5361aa5d99f8978817d8395d9037e3b7 (build)

@TristanWatanabe TristanWatanabe marked this pull request as ready for review August 10, 2022 21:20
@TristanWatanabe TristanWatanabe requested review from a team and Hotell August 10, 2022 21:20
Copy link
Contributor

@ling1726 ling1726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making stories location consistent makes sense to me

@TristanWatanabe TristanWatanabe merged commit d07e579 into microsoft:master Aug 22, 2022
@TristanWatanabe TristanWatanabe deleted the rfc-v9-package-folder-structure branch August 22, 2022 20:38
|- assets/
|- e2e tests
|- src/
|- common/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this common is root of evil regarding type-checking etc :P, can we remove it ? #23976

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being addressed in #24543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: RFC Request for Feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants