Added exports missing from components#23306
Closed
GeoffCoxMSFT wants to merge 1 commit intomicrosoft:masterfrom
Closed
Added exports missing from components#23306GeoffCoxMSFT wants to merge 1 commit intomicrosoft:masterfrom
GeoffCoxMSFT wants to merge 1 commit intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8fc8451:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 969708ea8759adeceb51f3d60a401989ceb2a9b4 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 969708ea8759adeceb51f3d60a401989ceb2a9b4 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1054 | 1050 | 5000 | |
| Button | mount | 663 | 637 | 5000 | |
| FluentProvider | mount | 2234 | 2193 | 5000 | |
| FluentProviderWithTheme | mount | 349 | 356 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 286 | 270 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 381 | 360 | 10 | |
| MakeStyles | mount | 1886 | 1892 | 50000 |
Hotell
reviewed
May 30, 2022
| } from '@fluentui/react-accordion'; | ||
| export { | ||
| Avatar, | ||
| // exported from component, but not exported from stable or unstable //AvatarGroup, et.al |
Contributor
There was a problem hiding this comment.
AFAIR this is as expected.
Pattern should be like following (please correct me if I'm wrong) :
- export "everything" from particular package (eg react-text)
- export only what is really public API from
react-componentsboth stable andunstable
would be great to have this documented
Member
Author
|
rc final shipped, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT TO BE CHECKED IN
This provides a list of the missing exports for individual component owners to fix.