docs: setup github issues beta templates by Hotell · Pull Request #22337 · microsoft/fluentui

Hotell · 2022-04-05T17:23:22Z

Current Behavior

At the moment we identified 2 main issues when having shield duty or doing triaging of new issues:

when creating issue, contributor has no context/missing guidance for what library in our monorepo is that issue for
contributors are not enforced to provide proper reproduction and library version that is affected, which leads to additional time spent on our side to triage etc

New Behavior

we leverage new github issues templates that provide superb UX to contributors
we enforce proper reports and issue formats so we can effectively triage and act if needed
we unify our bug template
instead creating dummy issues we leverage proper UX to forward contributors to github discsussion and stack overflow

Preview

Next steps

as a follow up, github action will be created to properly add tags of library versions etc which will reduce time spend on triaging significantly

codesandbox-ci · 2022-04-05T17:32:52Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bbbacc3:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-04-05T17:35:32Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`priority-overflow` createOverflowManager	`2.836 kB` `1.209 kB`
`react-accordion` Accordion (including children components)	`74.792 kB` `22.516 kB`
`react-avatar` Avatar	`45.142 kB` `13.111 kB`
`react-badge` Badge	`20.895 kB` `6.567 kB`
`react-badge` CounterBadge	`21.848 kB` `6.883 kB`
`react-badge` PresenceBadge	`21.951 kB` `6.565 kB`
`react-button` Button	`28.013 kB` `8.059 kB`
`react-button` CompoundButton	`33.508 kB` `9.092 kB`
`react-button` MenuButton	`29.796 kB` `8.665 kB`
`react-button` SplitButton	`36.268 kB` `9.863 kB`
`react-button` ToggleButton	`37.395 kB` `8.68 kB`
`react-card` Card - All	`53.619 kB` `15.372 kB`
`react-card` Card	`48.904 kB` `14.089 kB`
`react-card` CardFooter	`7.686 kB` `3.264 kB`
`react-card` CardHeader	`9.251 kB` `3.78 kB`
`react-card` CardPreview	`7.658 kB` `3.291 kB`
`react-combobox` Combobox	`54.566 kB` `18.884 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`176.089 kB` `49.113 kB`
`react-components` react-components: FluentProvider & webLightTheme	`32.601 kB` `10.668 kB`
`react-divider` Divider	`15.385 kB` `5.539 kB`
`react-image` Image	`10.109 kB` `3.958 kB`
`react-input` Input	`21.661 kB` `7.18 kB`
`react-label` Label	`8.371 kB` `3.504 kB`
`react-link` Link	`11.106 kB` `4.507 kB`
`react-menu` Menu (including children components)	`105.852 kB` `32.433 kB`
`react-menu` Menu (including selectable components)	`109.031 kB` `32.897 kB`
`react-popover` Popover	`96.787 kB` `29.559 kB`
`react-portal` Portal	`6.272 kB` `2.17 kB`
`react-positioning` usePopper	`23.21 kB` `8.084 kB`
`react-priority-overflow` hooks only	`10.606 kB` `4.087 kB`
`react-provider` FluentProvider	`14.009 kB` `5.25 kB`
`react-select` Select	`16.562 kB` `6.264 kB`
`react-slider` Slider	`25.549 kB` `8.25 kB`
`react-spinner` Spinner	`16.459 kB` `5.549 kB`
`react-switch` Switch	`24.279 kB` `8.001 kB`
`react-text` Text - Default	`10.797 kB` `4.233 kB`
`react-text` Text - Wrappers	`14.113 kB` `4.576 kB`
`react-textarea` Textarea	`20.602 kB` `7.033 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.676 kB` `6.604 kB`
`react-theme` Teams: Light theme	`18.492 kB` `5.296 kB`
`react-tooltip` Tooltip	`42.837 kB` `14.727 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against 945e0de222fddfb8e23c23c8e6600585fe77a0c6}

fabricteam · 2022-04-05T17:40:45Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1074	1048	5000
Button	mount	638	631	5000
FluentProvider	mount	2094	2142	5000
FluentProviderWithTheme	mount	322	330	10
FluentProviderWithTheme	virtual-rerender	275	273	10
FluentProviderWithTheme	virtual-rerender-with-unmount	325	373	10
MakeStyles	mount	1862	1847	50000

fabricteam · 2022-04-05T17:46:58Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	126	118	1.07:1
ButtonMinimalPerf.default	142	133	1.07:1
DividerMinimalPerf.default	308	289	1.07:1
ChatDuplicateMessagesPerf.default	253	238	1.06:1
HeaderMinimalPerf.default	306	290	1.06:1
LabelMinimalPerf.default	326	309	1.06:1
ProviderMinimalPerf.default	340	325	1.05:1
FlexMinimalPerf.default	240	231	1.04:1
HeaderSlotsPerf.default	644	621	1.04:1
SegmentMinimalPerf.default	289	279	1.04:1
TableMinimalPerf.default	336	322	1.04:1
BoxMinimalPerf.default	288	280	1.03:1
ChatMinimalPerf.default	626	605	1.03:1
FormMinimalPerf.default	339	328	1.03:1
ListNestedPerf.default	460	447	1.03:1
SkeletonMinimalPerf.default	292	284	1.03:1
AnimationMinimalPerf.default	459	448	1.02:1
DialogMinimalPerf.default	651	640	1.02:1
GridMinimalPerf.default	283	278	1.02:1
ListMinimalPerf.default	427	417	1.02:1
ListWith60ListItems.default	547	538	1.02:1
RadioGroupMinimalPerf.default	373	367	1.02:1
ToolbarMinimalPerf.default	801	787	1.02:1
TreeWith60ListItems.default	143	140	1.02:1
AvatarMinimalPerf.default	154	152	1.01:1
ButtonOverridesMissPerf.default	1250	1235	1.01:1
CheckboxMinimalPerf.default	2287	2263	1.01:1
DropdownMinimalPerf.default	2577	2546	1.01:1
ImageMinimalPerf.default	310	306	1.01:1
LayoutMinimalPerf.default	296	292	1.01:1
MenuMinimalPerf.default	721	715	1.01:1
MenuButtonMinimalPerf.default	1424	1415	1.01:1
RosterPerf.default	949	936	1.01:1
PopupMinimalPerf.default	529	525	1.01:1
PortalMinimalPerf.default	139	138	1.01:1
ReactionMinimalPerf.default	308	306	1.01:1
SplitButtonMinimalPerf.default	3688	3667	1.01:1
StatusMinimalPerf.default	565	557	1.01:1
ButtonSlotsPerf.default	454	456	1:1
CardMinimalPerf.default	459	461	1:1
EmbedMinimalPerf.default	3478	3473	1:1
LoaderMinimalPerf.default	573	575	1:1
ProviderMergeThemesPerf.default	1058	1054	1:1
SliderMinimalPerf.default	1410	1409	1:1
TextMinimalPerf.default	282	282	1:1
TextAreaMinimalPerf.default	399	399	1:1
CustomToolbarPrototype.default	2297	2294	1:1
TooltipMinimalPerf.default	905	908	1:1
AlertMinimalPerf.default	221	224	0.99:1
ChatWithPopoverPerf.default	321	323	0.99:1
DropdownManyItemsPerf.default	560	568	0.99:1
InputMinimalPerf.default	1082	1092	0.99:1
ItemLayoutMinimalPerf.default	990	997	0.99:1
ListCommonPerf.default	534	540	0.99:1
TableManyItemsPerf.default	1616	1634	0.99:1
TreeMinimalPerf.default	674	678	0.99:1
RefMinimalPerf.default	192	195	0.98:1
VideoMinimalPerf.default	547	559	0.98:1
CarouselMinimalPerf.default	385	397	0.97:1
DatepickerMinimalPerf.default	4784	4912	0.97:1
IconMinimalPerf.default	516	539	0.96:1
AttachmentSlotsPerf.default	912	966	0.94:1
AccordionMinimalPerf.default	111	119	0.93:1

size-auditor · 2022-04-05T17:48:30Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 945e0de222fddfb8e23c23c8e6600585fe77a0c6 (build)

fabricteam · 2022-04-05T17:54:43Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	950	896	5000
Breadcrumb	mount	2809	2823	1000
Checkbox	mount	1580	1527	5000
CheckboxBase	mount	1307	1343	5000
ChoiceGroup	mount	4827	4865	5000
ComboBox	mount	1085	1026	1000
CommandBar	mount	10730	10791	1000
ContextualMenu	mount	11878	11796	1000
DefaultButton	mount	1196	1188	5000
DetailsRow	mount	3869	3863	5000
DetailsRowFast	mount	3863	3857	5000
DetailsRowNoStyles	mount	3796	3634	5000
Dialog	mount	2313	2268	1000
DocumentCardTitle	mount	159	165	1000
Dropdown	mount	3408	3642	5000
FocusTrapZone	mount	1916	1804	5000
FocusZone	mount	1846	1830	5000
IconButton	mount	1812	1796	5000
Label	mount	382	349	5000
Layer	mount	2987	3019	5000
Link	mount	481	487	5000
MenuButton	mount	1542	1513	5000
MessageBar	mount	2299	2204	5000
Nav	mount	3326	3352	1000
OverflowSet	mount	1101	1124	5000
Panel	mount	2219	2197	1000
Persona	mount	1049	1014	1000
Pivot	mount	1460	1497	1000
PrimaryButton	mount	1347	1300	5000
Rating	mount	7900	7901	5000
SearchBox	mount	1330	1302	5000
Shimmer	mount	2477	2517	5000
Slider	mount	2030	2014	5000
SpinButton	mount	5138	5187	5000
Spinner	mount	450	451	5000
SplitButton	mount	3326	3328	5000
Stack	mount	550	532	5000
StackWithIntrinsicChildren	mount	2322	2341	5000
StackWithTextChildren	mount	5437	5365	5000
SwatchColorPicker	mount	12059	12174	5000
TagPicker	mount	2792	2828	5000
TeachingBubble	mount	102499	106576	5000
Text	mount	432	446	5000
TextField	mount	1497	1405	5000
ThemeProvider	mount	1191	1235	5000
ThemeProvider	virtual-rerender	664	667	5000
ThemeProvider	virtual-rerender-with-unmount	1892	1890	5000
Toggle	mount	848	808	5000
buttonNative	mount	147	127	5000

micahgodbolt · 2022-04-05T19:46:45Z

Is there a way to do a default severity level?

layershifter

❤️

.github/ISSUE_TEMPLATE/bug-report.yml

.github/ISSUE_TEMPLATE/feature-request.yml

layershifter · 2022-04-06T10:13:57Z

.github/ISSUE_TEMPLATE/bug-report.yml

+        **PLEASE NOTE:**
+
+        1. Do not link to, screenshot or reference a Microsoft product in this description.
+        2. Our screen reader support is limited to Edge + Narrator.


I checked briefly with @jurokapsiar and it's not true for Northstar.

I don't know exact requirements, but it's probably not true for v9, too (manual accessibility reviews include screen readers, for example #22345).

that's good to know! - I copied the wording from existing template and reduced it to have more succinct wording. Let's improve this as follow-up WDYT ?

Makes sense to me 👍

.github/ISSUE_TEMPLATE/bug-report.yml

.github/ISSUE_TEMPLATE/feature-request.yml

JustSlone

Looks good, thanks for setting this up! (Left suggestion on vNext -> v9)

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Justin Slone <40304143+JustSlone@users.noreply.github.com>

msft-fluent-ui-bot assigned Hotell Apr 5, 2022

Hotell force-pushed the hotell/revamp-issue-templates branch from 3a521f5 to 5d7cf4e Compare April 5, 2022 17:27

Hotell force-pushed the hotell/revamp-issue-templates branch from 5d7cf4e to d53ccdf Compare April 5, 2022 17:35

Hotell force-pushed the hotell/revamp-issue-templates branch from d53ccdf to aa624cb Compare April 5, 2022 17:36

Hotell force-pushed the hotell/revamp-issue-templates branch from aa624cb to 0df8b6d Compare April 5, 2022 17:58

docs: setup github issues beta templates

0550a3e

Hotell force-pushed the hotell/revamp-issue-templates branch from 0df8b6d to 0550a3e Compare April 5, 2022 18:24

Hotell added 3 commits April 5, 2022 20:27

docs: deprecate old issue templates

020d96c

docs: setup github issues beta templates for feature request

fe52132

fixup! docs: deprecate old issue templates

180f4de

Hotell marked this pull request as ready for review April 5, 2022 18:59

Hotell requested review from JustSlone and jurokapsiar as code owners April 5, 2022 18:59

layershifter approved these changes Apr 6, 2022

View reviewed changes

JustSlone reviewed Apr 7, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved

JustSlone reviewed Apr 7, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/bug-report.yml Outdated Show resolved Hide resolved

JustSlone reviewed Apr 7, 2022

View reviewed changes

.github/ISSUE_TEMPLATE/feature-request.yml Outdated Show resolved Hide resolved

JustSlone approved these changes Apr 7, 2022

View reviewed changes

JustSlone mentioned this pull request Apr 7, 2022

Repo maintenance: update a11y issue template, and add a11y test to convergence checklist #22363

Merged

Apply suggestions from code review

bbbacc3

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Justin Slone <40304143+JustSlone@users.noreply.github.com>

Hotell enabled auto-merge (squash) April 11, 2022 11:17

Hotell merged commit 3f4e39b into microsoft:master Apr 11, 2022

Hotell mentioned this pull request Apr 12, 2022

docs(.github): remove deprecated issue templates #22465

Merged

Hotell mentioned this pull request Sep 14, 2022

ci(github): add GH Action to add issue labels based on new GH issue template #24788

Merged

Conversation

Hotell commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Behavior

New Behavior

Preview

Next steps

Uh oh!

codesandbox-ci bot commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

size-auditor bot commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Apr 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

micahgodbolt commented Apr 5, 2022

Uh oh!

layershifter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

layershifter Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

Hotell Apr 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

layershifter Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JustSlone left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Hotell commented Apr 5, 2022 •

edited

Loading

codesandbox-ci bot commented Apr 5, 2022 •

edited

Loading

fabricteam commented Apr 5, 2022 •

edited

Loading

fabricteam commented Apr 5, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Apr 5, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

size-auditor bot commented Apr 5, 2022 •

edited

Loading

fabricteam commented Apr 5, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Hotell Apr 11, 2022 •

edited

Loading

JustSlone left a comment •

edited

Loading