Skip to content

Cherry pick voiceover tooltip fix to 7.0#22278

Merged
spmonahan merged 5 commits intomicrosoft:7.0from
spmonahan:fix/cherry-pick-voiceover-tooltip-fix-7.0
Apr 4, 2022
Merged

Cherry pick voiceover tooltip fix to 7.0#22278
spmonahan merged 5 commits intomicrosoft:7.0from
spmonahan:fix/cherry-pick-voiceover-tooltip-fix-7.0

Conversation

@spmonahan
Copy link
Contributor

Current Behavior

Tooltips are not properly read by VoiceOver on iOS and iPadOS

New Behavior

Cherry picks changes from #22216 to the 7.0 branch.

Related Issue(s)

@spmonahan spmonahan requested a review from smhigley March 31, 2022 22:18
@spmonahan spmonahan changed the title Fix/cherry pick voiceover tooltip fix 7.0 Cherry pick voiceover tooltip fix to 7.0 Mar 31, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 31, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 118ba9e:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 1, 2022

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react office-ui-fabric-react-Pickers 283.052 kB 282.972 kB BelowBaseline     -80 bytes
office-ui-fabric-react office-ui-fabric-react-PersonaCoin 113.958 kB 113.878 kB BelowBaseline     -80 bytes
office-ui-fabric-react office-ui-fabric-react-Persona 113.958 kB 113.878 kB BelowBaseline     -80 bytes
office-ui-fabric-react office-ui-fabric-react-CommandBar 199.327 kB 199.247 kB BelowBaseline     -80 bytes
office-ui-fabric-react office-ui-fabric-react-FloatingPicker 238.432 kB 238.352 kB BelowBaseline     -80 bytes
office-ui-fabric-react office-ui-fabric-react-Facepile 208.194 kB 208.114 kB BelowBaseline     -80 bytes
office-ui-fabric-react office-ui-fabric-react-SelectedItemsList 227.894 kB 227.814 kB BelowBaseline     -80 bytes
office-ui-fabric-react office-ui-fabric-react-Breadcrumb 197.84 kB 197.76 kB BelowBaseline     -80 bytes
office-ui-fabric-react office-ui-fabric-react-Tooltip 85.318 kB 85.238 kB BelowBaseline     -80 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 595cd1f43514c37e7e1522d2555521469394ab31 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 1, 2022

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 759 769 5000
Breadcrumb mount 36791 37205 5000
Checkbox mount 1312 1341 5000
CheckboxBase mount 1100 1082 5000
ChoiceGroup mount 4226 4214 5000
ComboBox mount 767 768 1000
CommandBar mount 6642 6732 1000
ContextualMenu mount 12253 12371 1000
DefaultButton mount 955 942 5000
DetailsRow mount 3201 3248 5000
DetailsRowFast mount 3241 3261 5000
DetailsRowNoStyles mount 3016 7533 5000
Dialog mount 1457 1493 1000
DocumentCardTitle mount 1544 1601 1000
Dropdown mount 2131 2094 5000
FocusTrapZone mount 1472 1482 5000
FocusZone mount 1540 1557 5000
IconButton mount 1460 1453 5000
Label mount 282 278 5000
Layer mount 1657 1643 5000
Link mount 382 366 5000
MenuButton mount 1231 1250 5000
MessageBar mount 1742 1771 5000
Nav mount 2795 2850 1000
OverflowSet mount 1196 1211 5000
Panel mount 1240 1243 1000
Persona mount 689 812 1000
Pivot mount 1241 1245 1000
PrimaryButton mount 1075 1101 5000
Rating mount 6667 6677 5000
SearchBox mount 1078 1096 5000
Shimmer mount 2201 2225 5000
Slider mount 1273 1276 5000
SpinButton mount 4303 4294 5000
Spinner mount 346 339 5000
SplitButton mount 2676 2695 5000
Stack mount 420 428 5000
StackWithIntrinsicChildren mount 1454 1474 5000
StackWithTextChildren mount 4051 4072 5000
SwatchColorPicker mount 9085 9025 5000
TagPicker mount 2436 2437 5000
TeachingBubble mount 44071 44266 5000
Text mount 364 360 5000
TextField mount 1180 1168 5000
Toggle mount 694 703 5000
button mount 96 87 5000

@spmonahan spmonahan merged commit 054fa01 into microsoft:7.0 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants