refactor: autofix no export star at index file for cxe-prg packages#22124
Merged
Hotell merged 3 commits intomicrosoft:masterfrom Mar 16, 2022
Merged
Conversation
73 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1942c0a:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: df62b071cf725c01cf639e3cf559c99f2ae8cb00 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 901 | 876 | 5000 | |
| Button | mount | 525 | 532 | 5000 | |
| FluentProvider | mount | 1889 | 1699 | 5000 | |
| FluentProviderWithTheme | mount | 254 | 262 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 206 | 217 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 319 | 296 | 10 | |
| MakeStyles | mount | 1556 | 1529 | 50000 |
theerebuss
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
New Behavior
Related Issue(s)
Fixes Partially #22099
Remarks
note that because following PR, there was lot of deprecated API introduced #21960 (comment).
This is the reason why our barrel files have
deprecationrule being turned off in this PR.Q: why didn't you turn that rule off in our local eslint configs?
A: because that would trigger this rule during pre-commit phase which is expensive. we have magic in our eslint-config plugin that turns type-aware checks off when run via lint-staged. I cannot easily reproduce the same behaviour per package - needs better API design