Removing star exports from @fluentui/react-badge#22114
Merged
khmakoto merged 4 commits intomicrosoft:masterfrom Mar 16, 2022
Merged
Removing star exports from @fluentui/react-badge#22114khmakoto merged 4 commits intomicrosoft:masterfrom
khmakoto merged 4 commits intomicrosoft:masterfrom
Conversation
73 tasks
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e0660222b8d9f4f38a61b718c18d4c67e52c8df9 (build) |
Member
|
Build is failing due to a bunch of the exports being duplicated (which I also see looking at the file) |
ling1726
approved these changes
Mar 16, 2022
ling1726
reviewed
Mar 16, 2022
ling1726
reviewed
Mar 16, 2022
ling1726
reviewed
Mar 16, 2022
spmonahan
reviewed
Mar 16, 2022
| export * from './CounterBadge'; | ||
| export { | ||
| Badge, | ||
| badgeClassName, |
Contributor
There was a problem hiding this comment.
Each of the components needs to export its <component>ClassNames object (example)
Member
Author
|
I don't know how this became so messed up 😆 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df4078a:
|
ecraig12345
approved these changes
Mar 16, 2022
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1070 | 1048 | 5000 | |
| Button | mount | 644 | 616 | 5000 | |
| FluentProvider | mount | 2100 | 2083 | 5000 | |
| FluentProviderWithTheme | mount | 303 | 310 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 254 | 272 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 348 | 336 | 10 | |
| MakeStyles | mount | 1853 | 1867 | 50000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
react-badgehasexport * from ...insrc/index.ts.New Behavior
react-badgehas explicitly named exports insrc/index.ts.Related Issue(s)
#22099