Remove star exports from react-spinbutton#22102
Merged
spmonahan merged 2 commits intomicrosoft:masterfrom Mar 17, 2022
Merged
Conversation
73 tasks
Collaborator
📊 Bundle size report🤖 This report was generated against dff926519f57df390afefee4351fc488bc7c4569 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d5535e:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 477b45728732361e02047be15de5113d1e6d01ac (build) |
khmakoto
reviewed
Mar 15, 2022
Hotell
reviewed
Mar 16, 2022
Removes star exports from src/index.ts in the react-spinbutton package. See: microsoft#22099
4413447 to
0d5535e
Compare
khmakoto
approved these changes
Mar 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
react-spinbuttonhasexport * from ...insrc/index.ts.New Behavior
react-spinbuttonhas explicitly named exports insrc/index.ts.Related Issue(s)
#22099