Skip to content

feat(eslint-plugin): enable no-export-all:all for all packages public… #22073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hotell merged 4 commits into from
Mar 15, 2022
+15 −0
Merged

feat(eslint-plugin): enable no-export-all:all for all packages public… #22073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d92fcb6
feat(eslint-plugin): enable no-export-all:all for all packages public…
Hotell Mar 11, 2022
403b7dc
Change files
Hotell Mar 11, 2022
d234e61
temporarily override export start lint rule so it still errors
Hotell Mar 11, 2022
4bb197e
Update change/@fluentui-eslint-plugin-4067e75c-636a-4ca2-a360-3d1e3e4…
Hotell Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-eslint-plugin-4067e75c-636a-4ca2-a360-3d1e3e43a9bb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "feat(eslint-plugin): enable no-export-all:all for all packages public API",
"packageName": "@fluentui/eslint-plugin",
"email": "martinhochel@microsoft.com",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions packages/eslint-plugin/src/configs/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,13 @@ const typeAwareRules = {
const getOverrides = () => [
// Enable rules requiring type info only for appropriate files/circumstances
...configHelpers.getTypeInfoRuleOverrides(typeAwareRules),
{
files: '**/src/index.{ts,tsx,js}',
rules: {
// TODO: propagate to `error` once all packages barrel files have been fixed
'@rnx-kit/no-export-all': ['warn', { expand: 'all' }],
},
},
{
files: '**/*.{ts,tsx}',
// This turns off a few rules that don't work or are unnecessary for TS, and enables a few
Expand Down
1 change: 1 addition & 0 deletions packages/react-components/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
{
"files": "**/index.ts",
"rules": {
"@rnx-kit/no-export-all": ["error", { "expand": "all" }],
"@fluentui/ban-imports": [
"error",
{
Expand Down