feat(eslint-plugin): enable no-export-all:all for all packages public…#22073
Merged
Hotell merged 4 commits intomicrosoft:masterfrom Mar 15, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4bb197e:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1015 | 1085 | 5000 | |
| Button | mount | 661 | 663 | 5000 | |
| FluentProvider | mount | 2119 | 2113 | 5000 | |
| FluentProviderWithTheme | mount | 307 | 317 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 259 | 275 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 364 | 342 | 10 | |
| MakeStyles | mount | 1804 | 1840 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9e1c2c15517bad89b33c61729fb56f4c95739ca2 (build) |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| DividerMinimalPerf.default | 308 | 264 | 1.17:1 |
| DialogMinimalPerf.default | 656 | 582 | 1.13:1 |
| AccordionMinimalPerf.default | 138 | 126 | 1.1:1 |
| DropdownMinimalPerf.default | 2759 | 2535 | 1.09:1 |
| LayoutMinimalPerf.default | 324 | 299 | 1.08:1 |
| AttachmentMinimalPerf.default | 144 | 135 | 1.07:1 |
| ItemLayoutMinimalPerf.default | 1013 | 944 | 1.07:1 |
| PortalMinimalPerf.default | 160 | 150 | 1.07:1 |
| AttachmentSlotsPerf.default | 869 | 823 | 1.06:1 |
| ListCommonPerf.default | 536 | 505 | 1.06:1 |
| ListMinimalPerf.default | 437 | 412 | 1.06:1 |
| RosterPerf.default | 957 | 907 | 1.06:1 |
| ChatDuplicateMessagesPerf.default | 262 | 250 | 1.05:1 |
| FlexMinimalPerf.default | 255 | 243 | 1.05:1 |
| SkeletonMinimalPerf.default | 300 | 286 | 1.05:1 |
| AvatarMinimalPerf.default | 156 | 150 | 1.04:1 |
| CarouselMinimalPerf.default | 403 | 386 | 1.04:1 |
| HeaderMinimalPerf.default | 320 | 309 | 1.04:1 |
| ListNestedPerf.default | 487 | 469 | 1.04:1 |
| ListWith60ListItems.default | 568 | 550 | 1.03:1 |
| TextMinimalPerf.default | 300 | 290 | 1.03:1 |
| VideoMinimalPerf.default | 566 | 550 | 1.03:1 |
| BoxMinimalPerf.default | 299 | 294 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1416 | 1395 | 1.02:1 |
| ChatWithPopoverPerf.default | 345 | 339 | 1.02:1 |
| FormMinimalPerf.default | 345 | 338 | 1.02:1 |
| TableMinimalPerf.default | 351 | 343 | 1.02:1 |
| TooltipMinimalPerf.default | 872 | 857 | 1.02:1 |
| AlertMinimalPerf.default | 239 | 236 | 1.01:1 |
| ButtonMinimalPerf.default | 146 | 144 | 1.01:1 |
| InputMinimalPerf.default | 1102 | 1096 | 1.01:1 |
| LabelMinimalPerf.default | 330 | 328 | 1.01:1 |
| LoaderMinimalPerf.default | 583 | 578 | 1.01:1 |
| MenuMinimalPerf.default | 728 | 723 | 1.01:1 |
| PopupMinimalPerf.default | 543 | 536 | 1.01:1 |
| RefMinimalPerf.default | 208 | 206 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3695 | 3646 | 1.01:1 |
| CustomToolbarPrototype.default | 3514 | 3492 | 1.01:1 |
| ButtonSlotsPerf.default | 469 | 468 | 1:1 |
| EmbedMinimalPerf.default | 3489 | 3504 | 1:1 |
| HeaderSlotsPerf.default | 638 | 639 | 1:1 |
| ImageMinimalPerf.default | 327 | 326 | 1:1 |
| MenuButtonMinimalPerf.default | 1438 | 1432 | 1:1 |
| ProviderMergeThemesPerf.default | 1478 | 1478 | 1:1 |
| SegmentMinimalPerf.default | 300 | 299 | 1:1 |
| SliderMinimalPerf.default | 1432 | 1428 | 1:1 |
| IconMinimalPerf.default | 517 | 517 | 1:1 |
| TableManyItemsPerf.default | 1615 | 1607 | 1:1 |
| CardMinimalPerf.default | 469 | 473 | 0.99:1 |
| ChatMinimalPerf.default | 621 | 628 | 0.99:1 |
| GridMinimalPerf.default | 286 | 290 | 0.99:1 |
| ProviderMinimalPerf.default | 962 | 974 | 0.99:1 |
| RadioGroupMinimalPerf.default | 368 | 371 | 0.99:1 |
| ReactionMinimalPerf.default | 318 | 320 | 0.99:1 |
| TreeMinimalPerf.default | 680 | 686 | 0.99:1 |
| TreeWith60ListItems.default | 154 | 156 | 0.99:1 |
| AnimationMinimalPerf.default | 457 | 464 | 0.98:1 |
| CheckboxMinimalPerf.default | 2206 | 2254 | 0.98:1 |
| DatepickerMinimalPerf.default | 4762 | 4840 | 0.98:1 |
| StatusMinimalPerf.default | 558 | 567 | 0.98:1 |
| TextAreaMinimalPerf.default | 403 | 410 | 0.98:1 |
| DropdownManyItemsPerf.default | 584 | 1490 | 0.39:1 |
| ToolbarMinimalPerf.default | 754 | 2463 | 0.31:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 905 | 918 | 5000 | |
| Breadcrumb | mount | 2603 | 2626 | 1000 | |
| Checkbox | mount | 1443 | 1465 | 5000 | |
| CheckboxBase | mount | 1239 | 1249 | 5000 | |
| ChoiceGroup | mount | 4667 | 4679 | 5000 | |
| ComboBox | mount | 976 | 963 | 1000 | |
| CommandBar | mount | 10157 | 10185 | 1000 | |
| ContextualMenu | mount | 11373 | 11461 | 1000 | |
| DefaultButton | mount | 1139 | 1122 | 5000 | |
| DetailsRow | mount | 3729 | 3761 | 5000 | |
| DetailsRowFast | mount | 3750 | 3806 | 5000 | |
| DetailsRowNoStyles | mount | 3458 | 3537 | 5000 | |
| Dialog | mount | 2214 | 2133 | 1000 | |
| DocumentCardTitle | mount | 163 | 154 | 1000 | |
| Dropdown | mount | 3253 | 3267 | 5000 | |
| FocusTrapZone | mount | 1769 | 1791 | 5000 | |
| FocusZone | mount | 1751 | 1803 | 5000 | |
| IconButton | mount | 1705 | 1728 | 5000 | |
| Label | mount | 341 | 352 | 5000 | |
| Layer | mount | 2884 | 2847 | 5000 | |
| Link | mount | 451 | 463 | 5000 | |
| MenuButton | mount | 1458 | 1476 | 5000 | |
| MessageBar | mount | 2104 | 2108 | 5000 | |
| Nav | mount | 3246 | 3286 | 1000 | |
| OverflowSet | mount | 1098 | 1108 | 5000 | |
| Panel | mount | 2158 | 2141 | 1000 | |
| Persona | mount | 825 | 841 | 1000 | |
| Pivot | mount | 1475 | 1457 | 1000 | |
| PrimaryButton | mount | 1292 | 1283 | 5000 | |
| Rating | mount | 7601 | 7478 | 5000 | |
| SearchBox | mount | 1279 | 1296 | 5000 | |
| Shimmer | mount | 2448 | 2427 | 5000 | |
| Slider | mount | 1891 | 1925 | 5000 | |
| SpinButton | mount | 4910 | 4978 | 5000 | |
| Spinner | mount | 419 | 423 | 5000 | |
| SplitButton | mount | 3069 | 3123 | 5000 | |
| Stack | mount | 526 | 518 | 5000 | |
| StackWithIntrinsicChildren | mount | 2295 | 2261 | 5000 | |
| StackWithTextChildren | mount | 5202 | 5178 | 5000 | |
| SwatchColorPicker | mount | 11409 | 11534 | 5000 | |
| TagPicker | mount | 2673 | 2661 | 5000 | |
| TeachingBubble | mount | 92028 | 91411 | 5000 | |
| Text | mount | 428 | 423 | 5000 | |
| TextField | mount | 1388 | 1370 | 5000 | |
| ThemeProvider | mount | 1178 | 1182 | 5000 | |
| ThemeProvider | virtual-rerender | 638 | 645 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1805 | 1841 | 5000 | |
| Toggle | mount | 776 | 769 | 5000 | |
| buttonNative | mount | 116 | 122 | 5000 |
spmonahan
approved these changes
Mar 11, 2022
ling1726
approved these changes
Mar 11, 2022
TristanWatanabe
approved these changes
Mar 11, 2022
ecraig12345
reviewed
Mar 14, 2022
change/@fluentui-eslint-plugin-4067e75c-636a-4ca2-a360-3d1e3e43a9bb.json
Outdated
Show resolved
Hide resolved
…3a9bb.json Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
73 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… API
Current Behavior
export * fromfor internal modulesexport * fromis dissallowed for external packages only for dedups/tree shake-ability reasonsNew Behavior
export *for all public API'sreact-componentsalthough only for "external" dependencies - THIS PR adds check for internal ones ✅To recap new functionality:
export *for external packages is dissallowed in every moduleexport *v9-package-public-api.mov
Related Issue(s)
Follows #22046
Remarks
warn, after we fix all v9 packages gradually it will be propagated toerror