chore: remove inline-style-expand-shorthand from all tsconfigs by layershifter · Pull Request #21246 · microsoft/fluentui

layershifter · 2022-01-11T15:50:56Z

Fixes #20927.

removes custom typings for inline-style-expand-shorthand
updates generator to not include inline-style-expand-shorthand into typings
removes inline-style-expand-shorthand from all tsconfig.json files

codesandbox-ci · 2022-01-11T15:56:37Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3d3d450:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-01-11T16:03:43Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-accordion` Accordion (including children components)	`54.446 kB` `17.354 kB`
`react-avatar` Avatar	`43.793 kB` `12.486 kB`
`react-badge` Badge	`23.702 kB` `7.008 kB`
`react-badge` CounterBadge	`24.57 kB` `7.308 kB`
`react-badge` PresenceBadge	`22.209 kB` `6.524 kB`
`react-button` Button	`28.16 kB` `8.088 kB`
`react-button` CompoundButton	`33.495 kB` `9.06 kB`
`react-button` MenuButton	`29.901 kB` `8.701 kB`
`react-button` SplitButton	`36.048 kB` `9.774 kB`
`react-button` ToggleButton	`37.397 kB` `8.682 kB`
`react-card` Card - All	`48.473 kB` `14.375 kB`
`react-card` Card	`43.871 kB` `13.166 kB`
`react-card` CardFooter	`7.587 kB` `3.227 kB`
`react-card` CardHeader	`8.895 kB` `3.675 kB`
`react-card` CardPreview	`7.778 kB` `3.355 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`166.224 kB` `47.08 kB`
`react-components` react-components: FluentProvider & webLightTheme	`32.184 kB` `10.58 kB`
`react-divider` Divider	`14.924 kB` `5.39 kB`
`react-image` Image	`10.035 kB` `3.941 kB`
`react-input` Input	`21.568 kB` `7.134 kB`
`react-label` Label	`8.294 kB` `3.472 kB`
`react-link` Link	`11.028 kB` `4.487 kB`
`react-make-styles` makeStaticStyles (runtime)	`7.602 kB` `3.325 kB`
`react-make-styles` makeStyles + mergeClasses (runtime)	`19.352 kB` `7.364 kB`
`react-make-styles` makeStyles + mergeClasses (build time)	`2.689 kB` `1.23 kB`
`react-menu` Menu (including children components)	`102.431 kB` `31.573 kB`
`react-menu` Menu (including selectable components)	`104.688 kB` `31.932 kB`
`react-popover` Popover	`95.361 kB` `29.028 kB`
`react-portal` Portal	`6.249 kB` `2.163 kB`
`react-positioning` usePopper	`22.808 kB` `7.935 kB`
`react-provider` FluentProvider	`13.687 kB` `5.174 kB`
`react-slider` Slider	`21.928 kB` `7.502 kB`
`react-switch` Switch	`25.334 kB` `8.188 kB`
`react-text` Text - Default	`10.716 kB` `4.213 kB`
`react-text` Text - Wrappers	`14.018 kB` `4.555 kB`
`react-theme` Teams: all themes	`29.344 kB` `6.55 kB`
`react-theme` Teams: Light theme	`18.4 kB` `5.273 kB`
`react-tooltip` Tooltip	`45.075 kB` `15.642 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against d5c180271f9d9b6752a8406f4c8ec8b17368e66d}

size-auditor · 2022-01-11T16:09:26Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d5c180271f9d9b6752a8406f4c8ec8b17368e66d (build)

fabricteam · 2022-01-11T16:32:13Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1032	1030	5000
BaseButton	mount	1058	1071	5000
Breadcrumb	mount	2797	2789	1000
ButtonNext	mount	613	601	5000
Checkbox	mount	1749	1755	5000
CheckboxBase	mount	1531	1534	5000
ChoiceGroup	mount	5464	5365	5000
ComboBox	mount	1126	1071	1000
CommandBar	mount	10888	10821	1000
ContextualMenu	mount	9036	9024	1000
DefaultButton	mount	1328	1331	5000
DetailsRow	mount	4219	4201	5000
DetailsRowFast	mount	4179	4183	5000
DetailsRowNoStyles	mount	4030	4013	5000
Dialog	mount	2690	2738	1000
DocumentCardTitle	mount	211	211	1000
Dropdown	mount	3558	3571	5000
FluentProviderNext	mount	1856	1822	5000
FluentProviderWithTheme	mount	163	194	10
FluentProviderWithTheme	virtual-rerender	117	135	10
FluentProviderWithTheme	virtual-rerender-with-unmount	198	214	10
FocusTrapZone	mount	1983	1955	5000
FocusZone	mount	1960	2050	5000
IconButton	mount	2066	2034	5000
Label	mount	424	425	5000
Layer	mount	3274	3218	5000
Link	mount	564	570	5000
MakeStyles	mount	1956	1996	50000
MenuButton	mount	1692	1691	5000
MessageBar	mount	2181	2174	5000
Nav	mount	3726	3685	1000
OverflowSet	mount	1234	1218	5000
Panel	mount	2629	2642	1000
Persona	mount	935	951	1000
Pivot	mount	1651	1609	1000
PrimaryButton	mount	1535	1482	5000
Rating	mount	9028	8793	5000
SearchBox	mount	1560	1565	5000
Shimmer	mount	2898	2917	5000
Slider	mount	2181	2202	5000
SpinButton	mount	5528	5490	5000
Spinner	mount	499	511	5000
SplitButton	mount	3569	3586	5000
Stack	mount	604	630	5000
StackWithIntrinsicChildren	mount	2859	2829	5000
StackWithTextChildren	mount	6167	6114	5000
SwatchColorPicker	mount	12719	12768	5000
TagPicker	mount	2974	3018	5000
TeachingBubble	mount	13794	13796	5000
Text	mount	505	510	5000
TextField	mount	1572	1610	5000
ThemeProvider	mount	1276	1294	5000
ThemeProvider	virtual-rerender	670	660	5000
ThemeProvider	virtual-rerender-with-unmount	2191	2191	5000
Toggle	mount	938	942	5000
buttonNative	mount	167	177	5000

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	229	200	1.15:1
HeaderMinimalPerf.default	444	411	1.08:1
ImageMinimalPerf.default	462	433	1.07:1
AlertMinimalPerf.default	328	310	1.06:1
ListNestedPerf.default	670	635	1.06:1
ChatMinimalPerf.default	876	838	1.05:1
FlexMinimalPerf.default	338	322	1.05:1
SegmentMinimalPerf.default	415	394	1.05:1
TooltipMinimalPerf.default	1223	1163	1.05:1
TreeMinimalPerf.default	919	875	1.05:1
BoxMinimalPerf.default	410	393	1.04:1
ListWith60ListItems.default	741	713	1.04:1
PopupMinimalPerf.default	683	657	1.04:1
SkeletonMinimalPerf.default	418	401	1.04:1
TextAreaMinimalPerf.default	644	622	1.04:1
AnimationMinimalPerf.default	623	605	1.03:1
CarouselMinimalPerf.default	549	534	1.03:1
DropdownManyItemsPerf.default	798	777	1.03:1
DropdownMinimalPerf.default	3262	3165	1.03:1
FormMinimalPerf.default	505	492	1.03:1
LoaderMinimalPerf.default	767	747	1.03:1
RadioGroupMinimalPerf.default	552	538	1.03:1
RefMinimalPerf.default	269	261	1.03:1
TableMinimalPerf.default	483	470	1.03:1
TextMinimalPerf.default	426	414	1.03:1
ButtonOverridesMissPerf.default	1913	1884	1.02:1
CardMinimalPerf.default	668	652	1.02:1
ChatWithPopoverPerf.default	437	428	1.02:1
GridMinimalPerf.default	411	404	1.02:1
SliderMinimalPerf.default	1875	1832	1.02:1
StatusMinimalPerf.default	799	787	1.02:1
AttachmentMinimalPerf.default	182	181	1.01:1
AvatarMinimalPerf.default	236	233	1.01:1
ButtonSlotsPerf.default	646	640	1.01:1
CheckboxMinimalPerf.default	2957	2922	1.01:1
DialogMinimalPerf.default	848	841	1.01:1
DividerMinimalPerf.default	438	434	1.01:1
EmbedMinimalPerf.default	4589	4551	1.01:1
LayoutMinimalPerf.default	421	417	1.01:1
MenuMinimalPerf.default	960	951	1.01:1
PortalMinimalPerf.default	195	193	1.01:1
SplitButtonMinimalPerf.default	4872	4822	1.01:1
CustomToolbarPrototype.default	4504	4463	1.01:1
ToolbarMinimalPerf.default	1089	1075	1.01:1
VideoMinimalPerf.default	761	751	1.01:1
HeaderSlotsPerf.default	880	876	1:1
LabelMinimalPerf.default	464	466	1:1
IconMinimalPerf.default	731	734	1:1
ButtonMinimalPerf.default	208	211	0.99:1
ChatDuplicateMessagesPerf.default	344	349	0.99:1
DatepickerMinimalPerf.default	6071	6145	0.99:1
MenuButtonMinimalPerf.default	1833	1854	0.99:1
ProviderMinimalPerf.default	1285	1296	0.99:1
TableManyItemsPerf.default	2214	2232	0.99:1
InputMinimalPerf.default	1386	1416	0.98:1
ItemLayoutMinimalPerf.default	1357	1384	0.98:1
ListMinimalPerf.default	591	602	0.98:1
ProviderMergeThemesPerf.default	1812	1842	0.98:1
AttachmentSlotsPerf.default	1189	1222	0.97:1
RosterPerf.default	1341	1376	0.97:1
AccordionMinimalPerf.default	180	189	0.95:1
ListCommonPerf.default	717	754	0.95:1
ReactionMinimalPerf.default	430	455	0.95:1

Hotell

🙌 flawless victory

layershifter added 2 commits January 11, 2022 16:47

chore: remove inline-style-expand-shorthand from all tsconfigs

576dab4

Change files

3d3d450

layershifter added Area: Build System Fluent UI react-components (v9) labels Jan 11, 2022

msft-fluent-ui-bot assigned spmonahan Jan 11, 2022

layershifter marked this pull request as ready for review January 11, 2022 16:26

layershifter requested review from a team, GeoffCoxMSFT, behowell, czearing, dzearing, ecraig12345 and khmakoto as code owners January 11, 2022 16:26

layershifter requested a review from smhigley January 11, 2022 16:26

ecraig12345 approved these changes Jan 11, 2022

View reviewed changes

Hotell approved these changes Jan 12, 2022

View reviewed changes

behowell approved these changes Jan 18, 2022

View reviewed changes

ling1726 approved these changes Jan 19, 2022

View reviewed changes

layershifter merged commit c061e98 into microsoft:master Jan 19, 2022

layershifter deleted the chore/remove-inline-style-shorthand branch January 19, 2022 08:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove inline-style-expand-shorthand from all tsconfigs#21246

chore: remove inline-style-expand-shorthand from all tsconfigs#21246
layershifter merged 2 commits intomicrosoft:masterfrom
layershifter:chore/remove-inline-style-shorthand

layershifter commented Jan 11, 2022

Uh oh!

codesandbox-ci bot commented Jan 11, 2022

Uh oh!

fabricteam commented Jan 11, 2022

Uh oh!

size-auditor bot commented Jan 11, 2022

Uh oh!

fabricteam commented Jan 11, 2022

Uh oh!

Hotell left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

layershifter commented Jan 11, 2022

Uh oh!

codesandbox-ci bot commented Jan 11, 2022

Uh oh!

fabricteam commented Jan 11, 2022

📊 Bundle size report

Uh oh!

size-auditor bot commented Jan 11, 2022

Asset size changes

Uh oh!

fabricteam commented Jan 11, 2022

Perf Analysis (@fluentui/react)

Perf Analysis (@fluentui/react-northstar)

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Perf Analysis (`@fluentui/react`)

Perf Analysis (`@fluentui/react-northstar`)