Skip to content

chore(react-portal): use simplified prop merging#19751

Merged
layershifter merged 2 commits intomasterfrom
chore/portal-simpfilied-props
Sep 10, 2021
Merged

chore(react-portal): use simplified prop merging#19751
layershifter merged 2 commits intomasterfrom
chore/portal-simpfilied-props

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Sep 10, 2021

Pull request checklist

Description of changes

Modifies FluentProvider to use simplified prop merging.

@layershifter layershifter requested a review from a team as a code owner September 10, 2021 10:59
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 10, 2021

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 164.241 kB
46.857 kB		 164.286 kB
46.872 kB		 -45 B
-15 B
react-menu
Menu (including children components)		 102.088 kB
31.069 kB		 102.963 kB
31.313 kB		 -875 B
-244 B
react-menu
Menu (including selectable components)		 104.364 kB
31.418 kB		 105.239 kB
31.665 kB		 -875 B
-247 B
react-popover
Popover		 100.556 kB
30.12 kB		 100.6 kB
30.131 kB		 -44 B
-11 B
react-portal
Portal		 5.67 kB
1.802 kB		 6.725 kB
2.237 kB		 -1.055 kB
-435 B
react-tooltip
Tooltip		 46.004 kB
15.652 kB		 46.029 kB
15.655 kB		 -25 B
-3 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-button
Button		 22.932 kB
6.984 kB
react-button
CompoundButton		 28.215 kB
7.834 kB
react-button
MenuButton		 24.733 kB
7.546 kB
react-button
ToggleButton		 32.527 kB
7.601 kB
react-components
react-components: FluentProvider & webLightTheme		 36.258 kB
11.596 kB
🤖 This report was generated against 5cb8d464bbe2ed123883d8c3f7aa19f9e150b30d

@size-auditor
Copy link

size-auditor bot commented Sep 10, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5cb8d464bbe2ed123883d8c3f7aa19f9e150b30d (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b5948f1:

Sandbox Source
Fluent UI React Starter Configuration

@layershifter layershifter enabled auto-merge (squash) September 10, 2021 11:11
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 10, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 930 919 5000
BaseButton mount 895 899 5000
Breadcrumb mount 2677 2661 1000
ButtonNext mount 442 437 5000
Checkbox mount 1559 1537 5000
CheckboxBase mount 1282 1349 5000
ChoiceGroup mount 4835 4769 5000
ComboBox mount 982 1019 1000
CommandBar mount 10474 10349 1000
ContextualMenu mount 6564 6634 1000
DefaultButton mount 1125 1119 5000
DetailsRow mount 3759 3798 5000
DetailsRowFast mount 3784 3736 5000
DetailsRowNoStyles mount 3537 3547 5000
Dialog mount 2496 2444 1000
DocumentCardTitle mount 156 153 1000
Dropdown mount 3263 3298 5000
FluentProviderNext mount 7584 7548 5000
FluentProviderWithTheme mount 372 370 10
FluentProviderWithTheme virtual-rerender 86 101 10
FluentProviderWithTheme virtual-rerender-with-unmount 484 494 10
FocusTrapZone mount 1843 1830 5000
FocusZone mount 1838 1852 5000
IconButton mount 1762 1752 5000
Label mount 352 366 5000
Layer mount 3100 2969 5000
Link mount 473 471 5000
MakeStyles mount 1810 1817 50000
MenuButton mount 1483 1455 5000
MessageBar mount 2026 2026 5000
Nav mount 3279 3296 1000
OverflowSet mount 1099 1131 5000
Panel mount 2364 2424 1000
Persona mount 845 830 1000
Pivot mount 1402 1470 1000
PrimaryButton mount 1270 1293 5000
Rating mount 7757 7701 5000
SearchBox mount 1360 1311 5000
Shimmer mount 2547 2636 5000
Slider mount 1980 1963 5000
SpinButton mount 5096 5076 5000
Spinner mount 421 421 5000
SplitButton mount 3172 3214 5000
Stack mount 507 506 5000
StackWithIntrinsicChildren mount 1612 1625 5000
StackWithTextChildren mount 4607 4637 5000
SwatchColorPicker mount 10545 10548 5000
Tabs mount 1462 1421 1000
TagPicker mount 2676 2664 5000
TeachingBubble mount 13414 13408 5000
Text mount 414 416 5000
TextField mount 1408 1359 5000
ThemeProvider mount 1219 1207 5000
ThemeProvider virtual-rerender 597 613 5000
ThemeProvider virtual-rerender-with-unmount 1891 1877 5000
Toggle mount 816 806 5000
buttonNative mount 114 127 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AlertMinimalPerf.default 269 274 0.98:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 315 281 1.12:1
ChatDuplicateMessagesPerf.default 315 285 1.11:1
AvatarMinimalPerf.default 201 188 1.07:1
BoxMinimalPerf.default 359 335 1.07:1
DropdownManyItemsPerf.default 703 660 1.07:1
LoaderMinimalPerf.default 735 685 1.07:1
RefMinimalPerf.default 249 233 1.07:1
SkeletonMinimalPerf.default 374 348 1.07:1
HeaderMinimalPerf.default 373 355 1.05:1
ImageMinimalPerf.default 371 353 1.05:1
TreeWith60ListItems.default 179 170 1.05:1
AttachmentMinimalPerf.default 166 159 1.04:1
DialogMinimalPerf.default 789 764 1.03:1
FormMinimalPerf.default 397 386 1.03:1
MenuMinimalPerf.default 879 850 1.03:1
RadioGroupMinimalPerf.default 449 435 1.03:1
TableMinimalPerf.default 407 397 1.03:1
TextAreaMinimalPerf.default 495 481 1.03:1
ToolbarMinimalPerf.default 949 921 1.03:1
AnimationMinimalPerf.default 410 400 1.02:1
AttachmentSlotsPerf.default 1085 1061 1.02:1
ButtonMinimalPerf.default 178 174 1.02:1
ButtonSlotsPerf.default 571 559 1.02:1
PortalMinimalPerf.default 184 181 1.02:1
TextMinimalPerf.default 346 338 1.02:1
AccordionMinimalPerf.default 149 148 1.01:1
CarouselMinimalPerf.default 462 459 1.01:1
ChatWithPopoverPerf.default 358 353 1.01:1
DatepickerMinimalPerf.default 5550 5503 1.01:1
LayoutMinimalPerf.default 365 362 1.01:1
ListMinimalPerf.default 508 505 1.01:1
SegmentMinimalPerf.default 353 349 1.01:1
SplitButtonMinimalPerf.default 4236 4179 1.01:1
IconMinimalPerf.default 614 608 1.01:1
CheckboxMinimalPerf.default 2795 2808 1:1
DividerMinimalPerf.default 367 368 1:1
DropdownMinimalPerf.default 3181 3167 1:1
EmbedMinimalPerf.default 4232 4237 1:1
GridMinimalPerf.default 339 340 1:1
HeaderSlotsPerf.default 753 752 1:1
LabelMinimalPerf.default 394 393 1:1
SliderMinimalPerf.default 1661 1668 1:1
CustomToolbarPrototype.default 4042 4051 1:1
TooltipMinimalPerf.default 1044 1039 1:1
VideoMinimalPerf.default 643 644 1:1
InputMinimalPerf.default 1304 1311 0.99:1
ListNestedPerf.default 561 564 0.99:1
MenuButtonMinimalPerf.default 1637 1657 0.99:1
ProviderMergeThemesPerf.default 1718 1730 0.99:1
ReactionMinimalPerf.default 372 375 0.99:1
ButtonOverridesMissPerf.default 1751 1787 0.98:1
ChatMinimalPerf.default 642 655 0.98:1
PopupMinimalPerf.default 586 596 0.98:1
TableManyItemsPerf.default 1853 1889 0.98:1
ItemLayoutMinimalPerf.default 1193 1224 0.97:1
CardMinimalPerf.default 542 562 0.96:1
ListWith60ListItems.default 632 660 0.96:1
ProviderMinimalPerf.default 1061 1101 0.96:1
ListCommonPerf.default 617 647 0.95:1
RosterPerf.default 1148 1205 0.95:1
StatusMinimalPerf.default 652 686 0.95:1
TreeMinimalPerf.default 772 811 0.95:1

@layershifter layershifter merged commit 7a242cc into master Sep 10, 2021
@layershifter layershifter deleted the chore/portal-simpfilied-props branch November 8, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Fluent UI react-components (v9)

Projects

None yet

Milestone

September Project Cycle Q3 2021

Development

Successfully merging this pull request may close these issues.

@fluentui/react-portal: use simplified prop merging

3 participants

@layershifter @fabricteam @ling1726