Migrate react-input to new DX and create Input from template#18781
Merged
ecraig12345 merged 4 commits intomicrosoft:masterfrom Jun 30, 2021
Merged
Migrate react-input to new DX and create Input from template#18781ecraig12345 merged 4 commits intomicrosoft:masterfrom
ecraig12345 merged 4 commits intomicrosoft:masterfrom
Conversation
32 tasks
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c7eff2580a6fe159bbb3c4e77e549925187f3150 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 50b9a1b:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 806 | 824 | 5000 | |
| BaseButton | mount | 890 | 911 | 5000 | |
| Breadcrumb | mount | 2744 | 2679 | 1000 | |
| ButtonNext | mount | 541 | 533 | 5000 | |
| Checkbox | mount | 1499 | 1570 | 5000 | |
| CheckboxBase | mount | 1306 | 1284 | 5000 | |
| ChoiceGroup | mount | 4790 | 4770 | 5000 | |
| ComboBox | mount | 970 | 990 | 1000 | |
| CommandBar | mount | 10366 | 10326 | 1000 | |
| ContextualMenu | mount | 6400 | 6440 | 1000 | |
| DefaultButton | mount | 1098 | 1108 | 5000 | |
| DetailsRow | mount | 3789 | 3798 | 5000 | |
| DetailsRowFast | mount | 3704 | 3801 | 5000 | |
| DetailsRowNoStyles | mount | 3571 | 3535 | 5000 | |
| Dialog | mount | 2183 | 2164 | 1000 | |
| DocumentCardTitle | mount | 138 | 154 | 1000 | |
| Dropdown | mount | 3297 | 3278 | 5000 | |
| FluentProviderNext | mount | 7396 | 7423 | 5000 | |
| FocusTrapZone | mount | 1815 | 1837 | 5000 | |
| FocusZone | mount | 1836 | 1769 | 5000 | |
| IconButton | mount | 1755 | 1743 | 5000 | |
| Label | mount | 333 | 337 | 5000 | |
| Layer | mount | 1748 | 1779 | 5000 | |
| Link | mount | 465 | 472 | 5000 | |
| MakeStyles | mount | 1822 | 1827 | 50000 | |
| MenuButton | mount | 1448 | 1472 | 5000 | |
| MessageBar | mount | 2056 | 2018 | 5000 | |
| Nav | mount | 3250 | 3364 | 1000 | |
| OverflowSet | mount | 1041 | 1039 | 5000 | |
| Panel | mount | 2126 | 2083 | 1000 | |
| Persona | mount | 818 | 817 | 1000 | |
| Pivot | mount | 1452 | 1460 | 1000 | |
| PrimaryButton | mount | 1321 | 1284 | 5000 | |
| Rating | mount | 7703 | 7609 | 5000 | |
| SearchBox | mount | 1348 | 1335 | 5000 | |
| Shimmer | mount | 2538 | 2531 | 5000 | |
| Slider | mount | 1960 | 1965 | 5000 | |
| SpinButton | mount | 5042 | 5020 | 5000 | |
| Spinner | mount | 422 | 430 | 5000 | |
| SplitButton | mount | 3232 | 3179 | 5000 | |
| Stack | mount | 502 | 490 | 5000 | |
| StackWithIntrinsicChildren | mount | 1491 | 1523 | 5000 | |
| StackWithTextChildren | mount | 4588 | 4493 | 5000 | |
| SwatchColorPicker | mount | 10212 | 10212 | 5000 | |
| Tabs | mount | 1419 | 1413 | 1000 | |
| TagPicker | mount | 2454 | 2436 | 5000 | |
| TeachingBubble | mount | 11948 | 11912 | 5000 | |
| Text | mount | 410 | 424 | 5000 | |
| TextField | mount | 1365 | 1405 | 5000 | |
| ThemeProvider | mount | 1182 | 1213 | 5000 | |
| ThemeProvider | virtual-rerender | 626 | 613 | 5000 | |
| Toggle | mount | 821 | 804 | 5000 | |
| buttonNative | mount | 121 | 120 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 184 | 168 | 1.1:1 |
| AttachmentMinimalPerf.default | 159 | 146 | 1.09:1 |
| ChatDuplicateMessagesPerf.default | 311 | 291 | 1.07:1 |
| AnimationMinimalPerf.default | 432 | 407 | 1.06:1 |
| LayoutMinimalPerf.default | 386 | 363 | 1.06:1 |
| RefMinimalPerf.default | 247 | 232 | 1.06:1 |
| ListMinimalPerf.default | 521 | 496 | 1.05:1 |
| GridMinimalPerf.default | 350 | 337 | 1.04:1 |
| ListWith60ListItems.default | 652 | 627 | 1.04:1 |
| SkeletonMinimalPerf.default | 360 | 345 | 1.04:1 |
| LabelMinimalPerf.default | 387 | 377 | 1.03:1 |
| LoaderMinimalPerf.default | 703 | 681 | 1.03:1 |
| RadioGroupMinimalPerf.default | 458 | 446 | 1.03:1 |
| TooltipMinimalPerf.default | 993 | 966 | 1.03:1 |
| ButtonMinimalPerf.default | 169 | 165 | 1.02:1 |
| ChatWithPopoverPerf.default | 369 | 362 | 1.02:1 |
| CheckboxMinimalPerf.default | 2797 | 2755 | 1.02:1 |
| PopupMinimalPerf.default | 585 | 574 | 1.02:1 |
| SliderMinimalPerf.default | 1555 | 1530 | 1.02:1 |
| SplitButtonMinimalPerf.default | 3769 | 3708 | 1.02:1 |
| AttachmentSlotsPerf.default | 1087 | 1080 | 1.01:1 |
| BoxMinimalPerf.default | 346 | 342 | 1.01:1 |
| CarouselMinimalPerf.default | 456 | 450 | 1.01:1 |
| DatepickerMinimalPerf.default | 5606 | 5549 | 1.01:1 |
| DividerMinimalPerf.default | 375 | 371 | 1.01:1 |
| DropdownManyItemsPerf.default | 698 | 689 | 1.01:1 |
| DropdownMinimalPerf.default | 3120 | 3095 | 1.01:1 |
| HeaderMinimalPerf.default | 348 | 343 | 1.01:1 |
| HeaderSlotsPerf.default | 764 | 760 | 1.01:1 |
| ListNestedPerf.default | 560 | 556 | 1.01:1 |
| MenuMinimalPerf.default | 844 | 836 | 1.01:1 |
| IconMinimalPerf.default | 625 | 618 | 1.01:1 |
| TableMinimalPerf.default | 417 | 411 | 1.01:1 |
| CustomToolbarPrototype.default | 3816 | 3793 | 1.01:1 |
| TreeMinimalPerf.default | 805 | 798 | 1.01:1 |
| AvatarMinimalPerf.default | 194 | 194 | 1:1 |
| ButtonOverridesMissPerf.default | 1699 | 1691 | 1:1 |
| CardMinimalPerf.default | 546 | 547 | 1:1 |
| FormMinimalPerf.default | 410 | 409 | 1:1 |
| InputMinimalPerf.default | 1253 | 1251 | 1:1 |
| ItemLayoutMinimalPerf.default | 1221 | 1227 | 1:1 |
| ListCommonPerf.default | 621 | 624 | 1:1 |
| MenuButtonMinimalPerf.default | 1584 | 1591 | 1:1 |
| PortalMinimalPerf.default | 181 | 181 | 1:1 |
| ProviderMergeThemesPerf.default | 1673 | 1681 | 1:1 |
| StatusMinimalPerf.default | 667 | 665 | 1:1 |
| TableManyItemsPerf.default | 1890 | 1882 | 1:1 |
| TextMinimalPerf.default | 349 | 348 | 1:1 |
| VideoMinimalPerf.default | 622 | 619 | 1:1 |
| ButtonSlotsPerf.default | 547 | 552 | 0.99:1 |
| DialogMinimalPerf.default | 767 | 771 | 0.99:1 |
| EmbedMinimalPerf.default | 4103 | 4133 | 0.99:1 |
| ChatMinimalPerf.default | 651 | 663 | 0.98:1 |
| ProviderMinimalPerf.default | 964 | 980 | 0.98:1 |
| TextAreaMinimalPerf.default | 492 | 500 | 0.98:1 |
| AccordionMinimalPerf.default | 155 | 159 | 0.97:1 |
| ImageMinimalPerf.default | 366 | 378 | 0.97:1 |
| RosterPerf.default | 1142 | 1174 | 0.97:1 |
| ReactionMinimalPerf.default | 362 | 372 | 0.97:1 |
| ToolbarMinimalPerf.default | 919 | 944 | 0.97:1 |
| SegmentMinimalPerf.default | 345 | 365 | 0.95:1 |
| FlexMinimalPerf.default | 290 | 307 | 0.94:1 |
| AlertMinimalPerf.default | 250 | 285 | 0.88:1 |
khmakoto
approved these changes
Jun 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
Migrate react-input build.
Create Input component from template (no modifications).
(Doing these things together for expediency because they're both templates/boilerplate, and I'm leaving on vacation next week and would like to get as much done on this as possible before then.)