Skip to content

chore: migrate react-provider to new DX#18745

Merged
layershifter merged 3 commits intomasterfrom
chore/provider-dx
Jun 29, 2021
Merged

chore: migrate react-provider to new DX#18745
layershifter merged 3 commits intomasterfrom
chore/provider-dx

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Jun 28, 2021 •
edited
Loading

Pull request checklist

Description of changes

This PR moves @fluentui/react-provider to new DX. No changes in configs after migration were done.
FluentProvider.stories.tsx was updated to use makeStyles.

@layershifter layershifter mentioned this pull request Jun 28, 2021
Closed
32 tasks
@size-auditor
Copy link

size-auditor bot commented Jun 28, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 804ca93da84e19cec0737729473be5034a2e4939 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 28, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 830 837 5000
BaseButton mount 891 919 5000
Breadcrumb mount 2753 2671 1000
ButtonNext mount 496 528 5000
Checkbox mount 1542 1594 5000
CheckboxBase mount 1298 1295 5000
ChoiceGroup mount 4789 4843 5000
ComboBox mount 1050 975 1000
CommandBar mount 10450 10410 1000
ContextualMenu mount 6312 6359 1000
DefaultButton mount 1126 1143 5000
DetailsRow mount 3846 3859 5000
DetailsRowFast mount 3768 3765 5000
DetailsRowNoStyles mount 3586 3530 5000
Dialog mount 2199 2186 1000
DocumentCardTitle mount 144 137 1000
Dropdown mount 3314 3535 5000
FocusTrapZone mount 1779 1905 5000
FocusZone mount 1855 1843 5000
IconButton mount 1746 1777 5000
Label mount 355 333 5000
Layer mount 1803 1800 5000
Link mount 473 462 5000
MakeStyles mount 1808 1825 50000
MenuButton mount 1426 1528 5000
MessageBar mount 2089 2064 5000
Nav mount 3375 3332 1000
OverflowSet mount 1078 1059 5000
Panel mount 2118 2131 1000
Persona mount 846 812 1000
Pivot mount 1437 1412 1000
PrimaryButton mount 1286 1306 5000
Rating mount 7677 7780 5000
SearchBox mount 1347 1316 5000
Shimmer mount 2519 2645 5000
Slider mount 1967 1974 5000
SpinButton mount 5044 5019 5000
Spinner mount 435 433 5000
SplitButton mount 3201 3245 5000
Stack mount 491 488 5000
StackWithIntrinsicChildren mount 1591 1561 5000
StackWithTextChildren mount 4589 4575 5000
SwatchColorPicker mount 10251 10427 5000
Tabs mount 1404 1438 1000
TagPicker mount 2429 2450 5000
TeachingBubble mount 11945 12037 5000
Text mount 425 435 5000
TextField mount 1332 1383 5000
ThemeProvider mount 1206 1207 5000
ThemeProvider virtual-rerender 596 607 5000
ThemeProviderNext mount 7195 7356 5000
Toggle mount 828 819 5000
buttonNative mount 119 112 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 262 221 1.19:1
PortalMinimalPerf.default 187 168 1.11:1
ButtonMinimalPerf.default 188 171 1.1:1
AvatarMinimalPerf.default 202 186 1.09:1
FlexMinimalPerf.default 312 287 1.09:1
ListCommonPerf.default 680 622 1.09:1
AttachmentMinimalPerf.default 170 161 1.06:1
DividerMinimalPerf.default 374 353 1.06:1
DropdownManyItemsPerf.default 705 668 1.06:1
StatusMinimalPerf.default 711 672 1.06:1
ListMinimalPerf.default 527 504 1.05:1
TreeWith60ListItems.default 187 178 1.05:1
AccordionMinimalPerf.default 163 157 1.04:1
CarouselMinimalPerf.default 460 443 1.04:1
DialogMinimalPerf.default 795 764 1.04:1
HeaderMinimalPerf.default 372 357 1.04:1
ProviderMinimalPerf.default 1067 1033 1.03:1
VideoMinimalPerf.default 630 609 1.03:1
AnimationMinimalPerf.default 426 418 1.02:1
FormMinimalPerf.default 412 402 1.02:1
InputMinimalPerf.default 1306 1281 1.02:1
MenuMinimalPerf.default 868 854 1.02:1
ProviderMergeThemesPerf.default 1765 1733 1.02:1
TooltipMinimalPerf.default 1017 995 1.02:1
CheckboxMinimalPerf.default 2778 2739 1.01:1
ImageMinimalPerf.default 366 363 1.01:1
ItemLayoutMinimalPerf.default 1235 1222 1.01:1
SplitButtonMinimalPerf.default 3809 3787 1.01:1
IconMinimalPerf.default 613 605 1.01:1
TableMinimalPerf.default 418 413 1.01:1
TextMinimalPerf.default 361 358 1.01:1
CustomToolbarPrototype.default 4022 3974 1.01:1
BoxMinimalPerf.default 345 344 1:1
ChatDuplicateMessagesPerf.default 291 291 1:1
ChatWithPopoverPerf.default 368 367 1:1
EmbedMinimalPerf.default 4213 4224 1:1
GridMinimalPerf.default 327 327 1:1
HeaderSlotsPerf.default 786 785 1:1
ListNestedPerf.default 550 550 1:1
MenuButtonMinimalPerf.default 1581 1576 1:1
SliderMinimalPerf.default 1618 1626 1:1
TableManyItemsPerf.default 1907 1915 1:1
AlertMinimalPerf.default 276 278 0.99:1
ButtonOverridesMissPerf.default 1732 1747 0.99:1
ButtonSlotsPerf.default 558 563 0.99:1
DatepickerMinimalPerf.default 5586 5667 0.99:1
DropdownMinimalPerf.default 3153 3178 0.99:1
RadioGroupMinimalPerf.default 438 443 0.99:1
ToolbarMinimalPerf.default 934 948 0.99:1
TreeMinimalPerf.default 788 794 0.99:1
AttachmentSlotsPerf.default 1081 1104 0.98:1
CardMinimalPerf.default 566 580 0.98:1
ChatMinimalPerf.default 661 672 0.98:1
LabelMinimalPerf.default 370 378 0.98:1
LayoutMinimalPerf.default 373 379 0.98:1
SegmentMinimalPerf.default 349 356 0.98:1
TextAreaMinimalPerf.default 505 516 0.98:1
ListWith60ListItems.default 638 658 0.97:1
RosterPerf.default 1152 1191 0.97:1
PopupMinimalPerf.default 578 595 0.97:1
SkeletonMinimalPerf.default 352 364 0.97:1
LoaderMinimalPerf.default 717 747 0.96:1
ReactionMinimalPerf.default 365 386 0.95:1

@layershifter layershifter added Area: Build System Status: Blocked Resolution blocked by another issue labels Jun 28, 2021
@layershifter
Merge branch 'master' of https://github.com/microsoft/fluentui into c…
20b2203 
…hore/provider-dx

� Conflicts:
�	jest.config.js
�	packages/react-examples/package.json
@layershifter layershifter removed the Status: Blocked Resolution blocked by another issue label Jun 29, 2021
@layershifter layershifter marked this pull request as ready for review June 29, 2021 10:39
@layershifter layershifter requested a review from a team as a code owner June 29, 2021 10:39
@layershifter layershifter requested a review from Hotell June 29, 2021 10:40
@layershifter layershifter merged commit 35e244e into master Jun 29, 2021
@layershifter layershifter deleted the chore/provider-dx branch June 29, 2021 11:38
@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 30, 2021

🎉@fluentui/react-examples@v8.33.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell approved these changes

Assignees

@miroslavstastny miroslavstastny

Labels

Area: Build System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@layershifter @fabricteam @msft-fluent-ui-bot @Hotell @miroslavstastny