Removing image dependency from react-examples package#18669
Merged
msft-fluent-ui-bot merged 2 commits intomicrosoft:masterfrom Jun 22, 2021
Merged
Removing image dependency from react-examples package#18669msft-fluent-ui-bot merged 2 commits intomicrosoft:masterfrom
msft-fluent-ui-bot merged 2 commits intomicrosoft:masterfrom
Conversation
ecraig12345
approved these changes
Jun 22, 2021
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 26c0f18f4e14d5820d9d52e867c71dfc3c7bd231 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 817 | 801 | 5000 | |
| BaseButton | mount | 883 | 895 | 5000 | |
| Breadcrumb | mount | 2616 | 2617 | 1000 | |
| ButtonNext | mount | 526 | 515 | 5000 | |
| Checkbox | mount | 1543 | 1509 | 5000 | |
| CheckboxBase | mount | 1240 | 1309 | 5000 | |
| ChoiceGroup | mount | 4597 | 4644 | 5000 | |
| ComboBox | mount | 965 | 980 | 1000 | |
| CommandBar | mount | 10196 | 10127 | 1000 | |
| ContextualMenu | mount | 6317 | 6359 | 1000 | |
| DefaultButton | mount | 1093 | 1118 | 5000 | |
| DetailsRow | mount | 3731 | 3706 | 5000 | |
| DetailsRowFast | mount | 3710 | 3718 | 5000 | |
| DetailsRowNoStyles | mount | 3505 | 3515 | 5000 | |
| Dialog | mount | 2136 | 2116 | 1000 | |
| DocumentCardTitle | mount | 139 | 139 | 1000 | |
| Dropdown | mount | 3231 | 3196 | 5000 | |
| FocusTrapZone | mount | 1785 | 1743 | 5000 | |
| FocusZone | mount | 1791 | 1780 | 5000 | |
| IconButton | mount | 1725 | 1864 | 5000 | |
| Label | mount | 331 | 342 | 5000 | |
| Layer | mount | 1748 | 1793 | 5000 | |
| Link | mount | 467 | 450 | 5000 | |
| MakeStyles | mount | 1848 | 1840 | 50000 | |
| MenuButton | mount | 1458 | 1431 | 5000 | |
| MessageBar | mount | 1960 | 2026 | 5000 | |
| Nav | mount | 3216 | 3182 | 1000 | |
| OverflowSet | mount | 1043 | 1016 | 5000 | |
| Panel | mount | 2116 | 2057 | 1000 | |
| Persona | mount | 797 | 861 | 1000 | |
| Pivot | mount | 1380 | 1415 | 1000 | |
| PrimaryButton | mount | 1288 | 1284 | 5000 | |
| Rating | mount | 7647 | 7520 | 5000 | |
| SearchBox | mount | 1279 | 1296 | 5000 | |
| Shimmer | mount | 2464 | 2541 | 5000 | |
| Slider | mount | 1942 | 1936 | 5000 | |
| SpinButton | mount | 4895 | 5176 | 5000 | |
| Spinner | mount | 418 | 440 | 5000 | |
| SplitButton | mount | 3112 | 3171 | 5000 | |
| Stack | mount | 492 | 485 | 5000 | |
| StackWithIntrinsicChildren | mount | 1575 | 1544 | 5000 | |
| StackWithTextChildren | mount | 4487 | 4466 | 5000 | |
| SwatchColorPicker | mount | 10181 | 10198 | 5000 | |
| Tabs | mount | 1401 | 1395 | 1000 | |
| TagPicker | mount | 2384 | 2355 | 5000 | |
| TeachingBubble | mount | 11898 | 11853 | 5000 | |
| Text | mount | 410 | 429 | 5000 | |
| TextField | mount | 1362 | 1389 | 5000 | |
| ThemeProvider | mount | 1175 | 1155 | 5000 | |
| ThemeProvider | virtual-rerender | 589 | 587 | 5000 | |
| ThemeProviderNext | mount | 7195 | 7093 | 5000 | |
| Toggle | mount | 800 | 798 | 5000 | |
| buttonNative | mount | 114 | 121 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| RefMinimalPerf.default | 252 | 225 | 1.12:1 |
| AttachmentMinimalPerf.default | 167 | 151 | 1.11:1 |
| CardMinimalPerf.default | 574 | 521 | 1.1:1 |
| AnimationMinimalPerf.default | 445 | 410 | 1.09:1 |
| ButtonMinimalPerf.default | 181 | 168 | 1.08:1 |
| TreeWith60ListItems.default | 182 | 168 | 1.08:1 |
| ChatDuplicateMessagesPerf.default | 294 | 276 | 1.07:1 |
| ChatMinimalPerf.default | 631 | 589 | 1.07:1 |
| DropdownManyItemsPerf.default | 715 | 667 | 1.07:1 |
| AccordionMinimalPerf.default | 155 | 146 | 1.06:1 |
| DialogMinimalPerf.default | 784 | 744 | 1.05:1 |
| FlexMinimalPerf.default | 296 | 282 | 1.05:1 |
| ProviderMergeThemesPerf.default | 1728 | 1648 | 1.05:1 |
| ReactionMinimalPerf.default | 383 | 365 | 1.05:1 |
| TreeMinimalPerf.default | 822 | 784 | 1.05:1 |
| InputMinimalPerf.default | 1288 | 1241 | 1.04:1 |
| SegmentMinimalPerf.default | 344 | 331 | 1.04:1 |
| TextAreaMinimalPerf.default | 500 | 482 | 1.04:1 |
| AvatarMinimalPerf.default | 194 | 188 | 1.03:1 |
| BoxMinimalPerf.default | 357 | 348 | 1.03:1 |
| SplitButtonMinimalPerf.default | 3790 | 3695 | 1.03:1 |
| IconMinimalPerf.default | 627 | 609 | 1.03:1 |
| TextMinimalPerf.default | 354 | 343 | 1.03:1 |
| TooltipMinimalPerf.default | 987 | 961 | 1.03:1 |
| ButtonSlotsPerf.default | 546 | 534 | 1.02:1 |
| CheckboxMinimalPerf.default | 2751 | 2693 | 1.02:1 |
| FormMinimalPerf.default | 401 | 392 | 1.02:1 |
| ListMinimalPerf.default | 523 | 512 | 1.02:1 |
| VideoMinimalPerf.default | 623 | 610 | 1.02:1 |
| AttachmentSlotsPerf.default | 1129 | 1122 | 1.01:1 |
| DatepickerMinimalPerf.default | 5423 | 5394 | 1.01:1 |
| EmbedMinimalPerf.default | 4188 | 4137 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 1215 | 1208 | 1.01:1 |
| LayoutMinimalPerf.default | 359 | 356 | 1.01:1 |
| ListCommonPerf.default | 635 | 631 | 1.01:1 |
| ListNestedPerf.default | 560 | 553 | 1.01:1 |
| SkeletonMinimalPerf.default | 339 | 337 | 1.01:1 |
| SliderMinimalPerf.default | 1579 | 1565 | 1.01:1 |
| TableMinimalPerf.default | 399 | 397 | 1.01:1 |
| CustomToolbarPrototype.default | 3910 | 3864 | 1.01:1 |
| AlertMinimalPerf.default | 270 | 270 | 1:1 |
| DropdownMinimalPerf.default | 3071 | 3065 | 1:1 |
| MenuMinimalPerf.default | 829 | 826 | 1:1 |
| StatusMinimalPerf.default | 668 | 668 | 1:1 |
| ButtonOverridesMissPerf.default | 1706 | 1718 | 0.99:1 |
| GridMinimalPerf.default | 332 | 336 | 0.99:1 |
| HeaderSlotsPerf.default | 747 | 758 | 0.99:1 |
| PopupMinimalPerf.default | 577 | 580 | 0.99:1 |
| ProviderMinimalPerf.default | 998 | 1010 | 0.99:1 |
| RadioGroupMinimalPerf.default | 432 | 436 | 0.99:1 |
| TableManyItemsPerf.default | 1867 | 1880 | 0.99:1 |
| HeaderMinimalPerf.default | 363 | 371 | 0.98:1 |
| MenuButtonMinimalPerf.default | 1554 | 1585 | 0.98:1 |
| ChatWithPopoverPerf.default | 358 | 368 | 0.97:1 |
| LabelMinimalPerf.default | 376 | 387 | 0.97:1 |
| PortalMinimalPerf.default | 178 | 183 | 0.97:1 |
| DividerMinimalPerf.default | 350 | 365 | 0.96:1 |
| ListWith60ListItems.default | 613 | 636 | 0.96:1 |
| RosterPerf.default | 1121 | 1163 | 0.96:1 |
| ToolbarMinimalPerf.default | 914 | 955 | 0.96:1 |
| ImageMinimalPerf.default | 357 | 377 | 0.95:1 |
| LoaderMinimalPerf.default | 692 | 732 | 0.95:1 |
| CarouselMinimalPerf.default | 435 | 461 | 0.94:1 |
Member
Author
|
@msft-fluent-ui-bot merge in 1 minute |
Collaborator
|
Hello @khmakoto! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Collaborator
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Removing unused
@fluentui/react-imagedependency from@fluentui/react-examplesthat happened after a bad merge with master in #18614.