Skip to content

fix(build): update target build path in migrate-converged-pkg#18661

Merged
miroslavstastny merged 4 commits intomicrosoft:masterfrom
miroslavstastny:fix/nx-project-path
Jun 22, 2021
Merged

fix(build): update target build path in migrate-converged-pkg#18661
miroslavstastny merged 4 commits intomicrosoft:masterfrom
miroslavstastny:fix/nx-project-path

Conversation

@miroslavstastny
Copy link
Member

@miroslavstastny miroslavstastny commented Jun 22, 2021

Pull request checklist

Description of changes

  • Update build:local output path in migrate-converged-pkg
  • Update build:local output in existing packages
  • Generate api-extractor.json in migrate-converged-pkg

Focus areas to test

(optional)

@miroslavstastny miroslavstastny requested review from a team and bsunderhus as code owners June 22, 2021 13:56
Hotell
Hotell approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thx!

@Hotell Hotell mentioned this pull request Jun 22, 2021
Merged
2 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 22, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 812 795 5000
BaseButton mount 904 910 5000
Breadcrumb mount 2680 2717 1000
ButtonNext mount 530 533 5000
Checkbox mount 1510 1521 5000
CheckboxBase mount 1296 1311 5000
ChoiceGroup mount 4748 4785 5000
ComboBox mount 980 1021 1000
CommandBar mount 10288 10297 1000
ContextualMenu mount 6398 6348 1000
DefaultButton mount 1107 1128 5000
DetailsRow mount 3723 3709 5000
DetailsRowFast mount 3794 3780 5000
DetailsRowNoStyles mount 3569 3507 5000
Dialog mount 2211 2158 1000
DocumentCardTitle mount 150 144 1000
Dropdown mount 3265 3253 5000
FocusTrapZone mount 1800 1829 5000
FocusZone mount 1819 1841 5000
IconButton mount 1735 1766 5000
Label mount 350 332 5000
Layer mount 1787 1779 5000
Link mount 468 458 5000
MakeStyles mount 1830 1839 50000
MenuButton mount 1449 1501 5000
MessageBar mount 2052 1994 5000
Nav mount 3305 3282 1000
OverflowSet mount 1041 1049 5000
Panel mount 1379 2073 1000
Persona mount 842 822 1000
Pivot mount 1413 1404 1000
PrimaryButton mount 1262 1285 5000
Rating mount 7573 7607 5000
SearchBox mount 1287 1340 5000
Shimmer mount 2580 2528 5000
Slider mount 1982 1984 5000
SpinButton mount 5015 5008 5000
Spinner mount 434 430 5000
SplitButton mount 3178 3168 5000
Stack mount 498 488 5000
StackWithIntrinsicChildren mount 1510 1518 5000
StackWithTextChildren mount 4500 4477 5000
SwatchColorPicker mount 10147 10162 5000
Tabs mount 1398 1396 1000
TagPicker mount 2434 2449 5000
TeachingBubble mount 11962 11924 5000
Text mount 422 442 5000
TextField mount 1375 1372 5000
ThemeProvider mount 1210 1234 5000
ThemeProvider virtual-rerender 600 603 5000
ThemeProviderNext mount 7185 7231 5000
Toggle mount 818 762 5000
buttonNative mount 118 115 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 179 163 1.1:1
AvatarMinimalPerf.default 199 182 1.09:1
AttachmentMinimalPerf.default 161 149 1.08:1
ReactionMinimalPerf.default 386 362 1.07:1
ChatMinimalPerf.default 633 600 1.06:1
GridMinimalPerf.default 348 329 1.06:1
ImageMinimalPerf.default 376 355 1.06:1
ListCommonPerf.default 652 616 1.06:1
ChatDuplicateMessagesPerf.default 291 277 1.05:1
RefMinimalPerf.default 243 231 1.05:1
MenuMinimalPerf.default 860 829 1.04:1
AlertMinimalPerf.default 272 264 1.03:1
ButtonMinimalPerf.default 164 159 1.03:1
FormMinimalPerf.default 403 392 1.03:1
HeaderSlotsPerf.default 774 755 1.03:1
DropdownManyItemsPerf.default 685 674 1.02:1
HeaderMinimalPerf.default 365 357 1.02:1
LoaderMinimalPerf.default 704 689 1.02:1
PopupMinimalPerf.default 589 580 1.02:1
PortalMinimalPerf.default 176 172 1.02:1
IconMinimalPerf.default 613 601 1.02:1
TableManyItemsPerf.default 1933 1901 1.02:1
ToolbarMinimalPerf.default 954 938 1.02:1
VideoMinimalPerf.default 621 609 1.02:1
ButtonOverridesMissPerf.default 1679 1667 1.01:1
CheckboxMinimalPerf.default 2750 2717 1.01:1
DropdownMinimalPerf.default 3104 3086 1.01:1
ProviderMergeThemesPerf.default 1686 1672 1.01:1
RadioGroupMinimalPerf.default 441 437 1.01:1
SegmentMinimalPerf.default 345 343 1.01:1
SliderMinimalPerf.default 1542 1532 1.01:1
StatusMinimalPerf.default 679 671 1.01:1
CustomToolbarPrototype.default 3840 3814 1.01:1
TooltipMinimalPerf.default 990 976 1.01:1
CardMinimalPerf.default 544 546 1:1
ChatWithPopoverPerf.default 363 363 1:1
DatepickerMinimalPerf.default 5453 5442 1:1
DialogMinimalPerf.default 749 748 1:1
EmbedMinimalPerf.default 4123 4119 1:1
InputMinimalPerf.default 1268 1270 1:1
ItemLayoutMinimalPerf.default 1262 1256 1:1
RosterPerf.default 1149 1146 1:1
SplitButtonMinimalPerf.default 3746 3736 1:1
TreeMinimalPerf.default 795 793 1:1
AttachmentSlotsPerf.default 1133 1147 0.99:1
DividerMinimalPerf.default 357 359 0.99:1
FlexMinimalPerf.default 284 288 0.99:1
LabelMinimalPerf.default 385 388 0.99:1
LayoutMinimalPerf.default 367 370 0.99:1
ListMinimalPerf.default 511 517 0.99:1
ListNestedPerf.default 550 557 0.99:1
MenuButtonMinimalPerf.default 1550 1566 0.99:1
TableMinimalPerf.default 393 396 0.99:1
TextAreaMinimalPerf.default 480 487 0.99:1
AnimationMinimalPerf.default 408 417 0.98:1
BoxMinimalPerf.default 347 354 0.98:1
ButtonSlotsPerf.default 546 558 0.98:1
SkeletonMinimalPerf.default 347 353 0.98:1
TextMinimalPerf.default 346 353 0.98:1
ListWith60ListItems.default 630 647 0.97:1
ProviderMinimalPerf.default 948 973 0.97:1
CarouselMinimalPerf.default 438 454 0.96:1
AccordionMinimalPerf.default 137 153 0.9:1

@miroslavstastny
Copy link
Member Author

miroslavstastny commented Jun 22, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 22, 2021

Azure Pipelines successfully started running 3 pipeline(s).

@size-auditor
Copy link

size-auditor bot commented Jun 22, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e8ba50878e833b008c006d5171098c10815d79fd (build)

@miroslavstastny miroslavstastny merged commit e4b6b9a into microsoft:master Jun 22, 2021
@miroslavstastny miroslavstastny deleted the fix/nx-project-path branch June 22, 2021 17:09
ecraig12345
ecraig12345 reviewed Jun 22, 2021
View reviewed changes
packages/react-accordion/package.json
"test": "jest",
"docs": "api-extractor run --config=config/api-extractor.local.json --local",
"build:local": "tsc -p . --module esnext --emitDeclarationOnly && node ../../scripts/typescript/normalize-import --output dist/packages/react-accordion/src && yarn docs",
"build:local": "tsc -p . --module esnext --emitDeclarationOnly && node ../../scripts/typescript/normalize-import --output dist/react-accordion/src && yarn docs",
Copy link
Member

@ecraig12345 ecraig12345 Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hotell Do we plan to have a giant nearly-duplicated command like this in every package long-term? At least IMO, this PR is a good demonstration of how that's not particularly maintainable.

Copy link
Contributor

@Hotell Hotell Jun 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • everything is maintainable with our migrations/generators ( that are also properly covered by tests) :)
  • this is a temporary solution (discussed here) to be able to verify api-extractor output locally without building everything with lage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell approved these changes

@ecraig12345 ecraig12345 ecraig12345 left review comments

@bsunderhus bsunderhus Awaiting requested review from bsunderhus

Assignees

@miroslavstastny miroslavstastny

Labels

Area: Build System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tools: nx migration defines wrong --output path for node normalize-import tools: nx migration won't generate api.extractor.json when missing

5 participants

@miroslavstastny @fabricteam @Hotell @ecraig12345 @msft-fluent-ui-bot