react-divider: Migrate to new DX#18625
Merged
msft-fluent-ui-bot merged 10 commits intomicrosoft:masterfrom Jun 18, 2021
Merged
Conversation
32 tasks
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 463d4676927c67058fcf5866ed6989578ead339d (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Panel | mount | 2070 | 1314 | 1000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 818 | 779 | 5000 | |
| BaseButton | mount | 904 | 904 | 5000 | |
| Breadcrumb | mount | 2609 | 2648 | 1000 | |
| ButtonNext | mount | 531 | 517 | 5000 | |
| Checkbox | mount | 1517 | 1494 | 5000 | |
| CheckboxBase | mount | 1283 | 1270 | 5000 | |
| ChoiceGroup | mount | 4699 | 4601 | 5000 | |
| ComboBox | mount | 966 | 977 | 1000 | |
| CommandBar | mount | 9949 | 9997 | 1000 | |
| ContextualMenu | mount | 6202 | 6188 | 1000 | |
| DefaultButton | mount | 1093 | 1081 | 5000 | |
| DetailsRow | mount | 3663 | 3673 | 5000 | |
| DetailsRowFast | mount | 3616 | 3655 | 5000 | |
| DetailsRowNoStyles | mount | 3453 | 3493 | 5000 | |
| Dialog | mount | 2144 | 2122 | 1000 | |
| DocumentCardTitle | mount | 128 | 146 | 1000 | |
| Dropdown | mount | 3188 | 3252 | 5000 | |
| FocusTrapZone | mount | 1727 | 1755 | 5000 | |
| FocusZone | mount | 1774 | 1766 | 5000 | |
| IconButton | mount | 1731 | 1691 | 5000 | |
| Label | mount | 326 | 326 | 5000 | |
| Layer | mount | 1749 | 1726 | 5000 | |
| Link | mount | 458 | 450 | 5000 | |
| MakeStyles | mount | 1822 | 1833 | 50000 | |
| MenuButton | mount | 1452 | 1408 | 5000 | |
| MessageBar | mount | 1996 | 2020 | 5000 | |
| Nav | mount | 3228 | 3220 | 1000 | |
| OverflowSet | mount | 1012 | 1056 | 5000 | |
| Panel | mount | 2070 | 1314 | 1000 | Possible regression |
| Persona | mount | 817 | 811 | 1000 | |
| Pivot | mount | 1353 | 1398 | 1000 | |
| PrimaryButton | mount | 1260 | 1260 | 5000 | |
| Rating | mount | 7526 | 7549 | 5000 | |
| SearchBox | mount | 1292 | 1318 | 5000 | |
| Shimmer | mount | 2478 | 2496 | 5000 | |
| Slider | mount | 1935 | 1938 | 5000 | |
| SpinButton | mount | 4858 | 4892 | 5000 | |
| Spinner | mount | 417 | 411 | 5000 | |
| SplitButton | mount | 3081 | 3104 | 5000 | |
| Stack | mount | 487 | 514 | 5000 | |
| StackWithIntrinsicChildren | mount | 1491 | 1479 | 5000 | |
| StackWithTextChildren | mount | 4429 | 4392 | 5000 | |
| SwatchColorPicker | mount | 10087 | 10053 | 5000 | |
| Tabs | mount | 1408 | 1375 | 1000 | |
| TagPicker | mount | 2416 | 2404 | 5000 | |
| TeachingBubble | mount | 11787 | 11885 | 5000 | |
| Text | mount | 406 | 422 | 5000 | |
| TextField | mount | 1304 | 1376 | 5000 | |
| ThemeProvider | mount | 1146 | 1159 | 5000 | |
| ThemeProvider | virtual-rerender | 613 | 590 | 5000 | |
| ThemeProviderNext | mount | 7071 | 7033 | 5000 | |
| Toggle | mount | 809 | 784 | 5000 | |
| buttonNative | mount | 114 | 104 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Potential regressions comparing to master
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| FlexMinimalPerf.default | 292 | 294 | 0.99:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| SegmentMinimalPerf.default | 363 | 336 | 1.08:1 |
| ButtonMinimalPerf.default | 165 | 156 | 1.06:1 |
| CardMinimalPerf.default | 555 | 524 | 1.06:1 |
| CarouselMinimalPerf.default | 471 | 443 | 1.06:1 |
| HeaderMinimalPerf.default | 361 | 342 | 1.06:1 |
| DropdownManyItemsPerf.default | 701 | 669 | 1.05:1 |
| LayoutMinimalPerf.default | 368 | 352 | 1.05:1 |
| RadioGroupMinimalPerf.default | 435 | 414 | 1.05:1 |
| IconMinimalPerf.default | 598 | 570 | 1.05:1 |
| ChatMinimalPerf.default | 622 | 596 | 1.04:1 |
| TableManyItemsPerf.default | 1927 | 1856 | 1.04:1 |
| TextMinimalPerf.default | 349 | 334 | 1.04:1 |
| AvatarMinimalPerf.default | 199 | 194 | 1.03:1 |
| HeaderSlotsPerf.default | 761 | 737 | 1.03:1 |
| LoaderMinimalPerf.default | 690 | 672 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1584 | 1542 | 1.03:1 |
| TableMinimalPerf.default | 404 | 392 | 1.03:1 |
| TreeWith60ListItems.default | 176 | 171 | 1.03:1 |
| VideoMinimalPerf.default | 610 | 590 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 295 | 288 | 1.02:1 |
| SkeletonMinimalPerf.default | 358 | 350 | 1.02:1 |
| CustomToolbarPrototype.default | 3782 | 3712 | 1.02:1 |
| TreeMinimalPerf.default | 790 | 776 | 1.02:1 |
| AnimationMinimalPerf.default | 404 | 400 | 1.01:1 |
| AttachmentSlotsPerf.default | 1116 | 1106 | 1.01:1 |
| CheckboxMinimalPerf.default | 2728 | 2702 | 1.01:1 |
| ImageMinimalPerf.default | 364 | 361 | 1.01:1 |
| LabelMinimalPerf.default | 383 | 380 | 1.01:1 |
| RosterPerf.default | 1173 | 1159 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1677 | 1663 | 1.01:1 |
| ReactionMinimalPerf.default | 369 | 364 | 1.01:1 |
| RefMinimalPerf.default | 236 | 233 | 1.01:1 |
| StatusMinimalPerf.default | 664 | 660 | 1.01:1 |
| AlertMinimalPerf.default | 262 | 263 | 1:1 |
| AttachmentMinimalPerf.default | 154 | 154 | 1:1 |
| BoxMinimalPerf.default | 345 | 345 | 1:1 |
| ButtonOverridesMissPerf.default | 1663 | 1671 | 1:1 |
| DatepickerMinimalPerf.default | 5328 | 5334 | 1:1 |
| EmbedMinimalPerf.default | 4084 | 4086 | 1:1 |
| GridMinimalPerf.default | 340 | 341 | 1:1 |
| InputMinimalPerf.default | 1251 | 1250 | 1:1 |
| ListCommonPerf.default | 600 | 598 | 1:1 |
| ListWith60ListItems.default | 669 | 669 | 1:1 |
| MenuMinimalPerf.default | 851 | 847 | 1:1 |
| PopupMinimalPerf.default | 571 | 571 | 1:1 |
| ProviderMinimalPerf.default | 953 | 955 | 1:1 |
| SliderMinimalPerf.default | 1549 | 1545 | 1:1 |
| DividerMinimalPerf.default | 356 | 358 | 0.99:1 |
| DropdownMinimalPerf.default | 3034 | 3057 | 0.99:1 |
| ListMinimalPerf.default | 498 | 504 | 0.99:1 |
| SplitButtonMinimalPerf.default | 3689 | 3732 | 0.99:1 |
| ToolbarMinimalPerf.default | 899 | 911 | 0.99:1 |
| TooltipMinimalPerf.default | 982 | 989 | 0.99:1 |
| DialogMinimalPerf.default | 726 | 739 | 0.98:1 |
| ItemLayoutMinimalPerf.default | 1226 | 1261 | 0.97:1 |
| TextAreaMinimalPerf.default | 473 | 487 | 0.97:1 |
| PortalMinimalPerf.default | 173 | 180 | 0.96:1 |
| ButtonSlotsPerf.default | 533 | 560 | 0.95:1 |
| ChatWithPopoverPerf.default | 344 | 362 | 0.95:1 |
| FormMinimalPerf.default | 387 | 408 | 0.95:1 |
| ListNestedPerf.default | 532 | 563 | 0.94:1 |
| AccordionMinimalPerf.default | 146 | 159 | 0.92:1 |
Contributor
|
some lint violations need to be fixed 🙏 |
Hotell
reviewed
Jun 18, 2021
Collaborator
|
Hello @TristanWatanabe! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 2 hours 47 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
react-dividerpackage to new DX usingnx workspace-generator migrate-converged-pkg